Fix clippy warnings added in nightly (#1833)

diff --git a/crates/api/src/comment.rs b/crates/api/src/comment.rs
index 1d1d3088f087b01b577f16c6b0a8d9a07ccd5836..951bd395fca60eac48777d4a0f333cba04ee2114 100644 (file)
--- a/crates/api/src/comment.rs
+++ b/crates/api/src/comment.rs
@@ -188,7 +188,7 @@ impl Perform for CreateCommentLike {
 
     // Only add the like if the score isnt 0
     let comment = orig_comment.comment;
-    let object = PostOrComment::Comment(Box::new(comment));
+    let object = PostOrComment::Comment(comment);
     let do_add = like_form.score != 0 && (like_form.score == 1 || like_form.score == -1);
     if do_add {
       let like_form2 = like_form.clone();

diff --git a/crates/api/src/community.rs b/crates/api/src/community.rs
index 28a79c701f8b8ed650262c671d3d7ef66168dab4..f4548be6dec35485ed2e269da6cd500e63361890 100644 (file)
--- a/crates/api/src/community.rs
+++ b/crates/api/src/community.rs
@@ -409,7 +409,7 @@ impl Perform for TransferCommunity {
     })
     .await??;
 
-    let mut admins = blocking(context.pool(), move |conn| PersonViewSafe::admins(conn)).await??;
+    let mut admins = blocking(context.pool(), PersonViewSafe::admins).await??;
 
     // Making sure the site creator, if an admin, is at the top
     let creator_index = admins

diff --git a/crates/api/src/local_user.rs b/crates/api/src/local_user.rs
index 930be955de83cce4ae7b2770f6730ee07f8d98ee..ff732e6bbfcfc2107a95a66c407759b01de6a2c4 100644 (file)
--- a/crates/api/src/local_user.rs
+++ b/crates/api/src/local_user.rs
@@ -375,7 +375,7 @@ impl Perform for AddAdmin {
     })
     .await??;
 
-    let mut admins = blocking(context.pool(), move |conn| PersonViewSafe::admins(conn)).await??;
+    let mut admins = blocking(context.pool(), PersonViewSafe::admins).await??;
     let creator_index = admins
       .iter()
       .position(|r| r.person.id == site_creator_id)

diff --git a/crates/api/src/site.rs b/crates/api/src/site.rs
index 01f7b45f19ce787845a4d888e3e82a73976b75ec..a8d2e73381ab8dccc2aa17513d3811e4d63d1a8a 100644 (file)
--- a/crates/api/src/site.rs
+++ b/crates/api/src/site.rs
@@ -472,9 +472,9 @@ impl Perform for TransferSite {
 
     blocking(context.pool(), move |conn| ModAdd::create(conn, &form)).await??;
 
-    let site_view = blocking(context.pool(), move |conn| SiteView::read(conn)).await??;
+    let site_view = blocking(context.pool(), SiteView::read).await??;
 
-    let mut admins = blocking(context.pool(), move |conn| PersonViewSafe::admins(conn)).await??;
+    let mut admins = blocking(context.pool(), PersonViewSafe::admins).await??;
     let creator_index = admins
       .iter()
       .position(|r| r.person.id == site_view.creator.id)
@@ -482,7 +482,7 @@ impl Perform for TransferSite {
     let creator_person = admins.remove(creator_index);
     admins.insert(0, creator_person);
 
-    let banned = blocking(context.pool(), move |conn| PersonViewSafe::banned(conn)).await??;
+    let banned = blocking(context.pool(), PersonViewSafe::banned).await??;
     let federated_instances = build_federated_instances(
       context.pool(),
       &context.settings().federation,

diff --git a/crates/api_crud/src/comment/create.rs b/crates/api_crud/src/comment/create.rs
index 7d49fe13445beb171aca5e03806c4feacb203542..c357e60474827dde2641f941ea2a5771fd579181 100644 (file)
--- a/crates/api_crud/src/comment/create.rs
+++ b/crates/api_crud/src/comment/create.rs
@@ -146,7 +146,7 @@ impl PerformCrud for CreateComment {
       return Err(ApiError::err("couldnt_like_comment").into());
     }
 
-    let object = PostOrComment::Comment(Box::new(updated_comment));
+    let object = PostOrComment::Comment(updated_comment);
     Vote::send(
       &object,
       &local_user_view.person,

diff --git a/crates/api_crud/src/site/create.rs b/crates/api_crud/src/site/create.rs
index 8038f62cbd58cffe50a3ed41c6253a043874a182..658d4cf8f2733f391ecf937c5b9e826b3c0cfdc6 100644 (file)
--- a/crates/api_crud/src/site/create.rs
+++ b/crates/api_crud/src/site/create.rs
@@ -76,7 +76,7 @@ impl PerformCrud for CreateSite {
       return Err(ApiError::err("site_already_exists").into());
     }
 
-    let site_view = blocking(context.pool(), move |conn| SiteView::read(conn)).await??;
+    let site_view = blocking(context.pool(), SiteView::read).await??;
 
     Ok(SiteResponse { site_view })
   }

diff --git a/crates/api_crud/src/site/read.rs b/crates/api_crud/src/site/read.rs
index 2668939ef7f0ad2a83f526835e207266210e1801..88c6e6ea3e157b6f50b72a3e2c9e946803d8c281 100644 (file)
--- a/crates/api_crud/src/site/read.rs
+++ b/crates/api_crud/src/site/read.rs
@@ -30,7 +30,7 @@ impl PerformCrud for GetSite {
   ) -> Result<GetSiteResponse, LemmyError> {
     let data: &GetSite = self;
 
-    let site_view = match blocking(context.pool(), move |conn| SiteView::read(conn)).await? {
+    let site_view = match blocking(context.pool(), SiteView::read).await? {
       Ok(site_view) => Some(site_view),
       // If the site isn't created yet, check the setup
       Err(_) => {
@@ -62,14 +62,14 @@ impl PerformCrud for GetSite {
           };
           create_site.perform(context, websocket_id).await?;
           info!("Site {} created", setup.site_name);
-          Some(blocking(context.pool(), move |conn| SiteView::read(conn)).await??)
+          Some(blocking(context.pool(), SiteView::read).await??)
         } else {
           None
         }
       }
     };
 
-    let mut admins = blocking(context.pool(), move |conn| PersonViewSafe::admins(conn)).await??;
+    let mut admins = blocking(context.pool(), PersonViewSafe::admins).await??;
 
     // Make sure the site creator is the top admin
     if let Some(site_view) = site_view.to_owned() {
@@ -82,7 +82,7 @@ impl PerformCrud for GetSite {
       }
     }
 
-    let banned = blocking(context.pool(), move |conn| PersonViewSafe::banned(conn)).await??;
+    let banned = blocking(context.pool(), PersonViewSafe::banned).await??;
 
     let online = context
       .chat_server()

diff --git a/crates/api_crud/src/site/update.rs b/crates/api_crud/src/site/update.rs
index b92cfd4a191b3118a9f2391a118867671444ba63..2190d02c32aa658cc9d307068b22ebc390c1a770 100644 (file)
--- a/crates/api_crud/src/site/update.rs
+++ b/crates/api_crud/src/site/update.rs
@@ -69,7 +69,7 @@ impl PerformCrud for EditSite {
       return Err(ApiError::err("couldnt_update_site").into());
     }
 
-    let site_view = blocking(context.pool(), move |conn| SiteView::read(conn)).await??;
+    let site_view = blocking(context.pool(), SiteView::read).await??;
 
     let res = SiteResponse { site_view };
 

diff --git a/crates/apub/src/activities/voting/undo_vote.rs b/crates/apub/src/activities/voting/undo_vote.rs
index d59db4a4d5bf6953bda09cf9068b04a3dd3990f5..bfb74371d74488ea57b6191f8e440f4ef982a0ef 100644 (file)
--- a/crates/apub/src/activities/voting/undo_vote.rs
+++ b/crates/apub/src/activities/voting/undo_vote.rs
@@ -115,7 +115,7 @@ impl ActivityHandler for UndoVote {
       .await?;
     match object {
       PostOrComment::Post(p) => undo_vote_post(actor, p.deref(), context).await,
-      PostOrComment::Comment(c) => undo_vote_comment(actor, c.deref(), context).await,
+      PostOrComment::Comment(c) => undo_vote_comment(actor, &c, context).await,
     }
   }
 }

diff --git a/crates/apub/src/activities/voting/vote.rs b/crates/apub/src/activities/voting/vote.rs
index a68631759e56f9ed19936b43dd8f4e59ba03d063..4d85375460ec4e012a9f7f967a7d8bc38a1fa488 100644 (file)
--- a/crates/apub/src/activities/voting/vote.rs
+++ b/crates/apub/src/activities/voting/vote.rs
@@ -134,7 +134,7 @@ impl ActivityHandler for Vote {
     let object = self.object.dereference(context, request_counter).await?;
     match object {
       PostOrComment::Post(p) => vote_post(&self.kind, actor, p.deref(), context).await,
-      PostOrComment::Comment(c) => vote_comment(&self.kind, actor, c.deref(), context).await,
+      PostOrComment::Comment(c) => vote_comment(&self.kind, actor, &c, context).await,
     }
   }
 }

diff --git a/crates/apub/src/fetcher/post_or_comment.rs b/crates/apub/src/fetcher/post_or_comment.rs
index 7971cedba322c56c46f68c4b01df22b382fb108c..ff07024fc3a6c4fb8d1cd54f935c0dd5cf59d7da 100644 (file)
--- a/crates/apub/src/fetcher/post_or_comment.rs
+++ b/crates/apub/src/fetcher/post_or_comment.rs
@@ -13,19 +13,19 @@ use url::Url;
 
 #[derive(Clone, Debug)]
 pub enum PostOrComment {
-  Comment(Box<Comment>),
   Post(Box<Post>),
+  Comment(Comment),
 }
 
 pub enum PostOrCommentForm {
-  PostForm(PostForm),
+  PostForm(Box<PostForm>),
   CommentForm(CommentForm),
 }
 
 #[derive(Deserialize)]
 pub enum PageOrNote {
-  Page(Page),
-  Note(Note),
+  Page(Box<Page>),
+  Note(Box<Note>),
 }
 
 #[async_trait::async_trait(?Send)]
@@ -44,9 +44,7 @@ impl ApubObject for PostOrComment {
     let post = Post::read_from_apub_id(conn, object_id.clone())?;
     Ok(match post {
       Some(o) => Some(PostOrComment::Post(Box::new(o))),
-      None => {
-        Comment::read_from_apub_id(conn, object_id)?.map(|c| PostOrComment::Comment(Box::new(c)))
-      }
+      None => Comment::read_from_apub_id(conn, object_id)?.map(PostOrComment::Comment),
     })
   }
 }
@@ -68,9 +66,9 @@ impl FromApub for PostOrComment {
       PageOrNote::Page(p) => PostOrComment::Post(Box::new(
         Post::from_apub(p, context, expected_domain, request_counter).await?,
       )),
-      PageOrNote::Note(n) => PostOrComment::Comment(Box::new(
+      PageOrNote::Note(n) => PostOrComment::Comment(
         Comment::from_apub(n, context, expected_domain, request_counter).await?,
-      )),
+      ),
     })
   }
 }

diff --git a/crates/routes/src/feeds.rs b/crates/routes/src/feeds.rs
index 66e23ee3e94b891be97fd07120a50e58cfcaf668..a02b5fe3309dfb4dab46b2c40f039641a1ead6aa 100644 (file)
--- a/crates/routes/src/feeds.rs
+++ b/crates/routes/src/feeds.rs
@@ -83,7 +83,7 @@ async fn get_feed_data(
   listing_type: ListingType,
   sort_type: SortType,
 ) -> Result<HttpResponse, LemmyError> {
-  let site_view = blocking(context.pool(), move |conn| SiteView::read(conn)).await??;
+  let site_view = blocking(context.pool(), SiteView::read).await??;
 
   let posts = blocking(context.pool(), move |conn| {
     PostQueryBuilder::create(conn)