From: Felix Ableitner <me@nutomic.com>
Date: Thu, 5 Nov 2020 15:13:01 +0000 (+0100)
Subject: Also check for ban when sending private message notification
X-Git-Url: http://these/git/%22https:/join-lemmy.org/%7Bthis.state.url%7D?a=commitdiff_plain;h=c6c74ab1e3f44b6cb74ca9a3dac150458746616f;p=lemmy.git

Also check for ban when sending private message notification
---

diff --git a/lemmy_api/src/user.rs b/lemmy_api/src/user.rs
index ad3d9808..6dffc1a7 100644
--- a/lemmy_api/src/user.rs
+++ b/lemmy_api/src/user.rs
@@ -38,7 +38,7 @@ use lemmy_db::{
   ListingType,
   SortType,
 };
-use lemmy_structs::{blocking, user::*};
+use lemmy_structs::{blocking, send_email_to_user, user::*};
 use lemmy_utils::{
   apub::{generate_actor_keypair, make_apub_endpoint, EndpointType},
   email::send_email,
@@ -61,7 +61,6 @@ use lemmy_websocket::{
   LemmyContext,
   UserOperation,
 };
-use log::error;
 use std::str::FromStr;
 
 #[async_trait::async_trait(?Send)]
@@ -1041,23 +1040,12 @@ impl Perform for CreatePrivateMessage {
     let recipient_user =
       blocking(context.pool(), move |conn| User_::read(conn, recipient_id)).await??;
     if recipient_user.send_notifications_to_email {
-      if let Some(email) = recipient_user.email {
-        let subject = &format!(
-          "{} - Private Message from {}",
-          Settings::get().hostname,
-          user.name,
-        );
-        let html = &format!(
-          "<h1>Private Message</h1><br><div>{} - {}</div><br><a href={}/inbox>inbox</a>",
-          user.name,
-          &content_slurs_removed,
-          Settings::get().get_protocol_and_hostname()
-        );
-        match send_email(subject, &email, &recipient_user.name, html) {
-          Ok(_o) => _o,
-          Err(e) => error!("{}", e),
-        };
-      }
+      send_email_to_user(
+        recipient_user,
+        "Private Message from",
+        "Private Message",
+        &content_slurs_removed,
+      );
     }
 
     let message = blocking(context.pool(), move |conn| {
diff --git a/lemmy_structs/src/lib.rs b/lemmy_structs/src/lib.rs
index 070cebfb..5d2e4273 100644
--- a/lemmy_structs/src/lib.rs
+++ b/lemmy_structs/src/lib.rs
@@ -146,7 +146,7 @@ fn do_send_local_notifs(
   recipient_ids
 }
 
-fn send_email_to_user(user: User_, subject_text: &str, body_text: &str, comment_content: &str) {
+pub fn send_email_to_user(user: User_, subject_text: &str, body_text: &str, comment_content: &str) {
   if user.banned {
     return;
   }