From: Sander Saarend <sander@saarend.com>
Date: Fri, 16 Jun 2023 15:53:33 +0000 (+0300)
Subject: Remove e-mail verification success e-mails (#3124)
X-Git-Url: http://these/git/%22https:/nerdica.net/%7B%24%7B%60data:application/manifest%20json;base64%2C%24%7Bawait?a=commitdiff_plain;h=007c7d58120dcb7ffe6ed3a222a49668050e5232;p=lemmy.git

Remove e-mail verification success e-mails (#3124)
---

diff --git a/crates/api/src/local_user/verify_email.rs b/crates/api/src/local_user/verify_email.rs
index 80befc5a..0807eebe 100644
--- a/crates/api/src/local_user/verify_email.rs
+++ b/crates/api/src/local_user/verify_email.rs
@@ -3,7 +3,6 @@ use actix_web::web::Data;
 use lemmy_api_common::{
   context::LemmyContext,
   person::{VerifyEmail, VerifyEmailResponse},
-  utils::send_email_verification_success,
 };
 use lemmy_db_schema::{
   source::{
@@ -12,7 +11,6 @@ use lemmy_db_schema::{
   },
   traits::Crud,
 };
-use lemmy_db_views::structs::LocalUserView;
 use lemmy_utils::error::LemmyError;
 
 #[async_trait::async_trait(?Send)]
@@ -35,10 +33,6 @@ impl Perform for VerifyEmail {
 
     LocalUser::update(context.pool(), local_user_id, &form).await?;
 
-    let local_user_view = LocalUserView::read(context.pool(), local_user_id).await?;
-
-    send_email_verification_success(&local_user_view, context.settings())?;
-
     EmailVerification::delete_old_tokens_for_local_user(context.pool(), local_user_id).await?;
 
     Ok(VerifyEmailResponse {})
diff --git a/crates/api_common/src/utils.rs b/crates/api_common/src/utils.rs
index 1912221e..602dd6ac 100644
--- a/crates/api_common/src/utils.rs
+++ b/crates/api_common/src/utils.rs
@@ -403,17 +403,6 @@ pub async fn send_verification_email(
   Ok(())
 }
 
-pub fn send_email_verification_success(
-  user: &LocalUserView,
-  settings: &Settings,
-) -> Result<(), LemmyError> {
-  let email = &user.local_user.email.clone().expect("email");
-  let lang = get_interface_language(user);
-  let subject = &lang.email_verified_subject(&user.person.actor_id);
-  let body = &lang.email_verified_body();
-  send_email(subject, email, &user.person.name, body, settings)
-}
-
 pub fn get_interface_language(user: &LocalUserView) -> Lang {
   lang_str_to_lang(&user.local_user.interface_language)
 }