]> Untitled Git - lemmy.git/blob - crates/db_views/src/post_view.rs
Fix nsfw posts showing for non-logged in users. Fixes #1614 (#1615)
[lemmy.git] / crates / db_views / src / post_view.rs
1 use diesel::{pg::Pg, result::Error, *};
2 use lemmy_db_queries::{
3   aggregates::post_aggregates::PostAggregates,
4   functions::hot_rank,
5   fuzzy_search,
6   limit_and_offset,
7   ListingType,
8   MaybeOptional,
9   SortType,
10   ToSafe,
11   ViewToVec,
12 };
13 use lemmy_db_schema::{
14   schema::{
15     community,
16     community_follower,
17     community_person_ban,
18     person,
19     post,
20     post_aggregates,
21     post_like,
22     post_read,
23     post_saved,
24   },
25   source::{
26     community::{Community, CommunityFollower, CommunityPersonBan, CommunitySafe},
27     person::{Person, PersonSafe},
28     post::{Post, PostRead, PostSaved},
29   },
30   CommunityId,
31   PersonId,
32   PostId,
33 };
34 use log::debug;
35 use serde::Serialize;
36
37 #[derive(Debug, PartialEq, Serialize, Clone)]
38 pub struct PostView {
39   pub post: Post,
40   pub creator: PersonSafe,
41   pub community: CommunitySafe,
42   pub creator_banned_from_community: bool, // Left Join to CommunityPersonBan
43   pub counts: PostAggregates,
44   pub subscribed: bool,     // Left join to CommunityFollower
45   pub saved: bool,          // Left join to PostSaved
46   pub read: bool,           // Left join to PostRead
47   pub my_vote: Option<i16>, // Left join to PostLike
48 }
49
50 type PostViewTuple = (
51   Post,
52   PersonSafe,
53   CommunitySafe,
54   Option<CommunityPersonBan>,
55   PostAggregates,
56   Option<CommunityFollower>,
57   Option<PostSaved>,
58   Option<PostRead>,
59   Option<i16>,
60 );
61
62 impl PostView {
63   pub fn read(
64     conn: &PgConnection,
65     post_id: PostId,
66     my_person_id: Option<PersonId>,
67   ) -> Result<Self, Error> {
68     // The left join below will return None in this case
69     let person_id_join = my_person_id.unwrap_or(PersonId(-1));
70
71     let (
72       post,
73       creator,
74       community,
75       creator_banned_from_community,
76       counts,
77       follower,
78       saved,
79       read,
80       post_like,
81     ) = post::table
82       .find(post_id)
83       .inner_join(person::table)
84       .inner_join(community::table)
85       .left_join(
86         community_person_ban::table.on(
87           post::community_id
88             .eq(community_person_ban::community_id)
89             .and(community_person_ban::person_id.eq(post::creator_id)),
90         ),
91       )
92       .inner_join(post_aggregates::table)
93       .left_join(
94         community_follower::table.on(
95           post::community_id
96             .eq(community_follower::community_id)
97             .and(community_follower::person_id.eq(person_id_join)),
98         ),
99       )
100       .left_join(
101         post_saved::table.on(
102           post::id
103             .eq(post_saved::post_id)
104             .and(post_saved::person_id.eq(person_id_join)),
105         ),
106       )
107       .left_join(
108         post_read::table.on(
109           post::id
110             .eq(post_read::post_id)
111             .and(post_read::person_id.eq(person_id_join)),
112         ),
113       )
114       .left_join(
115         post_like::table.on(
116           post::id
117             .eq(post_like::post_id)
118             .and(post_like::person_id.eq(person_id_join)),
119         ),
120       )
121       .select((
122         post::all_columns,
123         Person::safe_columns_tuple(),
124         Community::safe_columns_tuple(),
125         community_person_ban::all_columns.nullable(),
126         post_aggregates::all_columns,
127         community_follower::all_columns.nullable(),
128         post_saved::all_columns.nullable(),
129         post_read::all_columns.nullable(),
130         post_like::score.nullable(),
131       ))
132       .first::<PostViewTuple>(conn)?;
133
134     // If a person is given, then my_vote, if None, should be 0, not null
135     // Necessary to differentiate between other person's votes
136     let my_vote = if my_person_id.is_some() && post_like.is_none() {
137       Some(0)
138     } else {
139       post_like
140     };
141
142     Ok(PostView {
143       post,
144       creator,
145       community,
146       creator_banned_from_community: creator_banned_from_community.is_some(),
147       counts,
148       subscribed: follower.is_some(),
149       saved: saved.is_some(),
150       read: read.is_some(),
151       my_vote,
152     })
153   }
154 }
155
156 pub struct PostQueryBuilder<'a> {
157   conn: &'a PgConnection,
158   listing_type: Option<ListingType>,
159   sort: Option<SortType>,
160   creator_id: Option<PersonId>,
161   community_id: Option<CommunityId>,
162   community_name: Option<String>,
163   my_person_id: Option<PersonId>,
164   search_term: Option<String>,
165   url_search: Option<String>,
166   show_nsfw: Option<bool>,
167   show_bot_accounts: Option<bool>,
168   show_read_posts: Option<bool>,
169   saved_only: Option<bool>,
170   page: Option<i64>,
171   limit: Option<i64>,
172 }
173
174 impl<'a> PostQueryBuilder<'a> {
175   pub fn create(conn: &'a PgConnection) -> Self {
176     PostQueryBuilder {
177       conn,
178       listing_type: None,
179       sort: None,
180       creator_id: None,
181       community_id: None,
182       community_name: None,
183       my_person_id: None,
184       search_term: None,
185       url_search: None,
186       show_nsfw: None,
187       show_bot_accounts: None,
188       show_read_posts: None,
189       saved_only: None,
190       page: None,
191       limit: None,
192     }
193   }
194
195   pub fn listing_type<T: MaybeOptional<ListingType>>(mut self, listing_type: T) -> Self {
196     self.listing_type = listing_type.get_optional();
197     self
198   }
199
200   pub fn sort<T: MaybeOptional<SortType>>(mut self, sort: T) -> Self {
201     self.sort = sort.get_optional();
202     self
203   }
204
205   pub fn community_id<T: MaybeOptional<CommunityId>>(mut self, community_id: T) -> Self {
206     self.community_id = community_id.get_optional();
207     self
208   }
209
210   pub fn my_person_id<T: MaybeOptional<PersonId>>(mut self, my_person_id: T) -> Self {
211     self.my_person_id = my_person_id.get_optional();
212     self
213   }
214
215   pub fn community_name<T: MaybeOptional<String>>(mut self, community_name: T) -> Self {
216     self.community_name = community_name.get_optional();
217     self
218   }
219
220   pub fn creator_id<T: MaybeOptional<PersonId>>(mut self, creator_id: T) -> Self {
221     self.creator_id = creator_id.get_optional();
222     self
223   }
224
225   pub fn search_term<T: MaybeOptional<String>>(mut self, search_term: T) -> Self {
226     self.search_term = search_term.get_optional();
227     self
228   }
229
230   pub fn url_search<T: MaybeOptional<String>>(mut self, url_search: T) -> Self {
231     self.url_search = url_search.get_optional();
232     self
233   }
234
235   pub fn show_nsfw<T: MaybeOptional<bool>>(mut self, show_nsfw: T) -> Self {
236     self.show_nsfw = show_nsfw.get_optional();
237     self
238   }
239
240   pub fn show_bot_accounts<T: MaybeOptional<bool>>(mut self, show_bot_accounts: T) -> Self {
241     self.show_bot_accounts = show_bot_accounts.get_optional();
242     self
243   }
244
245   pub fn show_read_posts<T: MaybeOptional<bool>>(mut self, show_read_posts: T) -> Self {
246     self.show_read_posts = show_read_posts.get_optional();
247     self
248   }
249
250   pub fn saved_only<T: MaybeOptional<bool>>(mut self, saved_only: T) -> Self {
251     self.saved_only = saved_only.get_optional();
252     self
253   }
254
255   pub fn page<T: MaybeOptional<i64>>(mut self, page: T) -> Self {
256     self.page = page.get_optional();
257     self
258   }
259
260   pub fn limit<T: MaybeOptional<i64>>(mut self, limit: T) -> Self {
261     self.limit = limit.get_optional();
262     self
263   }
264
265   pub fn list(self) -> Result<Vec<PostView>, Error> {
266     use diesel::dsl::*;
267
268     // The left join below will return None in this case
269     let person_id_join = self.my_person_id.unwrap_or(PersonId(-1));
270
271     let mut query = post::table
272       .inner_join(person::table)
273       .inner_join(community::table)
274       .left_join(
275         community_person_ban::table.on(
276           post::community_id
277             .eq(community_person_ban::community_id)
278             .and(community_person_ban::person_id.eq(post::creator_id)),
279         ),
280       )
281       .inner_join(post_aggregates::table)
282       .left_join(
283         community_follower::table.on(
284           post::community_id
285             .eq(community_follower::community_id)
286             .and(community_follower::person_id.eq(person_id_join)),
287         ),
288       )
289       .left_join(
290         post_saved::table.on(
291           post::id
292             .eq(post_saved::post_id)
293             .and(post_saved::person_id.eq(person_id_join)),
294         ),
295       )
296       .left_join(
297         post_read::table.on(
298           post::id
299             .eq(post_read::post_id)
300             .and(post_read::person_id.eq(person_id_join)),
301         ),
302       )
303       .left_join(
304         post_like::table.on(
305           post::id
306             .eq(post_like::post_id)
307             .and(post_like::person_id.eq(person_id_join)),
308         ),
309       )
310       .select((
311         post::all_columns,
312         Person::safe_columns_tuple(),
313         Community::safe_columns_tuple(),
314         community_person_ban::all_columns.nullable(),
315         post_aggregates::all_columns,
316         community_follower::all_columns.nullable(),
317         post_saved::all_columns.nullable(),
318         post_read::all_columns.nullable(),
319         post_like::score.nullable(),
320       ))
321       .into_boxed();
322
323     if let Some(listing_type) = self.listing_type {
324       query = match listing_type {
325         ListingType::Subscribed => query.filter(community_follower::person_id.is_not_null()),
326         ListingType::Local => query.filter(community::local.eq(true)),
327         _ => query,
328       };
329     }
330
331     if let Some(community_id) = self.community_id {
332       query = query
333         .filter(post::community_id.eq(community_id))
334         .then_order_by(post_aggregates::stickied.desc());
335     }
336
337     if let Some(community_name) = self.community_name {
338       query = query
339         .filter(community::name.eq(community_name))
340         .filter(community::local.eq(true))
341         .then_order_by(post_aggregates::stickied.desc());
342     }
343
344     if let Some(url_search) = self.url_search {
345       query = query.filter(post::url.eq(url_search));
346     }
347
348     if let Some(search_term) = self.search_term {
349       let searcher = fuzzy_search(&search_term);
350       query = query.filter(
351         post::name
352           .ilike(searcher.to_owned())
353           .or(post::body.ilike(searcher)),
354       );
355     }
356
357     // If its for a specific person, show the removed / deleted
358     if let Some(creator_id) = self.creator_id {
359       query = query.filter(post::creator_id.eq(creator_id));
360     }
361
362     if !self.show_nsfw.unwrap_or(false) {
363       query = query
364         .filter(post::nsfw.eq(false))
365         .filter(community::nsfw.eq(false));
366     };
367
368     if !self.show_bot_accounts.unwrap_or(true) {
369       query = query.filter(person::bot_account.eq(false));
370     };
371
372     if !self.show_read_posts.unwrap_or(true) {
373       query = query.filter(post_read::id.is_null());
374     };
375
376     if self.saved_only.unwrap_or(false) {
377       query = query.filter(post_saved::id.is_not_null());
378     };
379
380     query = match self.sort.unwrap_or(SortType::Hot) {
381       SortType::Active => query
382         .then_order_by(
383           hot_rank(
384             post_aggregates::score,
385             post_aggregates::newest_comment_time_necro,
386           )
387           .desc(),
388         )
389         .then_order_by(post_aggregates::newest_comment_time_necro.desc()),
390       SortType::Hot => query
391         .then_order_by(hot_rank(post_aggregates::score, post_aggregates::published).desc())
392         .then_order_by(post_aggregates::published.desc()),
393       SortType::New => query.then_order_by(post_aggregates::published.desc()),
394       SortType::MostComments => query.then_order_by(post_aggregates::comments.desc()),
395       SortType::NewComments => query.then_order_by(post_aggregates::newest_comment_time.desc()),
396       SortType::TopAll => query.then_order_by(post_aggregates::score.desc()),
397       SortType::TopYear => query
398         .filter(post::published.gt(now - 1.years()))
399         .then_order_by(post_aggregates::score.desc()),
400       SortType::TopMonth => query
401         .filter(post::published.gt(now - 1.months()))
402         .then_order_by(post_aggregates::score.desc()),
403       SortType::TopWeek => query
404         .filter(post::published.gt(now - 1.weeks()))
405         .then_order_by(post_aggregates::score.desc()),
406       SortType::TopDay => query
407         .filter(post::published.gt(now - 1.days()))
408         .then_order_by(post_aggregates::score.desc()),
409     };
410
411     let (limit, offset) = limit_and_offset(self.page, self.limit);
412
413     query = query
414       .limit(limit)
415       .offset(offset)
416       .filter(post::removed.eq(false))
417       .filter(post::deleted.eq(false))
418       .filter(community::removed.eq(false))
419       .filter(community::deleted.eq(false));
420
421     debug!("Post View Query: {:?}", debug_query::<Pg, _>(&query));
422
423     let res = query.load::<PostViewTuple>(self.conn)?;
424
425     Ok(PostView::from_tuple_to_vec(res))
426   }
427 }
428
429 impl ViewToVec for PostView {
430   type DbTuple = PostViewTuple;
431   fn from_tuple_to_vec(items: Vec<Self::DbTuple>) -> Vec<Self> {
432     items
433       .iter()
434       .map(|a| Self {
435         post: a.0.to_owned(),
436         creator: a.1.to_owned(),
437         community: a.2.to_owned(),
438         creator_banned_from_community: a.3.is_some(),
439         counts: a.4.to_owned(),
440         subscribed: a.5.is_some(),
441         saved: a.6.is_some(),
442         read: a.7.is_some(),
443         my_vote: a.8,
444       })
445       .collect::<Vec<Self>>()
446   }
447 }
448
449 #[cfg(test)]
450 mod tests {
451   use crate::post_view::{PostQueryBuilder, PostView};
452   use lemmy_db_queries::{
453     aggregates::post_aggregates::PostAggregates,
454     establish_unpooled_connection,
455     Crud,
456     Likeable,
457     ListingType,
458     SortType,
459   };
460   use lemmy_db_schema::source::{community::*, person::*, post::*};
461   use serial_test::serial;
462
463   #[test]
464   #[serial]
465   fn test_crud() {
466     let conn = establish_unpooled_connection();
467
468     let person_name = "tegan".to_string();
469     let community_name = "test_community_3".to_string();
470     let post_name = "test post 3".to_string();
471     let bot_post_name = "test bot post".to_string();
472
473     let new_person = PersonForm {
474       name: person_name.to_owned(),
475       ..PersonForm::default()
476     };
477
478     let inserted_person = Person::create(&conn, &new_person).unwrap();
479
480     let new_bot = PersonForm {
481       name: person_name.to_owned(),
482       bot_account: Some(true),
483       ..PersonForm::default()
484     };
485
486     let inserted_bot = Person::create(&conn, &new_bot).unwrap();
487
488     let new_community = CommunityForm {
489       name: community_name.to_owned(),
490       title: "nada".to_owned(),
491       ..CommunityForm::default()
492     };
493
494     let inserted_community = Community::create(&conn, &new_community).unwrap();
495
496     let new_post = PostForm {
497       name: post_name.to_owned(),
498       creator_id: inserted_person.id,
499       community_id: inserted_community.id,
500       ..PostForm::default()
501     };
502
503     let inserted_post = Post::create(&conn, &new_post).unwrap();
504
505     let new_bot_post = PostForm {
506       name: bot_post_name,
507       creator_id: inserted_bot.id,
508       community_id: inserted_community.id,
509       ..PostForm::default()
510     };
511
512     let _inserted_bot_post = Post::create(&conn, &new_bot_post).unwrap();
513
514     let post_like_form = PostLikeForm {
515       post_id: inserted_post.id,
516       person_id: inserted_person.id,
517       score: 1,
518     };
519
520     let inserted_post_like = PostLike::like(&conn, &post_like_form).unwrap();
521
522     let expected_post_like = PostLike {
523       id: inserted_post_like.id,
524       post_id: inserted_post.id,
525       person_id: inserted_person.id,
526       published: inserted_post_like.published,
527       score: 1,
528     };
529
530     let read_post_listings_with_person = PostQueryBuilder::create(&conn)
531       .listing_type(ListingType::Community)
532       .sort(SortType::New)
533       .show_bot_accounts(false)
534       .community_id(inserted_community.id)
535       .my_person_id(inserted_person.id)
536       .list()
537       .unwrap();
538
539     let read_post_listings_no_person = PostQueryBuilder::create(&conn)
540       .listing_type(ListingType::Community)
541       .sort(SortType::New)
542       .community_id(inserted_community.id)
543       .list()
544       .unwrap();
545
546     let read_post_listing_no_person = PostView::read(&conn, inserted_post.id, None).unwrap();
547     let read_post_listing_with_person =
548       PostView::read(&conn, inserted_post.id, Some(inserted_person.id)).unwrap();
549
550     let agg = PostAggregates::read(&conn, inserted_post.id).unwrap();
551
552     // the non person version
553     let expected_post_listing_no_person = PostView {
554       post: Post {
555         id: inserted_post.id,
556         name: post_name,
557         creator_id: inserted_person.id,
558         url: None,
559         body: None,
560         published: inserted_post.published,
561         updated: None,
562         community_id: inserted_community.id,
563         removed: false,
564         deleted: false,
565         locked: false,
566         stickied: false,
567         nsfw: false,
568         embed_title: None,
569         embed_description: None,
570         embed_html: None,
571         thumbnail_url: None,
572         ap_id: inserted_post.ap_id.to_owned(),
573         local: true,
574       },
575       my_vote: None,
576       creator: PersonSafe {
577         id: inserted_person.id,
578         name: person_name,
579         display_name: None,
580         published: inserted_person.published,
581         avatar: None,
582         actor_id: inserted_person.actor_id.to_owned(),
583         local: true,
584         admin: false,
585         bot_account: false,
586         banned: false,
587         deleted: false,
588         bio: None,
589         banner: None,
590         updated: None,
591         inbox_url: inserted_person.inbox_url.to_owned(),
592         shared_inbox_url: None,
593         matrix_user_id: None,
594       },
595       creator_banned_from_community: false,
596       community: CommunitySafe {
597         id: inserted_community.id,
598         name: community_name,
599         icon: None,
600         removed: false,
601         deleted: false,
602         nsfw: false,
603         actor_id: inserted_community.actor_id.to_owned(),
604         local: true,
605         title: "nada".to_owned(),
606         description: None,
607         updated: None,
608         banner: None,
609         published: inserted_community.published,
610       },
611       counts: PostAggregates {
612         id: agg.id,
613         post_id: inserted_post.id,
614         comments: 0,
615         score: 1,
616         upvotes: 1,
617         downvotes: 0,
618         stickied: false,
619         published: agg.published,
620         newest_comment_time_necro: inserted_post.published,
621         newest_comment_time: inserted_post.published,
622       },
623       subscribed: false,
624       read: false,
625       saved: false,
626     };
627
628     // TODO More needs to be added here
629     let mut expected_post_listing_with_user = expected_post_listing_no_person.to_owned();
630     expected_post_listing_with_user.my_vote = Some(1);
631
632     let like_removed = PostLike::remove(&conn, inserted_person.id, inserted_post.id).unwrap();
633     let num_deleted = Post::delete(&conn, inserted_post.id).unwrap();
634     Community::delete(&conn, inserted_community.id).unwrap();
635     Person::delete(&conn, inserted_person.id).unwrap();
636     Person::delete(&conn, inserted_bot.id).unwrap();
637
638     // The with user
639     assert_eq!(
640       expected_post_listing_with_user,
641       read_post_listings_with_person[0]
642     );
643     assert_eq!(
644       expected_post_listing_with_user,
645       read_post_listing_with_person
646     );
647
648     // Should be only one person, IE the bot post should be missing
649     assert_eq!(1, read_post_listings_with_person.len());
650
651     // Without the user
652     assert_eq!(
653       expected_post_listing_no_person,
654       read_post_listings_no_person[1]
655     );
656     assert_eq!(expected_post_listing_no_person, read_post_listing_no_person);
657
658     // Should be 2 posts, with the bot post
659     assert_eq!(2, read_post_listings_no_person.len());
660
661     assert_eq!(expected_post_like, inserted_post_like);
662     assert_eq!(1, like_removed);
663     assert_eq!(1, num_deleted);
664   }
665 }