use actix_web::web::Data;
use lemmy_api_common::{
community::{AddModToCommunity, AddModToCommunityResponse},
- utils::{blocking, get_local_user_view_from_jwt, is_mod_or_admin},
-};
-use lemmy_apub::{
- objects::{community::ApubCommunity, person::ApubPerson},
- protocol::activities::community::{add_mod::AddMod, remove_mod::RemoveMod},
+ context::LemmyContext,
+ utils::{is_mod_or_admin, local_user_view_from_jwt},
};
use lemmy_db_schema::{
source::{
community::{Community, CommunityModerator, CommunityModeratorForm},
moderator::{ModAddCommunity, ModAddCommunityForm},
- person::Person,
},
traits::{Crud, Joinable},
};
use lemmy_db_views_actor::structs::CommunityModeratorView;
-use lemmy_utils::{error::LemmyError, ConnectionId};
-use lemmy_websocket::{messages::SendCommunityRoomMessage, LemmyContext, UserOperation};
+use lemmy_utils::error::{LemmyError, LemmyErrorExt, LemmyErrorType};
#[async_trait::async_trait(?Send)]
impl Perform for AddModToCommunity {
type Response = AddModToCommunityResponse;
- #[tracing::instrument(skip(context, websocket_id))]
+ #[tracing::instrument(skip(context))]
async fn perform(
&self,
context: &Data<LemmyContext>,
- websocket_id: Option<ConnectionId>,
) -> Result<AddModToCommunityResponse, LemmyError> {
let data: &AddModToCommunity = self;
- let local_user_view =
- get_local_user_view_from_jwt(&data.auth, context.pool(), context.secret()).await?;
+ let local_user_view = local_user_view_from_jwt(&data.auth, context).await?;
let community_id = data.community_id;
// Verify that only mods or admins can add mod
- is_mod_or_admin(context.pool(), local_user_view.person.id, community_id).await?;
- let community = blocking(context.pool(), move |conn| {
- Community::read(conn, community_id)
- })
- .await??;
+ is_mod_or_admin(&mut context.pool(), local_user_view.person.id, community_id).await?;
+ let community = Community::read(&mut context.pool(), community_id).await?;
if local_user_view.person.admin && !community.local {
- return Err(LemmyError::from_message("not_a_moderator"));
+ return Err(LemmyErrorType::NotAModerator)?;
}
// Update in local database
person_id: data.person_id,
};
if data.added {
- let join = move |conn: &'_ _| CommunityModerator::join(conn, &community_moderator_form);
- blocking(context.pool(), join)
- .await?
- .map_err(|e| LemmyError::from_error_message(e, "community_moderator_already_exists"))?;
+ CommunityModerator::join(&mut context.pool(), &community_moderator_form)
+ .await
+ .with_lemmy_type(LemmyErrorType::CommunityModeratorAlreadyExists)?;
} else {
- let leave = move |conn: &'_ _| CommunityModerator::leave(conn, &community_moderator_form);
- blocking(context.pool(), leave)
- .await?
- .map_err(|e| LemmyError::from_error_message(e, "community_moderator_already_exists"))?;
+ CommunityModerator::leave(&mut context.pool(), &community_moderator_form)
+ .await
+ .with_lemmy_type(LemmyErrorType::CommunityModeratorAlreadyExists)?;
}
// Mod tables
community_id: data.community_id,
removed: Some(!data.added),
};
- blocking(context.pool(), move |conn| {
- ModAddCommunity::create(conn, &form)
- })
- .await??;
- // Send to federated instances
- let updated_mod_id = data.person_id;
- let updated_mod: ApubPerson = blocking(context.pool(), move |conn| {
- Person::read(conn, updated_mod_id)
- })
- .await??
- .into();
- let community: ApubCommunity = community.into();
- if data.added {
- AddMod::send(
- &community,
- &updated_mod,
- &local_user_view.person.into(),
- context,
- )
- .await?;
- } else {
- RemoveMod::send(
- &community,
- &updated_mod,
- &local_user_view.person.into(),
- context,
- )
- .await?;
- }
+ ModAddCommunity::create(&mut context.pool(), &form).await?;
// Note: in case a remote mod is added, this returns the old moderators list, it will only get
// updated once we receive an activity from the community (like `Announce/Add/Moderator`)
let community_id = data.community_id;
- let moderators = blocking(context.pool(), move |conn| {
- CommunityModeratorView::for_community(conn, community_id)
- })
- .await??;
+ let moderators =
+ CommunityModeratorView::for_community(&mut context.pool(), community_id).await?;
- let res = AddModToCommunityResponse { moderators };
- context.chat_server().do_send(SendCommunityRoomMessage {
- op: UserOperation::AddModToCommunity,
- response: res.clone(),
- community_id,
- websocket_id,
- });
- Ok(res)
+ Ok(AddModToCommunityResponse { moderators })
}
}