use crate::PerformCrud;
use actix_web::web::Data;
use lemmy_api_common::{
- blocking,
- check_community_ban,
- check_person_block,
- comment::*,
- get_local_user_view_from_jwt,
- get_post,
- send_local_notifs,
+ comment::{CommentResponse, CreateComment},
+ utils::{
+ blocking,
+ check_community_ban,
+ check_community_deleted_or_removed,
+ check_post_deleted_or_removed,
+ get_local_user_view_from_jwt,
+ get_post,
+ },
};
use lemmy_apub::{
- activities::{
- comment::create_or_update::CreateOrUpdateComment,
- voting::vote::{Vote, VoteType},
- CreateOrUpdateType,
- },
- generate_apub_endpoint,
+ generate_local_apub_endpoint,
+ objects::comment::ApubComment,
+ protocol::activities::{create_or_update::comment::CreateOrUpdateComment, CreateOrUpdateType},
EndpointType,
- PostOrComment,
};
-use lemmy_db_queries::{source::comment::Comment_, Crud, Likeable};
-use lemmy_db_schema::source::comment::*;
+use lemmy_db_schema::{
+ source::{
+ comment::{Comment, CommentForm, CommentLike, CommentLikeForm},
+ comment_reply::CommentReply,
+ person_mention::PersonMention,
+ },
+ traits::{Crud, Likeable},
+};
use lemmy_utils::{
+ error::LemmyError,
utils::{remove_slurs, scrape_text_for_mentions},
- ApiError,
ConnectionId,
- LemmyError,
};
-use lemmy_websocket::{send::send_comment_ws_message, LemmyContext, UserOperationCrud};
+use lemmy_websocket::{
+ send::{send_comment_ws_message, send_local_notifs},
+ LemmyContext,
+ UserOperationCrud,
+};
#[async_trait::async_trait(?Send)]
impl PerformCrud for CreateComment {
type Response = CommentResponse;
+ #[tracing::instrument(skip(context, websocket_id))]
async fn perform(
&self,
context: &Data<LemmyContext>,
websocket_id: Option<ConnectionId>,
) -> Result<CommentResponse, LemmyError> {
let data: &CreateComment = self;
- let local_user_view = get_local_user_view_from_jwt(&data.auth, context.pool()).await?;
+ let local_user_view =
+ get_local_user_view_from_jwt(&data.auth, context.pool(), context.secret()).await?;
- let content_slurs_removed = remove_slurs(&data.content.to_owned());
+ let content_slurs_removed =
+ remove_slurs(&data.content.to_owned(), &context.settings().slur_regex());
// Check for a community ban
let post_id = data.post_id;
let community_id = post.community_id;
check_community_ban(local_user_view.person.id, community_id, context.pool()).await?;
-
- check_person_block(local_user_view.person.id, post.creator_id, context.pool()).await?;
+ check_community_deleted_or_removed(community_id, context.pool()).await?;
+ check_post_deleted_or_removed(&post)?;
// Check if post is locked, no new comments
if post.locked {
- return Err(ApiError::err("locked").into());
+ return Err(LemmyError::from_message("locked"));
}
- // If there's a parent_id, check to make sure that comment is in that post
- if let Some(parent_id) = data.parent_id {
- // Make sure the parent comment exists
- let parent = blocking(context.pool(), move |conn| Comment::read(conn, parent_id))
+ // Fetch the parent, if it exists
+ let parent_opt = if let Some(parent_id) = data.parent_id {
+ blocking(context.pool(), move |conn| Comment::read(conn, parent_id))
.await?
- .map_err(|_| ApiError::err("couldnt_create_comment"))?;
-
- check_person_block(local_user_view.person.id, parent.creator_id, context.pool()).await?;
+ .ok()
+ } else {
+ None
+ };
- // Strange issue where sometimes the post ID is incorrect
+ // If there's a parent_id, check to make sure that comment is in that post
+ // Strange issue where sometimes the post ID of the parent comment is incorrect
+ if let Some(parent) = parent_opt.as_ref() {
if parent.post_id != post_id {
- return Err(ApiError::err("couldnt_create_comment").into());
+ return Err(LemmyError::from_message("couldnt_create_comment"));
}
}
+ // if no language is set, copy language from parent post/comment
+ let parent_language = parent_opt
+ .as_ref()
+ .map(|p| p.language_id)
+ .unwrap_or(post.language_id);
+ let language_id = Some(data.language_id.unwrap_or(parent_language));
+
let comment_form = CommentForm {
content: content_slurs_removed,
- parent_id: data.parent_id.to_owned(),
post_id: data.post_id,
creator_id: local_user_view.person.id,
+ language_id,
..CommentForm::default()
};
// Create the comment
let comment_form2 = comment_form.clone();
+ let parent_path = parent_opt.to_owned().map(|t| t.path);
let inserted_comment = blocking(context.pool(), move |conn| {
- Comment::create(conn, &comment_form2)
+ Comment::create(conn, &comment_form2, parent_path.as_ref())
})
.await?
- .map_err(|_| ApiError::err("couldnt_create_comment"))?;
+ .map_err(|e| LemmyError::from_error_message(e, "couldnt_create_comment"))?;
// Necessary to update the ap_id
let inserted_comment_id = inserted_comment.id;
+ let protocol_and_hostname = context.settings().get_protocol_and_hostname();
+
let updated_comment: Comment =
blocking(context.pool(), move |conn| -> Result<Comment, LemmyError> {
- let apub_id =
- generate_apub_endpoint(EndpointType::Comment, &inserted_comment_id.to_string())?;
+ let apub_id = generate_local_apub_endpoint(
+ EndpointType::Comment,
+ &inserted_comment_id.to_string(),
+ &protocol_and_hostname,
+ )?;
Ok(Comment::update_ap_id(conn, inserted_comment_id, apub_id)?)
})
.await?
- .map_err(|_| ApiError::err("couldnt_create_comment"))?;
-
- CreateOrUpdateComment::send(
- &updated_comment,
- &local_user_view.person,
- CreateOrUpdateType::Create,
- context,
- )
- .await?;
+ .map_err(|e| e.with_message("couldnt_create_comment"))?;
// Scan the comment for user mentions, add those rows
let post_id = post.id;
let mentions = scrape_text_for_mentions(&comment_form.content);
let recipient_ids = send_local_notifs(
mentions,
- updated_comment.clone(),
- local_user_view.person.clone(),
- post,
- context.pool(),
+ &updated_comment,
+ &local_user_view.person,
+ &post,
true,
+ context,
)
.await?;
score: 1,
};
- let like = move |conn: &'_ _| CommentLike::like(conn, &like_form);
- if blocking(context.pool(), like).await?.is_err() {
- return Err(ApiError::err("couldnt_like_comment").into());
- }
+ let like = move |conn: &mut _| CommentLike::like(conn, &like_form);
+ blocking(context.pool(), like)
+ .await?
+ .map_err(|e| LemmyError::from_error_message(e, "couldnt_like_comment"))?;
- let object = PostOrComment::Comment(Box::new(updated_comment));
- Vote::send(
- &object,
- &local_user_view.person,
- community_id,
- VoteType::Like,
+ let apub_comment: ApubComment = updated_comment.into();
+ CreateOrUpdateComment::send(
+ apub_comment.clone(),
+ &local_user_view.person.clone().into(),
+ CreateOrUpdateType::Create,
context,
+ &mut 0,
)
.await?;
- // If its a comment to yourself, mark it as read
- if local_user_view.person.id == inserted_comment.creator_id {
- let comment_id = inserted_comment.id;
- blocking(context.pool(), move |conn| {
- Comment::update_read(conn, comment_id, true)
+ // If its a reply, mark the parent as read
+ if let Some(parent) = parent_opt {
+ let parent_id = parent.id;
+ let comment_reply = blocking(context.pool(), move |conn| {
+ CommentReply::read_by_comment(conn, parent_id)
})
- .await?
- .map_err(|_| ApiError::err("couldnt_update_comment"))?;
+ .await?;
+ if let Ok(reply) = comment_reply {
+ blocking(context.pool(), move |conn| {
+ CommentReply::update_read(conn, reply.id, true)
+ })
+ .await?
+ .map_err(|e| LemmyError::from_error_message(e, "couldnt_update_replies"))?;
+ }
+
+ // If the parent has PersonMentions mark them as read too
+ let person_id = local_user_view.person.id;
+ let person_mention = blocking(context.pool(), move |conn| {
+ PersonMention::read_by_comment_and_person(conn, parent_id, person_id)
+ })
+ .await?;
+ if let Ok(mention) = person_mention {
+ blocking(context.pool(), move |conn| {
+ PersonMention::update_read(conn, mention.id, true)
+ })
+ .await?
+ .map_err(|e| LemmyError::from_error_message(e, "couldnt_update_person_mentions"))?;
+ }
}
send_comment_ws_message(
projects / lemmy.git / blobdiff