Automatically resolve report when post/comment is removed (#3850)

[lemmy.git] / crates / api_crud / src / comment / remove.rs

diff --git a/crates/api_crud/src/comment/remove.rs b/crates/api_crud/src/comment/remove.rs
index b8834df8d69ac4dbde26deec96b351acf1bc5533..c18a8c5b7486f24ce217435cbf8cc732781c5941 100644 (file)
--- a/crates/api_crud/src/comment/remove.rs
+++ b/crates/api_crud/src/comment/remove.rs
@@ -1,95 +1,105 @@
-use crate::PerformCrud;
-use actix_web::web::Data;
+use activitypub_federation::config::Data;
+use actix_web::web::Json;
 use lemmy_api_common::{
+  build_response::{build_comment_response, send_local_notifs},
   comment::{CommentResponse, RemoveComment},
   context::LemmyContext,
+  send_activity::{ActivityChannel, SendActivityData},
   utils::{check_community_ban, is_mod_or_admin, local_user_view_from_jwt},
-  websocket::UserOperationCrud,
 };
 use lemmy_db_schema::{
   source::{
     comment::{Comment, CommentUpdateForm},
+    comment_report::CommentReport,
     moderator::{ModRemoveComment, ModRemoveCommentForm},
     post::Post,
   },
-  traits::Crud,
+  traits::{Crud, Reportable},
 };
 use lemmy_db_views::structs::CommentView;
-use lemmy_utils::{error::LemmyError, ConnectionId};
+use lemmy_utils::error::{LemmyError, LemmyErrorExt, LemmyErrorType};
 
-#[async_trait::async_trait(?Send)]
-impl PerformCrud for RemoveComment {
-  type Response = CommentResponse;
+#[tracing::instrument(skip(context))]
+pub async fn remove_comment(
+  data: Json<RemoveComment>,
+  context: Data<LemmyContext>,
+) -> Result<Json<CommentResponse>, LemmyError> {
+  let local_user_view = local_user_view_from_jwt(&data.auth, &context).await?;
 
-  #[tracing::instrument(skip(context, websocket_id))]
-  async fn perform(
-    &self,
-    context: &Data<LemmyContext>,
-    websocket_id: Option<ConnectionId>,
-  ) -> Result<CommentResponse, LemmyError> {
-    let data: &RemoveComment = self;
-    let local_user_view = local_user_view_from_jwt(&data.auth, context).await?;
+  let comment_id = data.comment_id;
+  let orig_comment = CommentView::read(&mut context.pool(), comment_id, None).await?;
 
-    let comment_id = data.comment_id;
-    let orig_comment = CommentView::read(context.pool(), comment_id, None).await?;
+  check_community_ban(
+    local_user_view.person.id,
+    orig_comment.community.id,
+    &mut context.pool(),
+  )
+  .await?;
 
-    check_community_ban(
-      local_user_view.person.id,
-      orig_comment.community.id,
-      context.pool(),
-    )
-    .await?;
+  // Verify that only a mod or admin can remove
+  is_mod_or_admin(
+    &mut context.pool(),
+    local_user_view.person.id,
+    orig_comment.community.id,
+  )
+  .await?;
 
-    // Verify that only a mod or admin can remove
-    is_mod_or_admin(
-      context.pool(),
-      local_user_view.person.id,
-      orig_comment.community.id,
-    )
-    .await?;
+  // Do the remove
+  let removed = data.removed;
+  let updated_comment = Comment::update(
+    &mut context.pool(),
+    comment_id,
+    &CommentUpdateForm {
+      removed: Some(removed),
+      ..Default::default()
+    },
+  )
+  .await
+  .with_lemmy_type(LemmyErrorType::CouldntUpdateComment)?;
 
-    // Do the remove
-    let removed = data.removed;
-    let updated_comment = Comment::update(
-      context.pool(),
-      comment_id,
-      &CommentUpdateForm::builder().removed(Some(removed)).build(),
-    )
-    .await
-    .map_err(|e| LemmyError::from_error_message(e, "couldnt_update_comment"))?;
+  CommentReport::resolve_all_for_object(&mut context.pool(), comment_id, local_user_view.person.id)
+    .await?;
 
-    // Mod tables
-    let form = ModRemoveCommentForm {
-      mod_person_id: local_user_view.person.id,
-      comment_id: data.comment_id,
-      removed: Some(removed),
-      reason: data.reason.clone(),
-    };
-    ModRemoveComment::create(context.pool(), &form).await?;
+  // Mod tables
+  let form = ModRemoveCommentForm {
+    mod_person_id: local_user_view.person.id,
+    comment_id: data.comment_id,
+    removed: Some(removed),
+    reason: data.reason.clone(),
+  };
+  ModRemoveComment::create(&mut context.pool(), &form).await?;
 
-    let post_id = updated_comment.post_id;
-    let post = Post::read(context.pool(), post_id).await?;
-    let recipient_ids = context
-      .send_local_notifs(
-        vec![],
-        &updated_comment,
-        &local_user_view.person.clone(),
-        &post,
-        false,
-      )
-      .await?;
+  let post_id = updated_comment.post_id;
+  let post = Post::read(&mut context.pool(), post_id).await?;
+  let recipient_ids = send_local_notifs(
+    vec![],
+    &updated_comment,
+    &local_user_view.person.clone(),
+    &post,
+    false,
+    &context,
+  )
+  .await?;
+  let updated_comment_id = updated_comment.id;
 
-    let res = context
-      .send_comment_ws_message(
-        &UserOperationCrud::RemoveComment,
-        data.comment_id,
-        websocket_id,
-        None, // TODO maybe this might clear other forms
-        Some(local_user_view.person.id),
-        recipient_ids,
-      )
-      .await?;
+  ActivityChannel::submit_activity(
+    SendActivityData::RemoveComment(
+      updated_comment,
+      local_user_view.person.clone(),
+      orig_comment.community,
+      data.reason.clone(),
+    ),
+    &context,
+  )
+  .await?;
 
-    Ok(res)
-  }
+  Ok(Json(
+    build_comment_response(
+      &context,
+      updated_comment_id,
+      Some(local_user_view),
+      recipient_ids,
+    )
+    .await?,
+  ))
 }