]> Untitled Git - lemmy.git/blobdiff - crates/api_crud/src/post/read.rs
Make functions work with both connection and pool (#3420)
[lemmy.git] / crates / api_crud / src / post / read.rs
index a5ca262fa9eb0860d17fc47ef8199618dd439844..af19402ee3e0c82bbb18daeab573237d214f401d 100644 (file)
 use crate::PerformCrud;
 use actix_web::web::Data;
 use lemmy_api_common::{
+  context::LemmyContext,
   post::{GetPost, GetPostResponse},
-  utils::{blocking, check_private_instance, get_local_user_view_from_jwt_opt, mark_post_as_read},
+  utils::{
+    check_private_instance,
+    is_mod_or_admin_opt,
+    local_user_view_from_jwt_opt,
+    mark_post_as_read,
+  },
 };
-use lemmy_db_schema::traits::DeleteableOrRemoveable;
-use lemmy_db_views::{comment_view::CommentQueryBuilder, structs::PostView};
+use lemmy_db_schema::{
+  aggregates::structs::{PersonPostAggregates, PersonPostAggregatesForm},
+  source::{comment::Comment, local_site::LocalSite, post::Post},
+  traits::Crud,
+};
+use lemmy_db_views::{post_view::PostQuery, structs::PostView};
 use lemmy_db_views_actor::structs::{CommunityModeratorView, CommunityView};
-use lemmy_utils::{ConnectionId, LemmyError};
-use lemmy_websocket::{messages::GetPostUsersOnline, LemmyContext};
+use lemmy_utils::error::{LemmyError, LemmyErrorExt, LemmyErrorType};
 
 #[async_trait::async_trait(?Send)]
 impl PerformCrud for GetPost {
   type Response = GetPostResponse;
 
-  #[tracing::instrument(skip(context, _websocket_id))]
-  async fn perform(
-    &self,
-    context: &Data<LemmyContext>,
-    _websocket_id: Option<ConnectionId>,
-  ) -> Result<GetPostResponse, LemmyError> {
+  #[tracing::instrument(skip(context))]
+  async fn perform(&self, context: &Data<LemmyContext>) -> Result<GetPostResponse, LemmyError> {
     let data: &GetPost = self;
-    let local_user_view =
-      get_local_user_view_from_jwt_opt(data.auth.as_ref(), context.pool(), context.secret())
-        .await?;
+    let local_user_view = local_user_view_from_jwt_opt(data.auth.as_ref(), context).await;
+    let local_site = LocalSite::read(&mut context.pool()).await?;
 
-    check_private_instance(&local_user_view, context.pool()).await?;
+    check_private_instance(&local_user_view, &local_site)?;
 
-    let show_bot_accounts = local_user_view
-      .as_ref()
-      .map(|t| t.local_user.show_bot_accounts);
-    let person_id = local_user_view.map(|u| u.person.id);
+    let person_id = local_user_view.as_ref().map(|u| u.person.id);
 
-    let id = data.id;
-    let mut post_view = blocking(context.pool(), move |conn| {
-      PostView::read(conn, id, person_id)
-    })
-    .await?
-    .map_err(|e| LemmyError::from_error_message(e, "couldnt_find_post"))?;
+    // I'd prefer fetching the post_view by a comment join, but it adds a lot of boilerplate
+    let post_id = if let Some(id) = data.id {
+      id
+    } else if let Some(comment_id) = data.comment_id {
+      Comment::read(&mut context.pool(), comment_id)
+        .await
+        .with_lemmy_type(LemmyErrorType::CouldntFindPost)?
+        .post_id
+    } else {
+      Err(LemmyErrorType::CouldntFindPost)?
+    };
+
+    // Check to see if the person is a mod or admin, to show deleted / removed
+    let community_id = Post::read(&mut context.pool(), post_id).await?.community_id;
+    let is_mod_or_admin = is_mod_or_admin_opt(
+      &mut context.pool(),
+      local_user_view.as_ref(),
+      Some(community_id),
+    )
+    .await
+    .is_ok();
+
+    let post_view = PostView::read(
+      &mut context.pool(),
+      post_id,
+      person_id,
+      Some(is_mod_or_admin),
+    )
+    .await
+    .with_lemmy_type(LemmyErrorType::CouldntFindPost)?;
 
     // Mark the post as read
+    let post_id = post_view.post.id;
     if let Some(person_id) = person_id {
-      mark_post_as_read(person_id, id, context.pool()).await?;
+      mark_post_as_read(person_id, post_id, &mut context.pool()).await?;
     }
 
-    let id = data.id;
-    let mut comments = blocking(context.pool(), move |conn| {
-      CommentQueryBuilder::create(conn)
-        .my_person_id(person_id)
-        .show_bot_accounts(show_bot_accounts)
-        .post_id(id)
-        .limit(9999)
-        .list()
-    })
-    .await??;
+    // Necessary for the sidebar subscribed
+    let community_view = CommunityView::read(
+      &mut context.pool(),
+      community_id,
+      person_id,
+      Some(is_mod_or_admin),
+    )
+    .await
+    .with_lemmy_type(LemmyErrorType::CouldntFindCommunity)?;
 
-    // Necessary for the sidebar
-    let community_id = post_view.community.id;
-    let mut community_view = blocking(context.pool(), move |conn| {
-      CommunityView::read(conn, community_id, person_id)
-    })
-    .await?
-    .map_err(|e| LemmyError::from_error_message(e, "couldnt_find_community"))?;
-
-    // Blank out deleted or removed info for non-logged in users
-    if person_id.is_none() {
-      if post_view.post.deleted || post_view.post.removed {
-        post_view.post = post_view.post.blank_out_deleted_or_removed_info();
-      }
-
-      for cv in comments
-        .iter_mut()
-        .filter(|cv| cv.comment.deleted || cv.comment.removed)
-      {
-        cv.comment = cv.to_owned().comment.blank_out_deleted_or_removed_info();
-      }
-      if community_view.community.deleted || community_view.community.removed {
-        community_view.community = community_view.community.blank_out_deleted_or_removed_info();
-      }
+    // Insert into PersonPostAggregates
+    // to update the read_comments count
+    if let Some(person_id) = person_id {
+      let read_comments = post_view.counts.comments;
+      let person_post_agg_form = PersonPostAggregatesForm {
+        person_id,
+        post_id,
+        read_comments,
+        ..PersonPostAggregatesForm::default()
+      };
+      PersonPostAggregates::upsert(&mut context.pool(), &person_post_agg_form)
+        .await
+        .with_lemmy_type(LemmyErrorType::CouldntFindPost)?;
     }
 
-    let moderators = blocking(context.pool(), move |conn| {
-      CommunityModeratorView::for_community(conn, community_id)
-    })
-    .await??;
+    let moderators =
+      CommunityModeratorView::for_community(&mut context.pool(), community_id).await?;
+
+    // Fetch the cross_posts
+    let cross_posts = if let Some(url) = &post_view.post.url {
+      let mut x_posts = PostQuery::builder()
+        .pool(&mut context.pool())
+        .url_search(Some(url.inner().as_str().into()))
+        .build()
+        .list()
+        .await?;
 
-    let online = context
-      .chat_server()
-      .send(GetPostUsersOnline { post_id: data.id })
-      .await
-      .unwrap_or(1);
+      // Don't return this post as one of the cross_posts
+      x_posts.retain(|x| x.post.id != post_id);
+      x_posts
+    } else {
+      Vec::new()
+    };
 
     // Return the jwt
     Ok(GetPostResponse {
       post_view,
       community_view,
-      comments,
       moderators,
-      online,
+      cross_posts,
     })
   }
 }