]> Untitled Git - lemmy.git/blobdiff - crates/api_crud/src/post/read.rs
Replace Option<bool> with bool for PostQuery and CommentQuery (#3819) (#3857)
[lemmy.git] / crates / api_crud / src / post / read.rs
index af19402ee3e0c82bbb18daeab573237d214f401d..d37b1a5825819cb875325cbb9b6660fab312d72e 100644 (file)
@@ -1,5 +1,4 @@
-use crate::PerformCrud;
-use actix_web::web::Data;
+use actix_web::web::{Data, Json, Query};
 use lemmy_api_common::{
   context::LemmyContext,
   post::{GetPost, GetPostResponse},
@@ -19,107 +18,98 @@ use lemmy_db_views::{post_view::PostQuery, structs::PostView};
 use lemmy_db_views_actor::structs::{CommunityModeratorView, CommunityView};
 use lemmy_utils::error::{LemmyError, LemmyErrorExt, LemmyErrorType};
 
-#[async_trait::async_trait(?Send)]
-impl PerformCrud for GetPost {
-  type Response = GetPostResponse;
+#[tracing::instrument(skip(context))]
+pub async fn get_post(
+  data: Query<GetPost>,
+  context: Data<LemmyContext>,
+) -> Result<Json<GetPostResponse>, LemmyError> {
+  let local_user_view = local_user_view_from_jwt_opt(data.auth.as_ref(), &context).await;
+  let local_site = LocalSite::read(&mut context.pool()).await?;
 
-  #[tracing::instrument(skip(context))]
-  async fn perform(&self, context: &Data<LemmyContext>) -> Result<GetPostResponse, LemmyError> {
-    let data: &GetPost = self;
-    let local_user_view = local_user_view_from_jwt_opt(data.auth.as_ref(), context).await;
-    let local_site = LocalSite::read(&mut context.pool()).await?;
+  check_private_instance(&local_user_view, &local_site)?;
 
-    check_private_instance(&local_user_view, &local_site)?;
+  let person_id = local_user_view.as_ref().map(|u| u.person.id);
 
-    let person_id = local_user_view.as_ref().map(|u| u.person.id);
+  // I'd prefer fetching the post_view by a comment join, but it adds a lot of boilerplate
+  let post_id = if let Some(id) = data.id {
+    id
+  } else if let Some(comment_id) = data.comment_id {
+    Comment::read(&mut context.pool(), comment_id)
+      .await
+      .with_lemmy_type(LemmyErrorType::CouldntFindPost)?
+      .post_id
+  } else {
+    Err(LemmyErrorType::CouldntFindPost)?
+  };
 
-    // I'd prefer fetching the post_view by a comment join, but it adds a lot of boilerplate
-    let post_id = if let Some(id) = data.id {
-      id
-    } else if let Some(comment_id) = data.comment_id {
-      Comment::read(&mut context.pool(), comment_id)
-        .await
-        .with_lemmy_type(LemmyErrorType::CouldntFindPost)?
-        .post_id
-    } else {
-      Err(LemmyErrorType::CouldntFindPost)?
-    };
-
-    // Check to see if the person is a mod or admin, to show deleted / removed
-    let community_id = Post::read(&mut context.pool(), post_id).await?.community_id;
-    let is_mod_or_admin = is_mod_or_admin_opt(
-      &mut context.pool(),
-      local_user_view.as_ref(),
-      Some(community_id),
-    )
-    .await
-    .is_ok();
+  // Check to see if the person is a mod or admin, to show deleted / removed
+  let community_id = Post::read(&mut context.pool(), post_id).await?.community_id;
+  let is_mod_or_admin = is_mod_or_admin_opt(
+    &mut context.pool(),
+    local_user_view.as_ref(),
+    Some(community_id),
+  )
+  .await
+  .is_ok();
 
-    let post_view = PostView::read(
-      &mut context.pool(),
-      post_id,
-      person_id,
-      Some(is_mod_or_admin),
-    )
+  let post_view = PostView::read(&mut context.pool(), post_id, person_id, is_mod_or_admin)
     .await
     .with_lemmy_type(LemmyErrorType::CouldntFindPost)?;
 
-    // Mark the post as read
-    let post_id = post_view.post.id;
-    if let Some(person_id) = person_id {
-      mark_post_as_read(person_id, post_id, &mut context.pool()).await?;
-    }
+  // Mark the post as read
+  let post_id = post_view.post.id;
+  if let Some(person_id) = person_id {
+    mark_post_as_read(person_id, post_id, &mut context.pool()).await?;
+  }
 
-    // Necessary for the sidebar subscribed
-    let community_view = CommunityView::read(
-      &mut context.pool(),
-      community_id,
-      person_id,
-      Some(is_mod_or_admin),
-    )
-    .await
-    .with_lemmy_type(LemmyErrorType::CouldntFindCommunity)?;
+  // Necessary for the sidebar subscribed
+  let community_view = CommunityView::read(
+    &mut context.pool(),
+    community_id,
+    person_id,
+    is_mod_or_admin,
+  )
+  .await
+  .with_lemmy_type(LemmyErrorType::CouldntFindCommunity)?;
 
-    // Insert into PersonPostAggregates
-    // to update the read_comments count
-    if let Some(person_id) = person_id {
-      let read_comments = post_view.counts.comments;
-      let person_post_agg_form = PersonPostAggregatesForm {
-        person_id,
-        post_id,
-        read_comments,
-        ..PersonPostAggregatesForm::default()
-      };
-      PersonPostAggregates::upsert(&mut context.pool(), &person_post_agg_form)
-        .await
-        .with_lemmy_type(LemmyErrorType::CouldntFindPost)?;
-    }
+  // Insert into PersonPostAggregates
+  // to update the read_comments count
+  if let Some(person_id) = person_id {
+    let read_comments = post_view.counts.comments;
+    let person_post_agg_form = PersonPostAggregatesForm {
+      person_id,
+      post_id,
+      read_comments,
+      ..PersonPostAggregatesForm::default()
+    };
+    PersonPostAggregates::upsert(&mut context.pool(), &person_post_agg_form)
+      .await
+      .with_lemmy_type(LemmyErrorType::CouldntFindPost)?;
+  }
 
-    let moderators =
-      CommunityModeratorView::for_community(&mut context.pool(), community_id).await?;
+  let moderators = CommunityModeratorView::for_community(&mut context.pool(), community_id).await?;
 
-    // Fetch the cross_posts
-    let cross_posts = if let Some(url) = &post_view.post.url {
-      let mut x_posts = PostQuery::builder()
-        .pool(&mut context.pool())
-        .url_search(Some(url.inner().as_str().into()))
-        .build()
-        .list()
-        .await?;
+  // Fetch the cross_posts
+  let cross_posts = if let Some(url) = &post_view.post.url {
+    let mut x_posts = PostQuery {
+      url_search: Some(url.inner().as_str().into()),
+      ..Default::default()
+    }
+    .list(&mut context.pool())
+    .await?;
 
-      // Don't return this post as one of the cross_posts
-      x_posts.retain(|x| x.post.id != post_id);
-      x_posts
-    } else {
-      Vec::new()
-    };
+    // Don't return this post as one of the cross_posts
+    x_posts.retain(|x| x.post.id != post_id);
+    x_posts
+  } else {
+    Vec::new()
+  };
 
-    // Return the jwt
-    Ok(GetPostResponse {
-      post_view,
-      community_view,
-      moderators,
-      cross_posts,
-    })
-  }
+  // Return the jwt
+  Ok(Json(GetPostResponse {
+    post_view,
+    community_view,
+    moderators,
+    cross_posts,
+  }))
 }