-use activitystreams::{activity::kind::UpdateType, public, unparsed::Unparsed};
-use serde::{Deserialize, Serialize};
-use url::Url;
-
-use lemmy_api_common::blocking;
-use lemmy_apub_lib::{
- data::Data,
- traits::{ActivityFields, ActivityHandler, ActorType, ApubObject},
-};
-use lemmy_db_schema::{
- source::community::{Community, CommunityForm},
- traits::Crud,
-};
-use lemmy_utils::LemmyError;
-use lemmy_websocket::{send::send_community_ws_message, LemmyContext, UserOperationCrud};
-
use crate::{
activities::{
- community::{
- announce::{AnnouncableActivities, GetCommunity},
- send_to_community,
- },
+ community::{announce::GetCommunity, send_activity_in_community},
generate_activity_id,
- verify_activity,
verify_is_public,
verify_mod_action,
verify_person_in_community,
},
- fetcher::object_id::ObjectId,
+ activity_lists::AnnouncableActivities,
+ check_apub_id_valid,
+ fetch_local_site_data,
+ local_instance,
objects::{community::ApubCommunity, person::ApubPerson},
- protocol::objects::group::Group,
+ protocol::activities::community::update::UpdateCommunity,
+ ActorType,
};
-
-/// This activity is received from a remote community mod, and updates the description or other
-/// fields of a local community.
-#[derive(Clone, Debug, Deserialize, Serialize, ActivityFields)]
-#[serde(rename_all = "camelCase")]
-pub struct UpdateCommunity {
- actor: ObjectId<ApubPerson>,
- to: Vec<Url>,
- // TODO: would be nice to use a separate struct here, which only contains the fields updated here
- object: Group,
- cc: Vec<Url>,
- #[serde(rename = "type")]
- kind: UpdateType,
- id: Url,
- #[serde(flatten)]
- unparsed: Unparsed,
-}
+use activitypub_federation::{
+ core::object_id::ObjectId,
+ data::Data,
+ traits::{ActivityHandler, ApubObject},
+};
+use activitystreams_kinds::{activity::UpdateType, public};
+use lemmy_api_common::utils::blocking;
+use lemmy_db_schema::{source::community::Community, traits::Crud};
+use lemmy_utils::error::LemmyError;
+use lemmy_websocket::{send::send_community_ws_message, LemmyContext, UserOperationCrud};
+use url::Url;
impl UpdateCommunity {
+ #[tracing::instrument(skip_all)]
pub async fn send(
- community: &ApubCommunity,
+ community: ApubCommunity,
actor: &ApubPerson,
context: &LemmyContext,
) -> Result<(), LemmyError> {
let update = UpdateCommunity {
actor: ObjectId::new(actor.actor_id()),
to: vec![public()],
- object: community.to_apub(context).await?,
+ object: Box::new(community.clone().into_apub(context).await?),
cc: vec![community.actor_id()],
kind: UpdateType::Update,
id: id.clone(),
unparsed: Default::default(),
};
- let activity = AnnouncableActivities::UpdateCommunity(Box::new(update));
- send_to_community(activity, &id, actor, community, vec![], context).await
+ let activity = AnnouncableActivities::UpdateCommunity(update);
+ send_activity_in_community(activity, actor, &community, vec![], context).await
}
}
#[async_trait::async_trait(?Send)]
impl ActivityHandler for UpdateCommunity {
type DataType = LemmyContext;
+ type Error = LemmyError;
+
+ fn id(&self) -> &Url {
+ &self.id
+ }
+
+ fn actor(&self) -> &Url {
+ self.actor.inner()
+ }
+
+ #[tracing::instrument(skip_all)]
async fn verify(
&self,
context: &Data<LemmyContext>,
request_counter: &mut i32,
) -> Result<(), LemmyError> {
- verify_is_public(&self.to)?;
- verify_activity(self, &context.settings())?;
+ let local_site_data = blocking(context.pool(), fetch_local_site_data).await??;
+ check_apub_id_valid(self.id(), &local_site_data, context.settings())
+ .map_err(LemmyError::from_message)?;
+ verify_is_public(&self.to, &self.cc)?;
let community = self.get_community(context, request_counter).await?;
verify_person_in_community(&self.actor, &community, context, request_counter).await?;
- verify_mod_action(&self.actor, &community, context, request_counter).await?;
+ verify_mod_action(
+ &self.actor,
+ self.object.id.inner(),
+ community.id,
+ context,
+ request_counter,
+ )
+ .await?;
+ ApubCommunity::verify(
+ &self.object,
+ &community.actor_id.clone().into(),
+ context,
+ request_counter,
+ )
+ .await?;
Ok(())
}
+ #[tracing::instrument(skip_all)]
async fn receive(
self,
context: &Data<LemmyContext>,
) -> Result<(), LemmyError> {
let community = self.get_community(context, request_counter).await?;
- let updated_community = Group::from_apub_to_form(
- &self.object,
- &community.actor_id.clone().into(),
- &context.settings(),
- )
- .await?;
- let cf = CommunityForm {
- name: updated_community.name,
- title: updated_community.title,
- description: updated_community.description,
- nsfw: updated_community.nsfw,
- // TODO: icon and banner would be hosted on the other instance, ideally we would copy it to ours
- icon: updated_community.icon,
- banner: updated_community.banner,
- ..CommunityForm::default()
- };
+ let community_update_form = self.object.into_update_form();
+
let updated_community = blocking(context.pool(), move |conn| {
- Community::update(conn, community.id, &cf)
+ Community::update(conn, community.id, &community_update_form)
})
.await??;
#[async_trait::async_trait(?Send)]
impl GetCommunity for UpdateCommunity {
+ #[tracing::instrument(skip_all)]
async fn get_community(
&self,
context: &LemmyContext,
request_counter: &mut i32,
) -> Result<ApubCommunity, LemmyError> {
let cid = ObjectId::new(self.object.id.clone());
- cid.dereference(context, request_counter).await
+ cid
+ .dereference(context, local_instance(context), request_counter)
+ .await
}
}
projects / lemmy.git / blobdiff