Implement federated user following (fixes #752) (#2577)

[lemmy.git] / crates / apub / src / activities / following / accept.rs

diff --git a/crates/apub/src/activities/following/accept.rs b/crates/apub/src/activities/following/accept.rs
index 6bd5d272f7f4d8420c8929a46975e3149ca9e9ff..5a8baa4c7b5525a0b7d83d1390cee4a3e7c9eff5 100644 (file)
--- a/crates/apub/src/activities/following/accept.rs
+++ b/crates/apub/src/activities/following/accept.rs
@@ -1,61 +1,115 @@
 use crate::{
-  activities::{following::follow::FollowCommunity, verify_activity, verify_community},
-  fetcher::{community::get_or_fetch_and_upsert_community, person::get_or_fetch_and_upsert_person},
+  activities::{generate_activity_id, send_lemmy_activity},
+  local_instance,
+  protocol::activities::following::{accept::AcceptFollow, follow::Follow},
+  ActorType,
 };
-use activitystreams::activity::kind::AcceptType;
-use lemmy_api_common::blocking;
-use lemmy_apub_lib::{verify_urls_match, ActivityCommonFields, ActivityHandler};
-use lemmy_db_queries::Followable;
-use lemmy_db_schema::source::community::CommunityFollower;
-use lemmy_utils::LemmyError;
-use lemmy_websocket::LemmyContext;
+use activitypub_federation::{
+  core::object_id::ObjectId,
+  data::Data,
+  traits::{ActivityHandler, Actor},
+  utils::verify_urls_match,
+};
+use activitystreams_kinds::activity::AcceptType;
+use lemmy_api_common::community::CommunityResponse;
+use lemmy_db_schema::{source::community::CommunityFollower, traits::Followable};
+use lemmy_db_views::structs::LocalUserView;
+use lemmy_db_views_actor::structs::CommunityView;
+use lemmy_utils::error::LemmyError;
+use lemmy_websocket::{messages::SendUserRoomMessage, LemmyContext, UserOperation};
 use url::Url;
 
-#[derive(Clone, Debug, serde::Deserialize, serde::Serialize)]
-#[serde(rename_all = "camelCase")]
-pub struct AcceptFollowCommunity {
-  to: Url,
-  object: FollowCommunity,
-  #[serde(rename = "type")]
-  kind: AcceptType,
-  #[serde(flatten)]
-  common: ActivityCommonFields,
+impl AcceptFollow {
+  #[tracing::instrument(skip_all)]
+  pub async fn send(
+    follow: Follow,
+    context: &LemmyContext,
+    request_counter: &mut i32,
+  ) -> Result<(), LemmyError> {
+    let user_or_community = follow.object.dereference_local(context).await?;
+    let person = follow
+      .actor
+      .clone()
+      .dereference(context, local_instance(context).await, request_counter)
+      .await?;
+    let accept = AcceptFollow {
+      actor: ObjectId::new(user_or_community.actor_id()),
+      object: follow,
+      kind: AcceptType::Accept,
+      id: generate_activity_id(
+        AcceptType::Accept,
+        &context.settings().get_protocol_and_hostname(),
+      )?,
+    };
+    let inbox = vec![person.shared_inbox_or_inbox()];
+    send_lemmy_activity(context, accept, &user_or_community, inbox, true).await
+  }
 }
 
 /// Handle accepted follows
 #[async_trait::async_trait(?Send)]
-impl ActivityHandler for AcceptFollowCommunity {
+impl ActivityHandler for AcceptFollow {
+  type DataType = LemmyContext;
+  type Error = LemmyError;
+
+  fn id(&self) -> &Url {
+    &self.id
+  }
+
+  fn actor(&self) -> &Url {
+    self.actor.inner()
+  }
+
+  #[tracing::instrument(skip_all)]
   async fn verify(
     &self,
-    context: &LemmyContext,
+    context: &Data<LemmyContext>,
     request_counter: &mut i32,
   ) -> Result<(), LemmyError> {
-    verify_activity(self.common())?;
-    verify_urls_match(&self.to, &self.object.common.actor)?;
-    verify_urls_match(&self.common.actor, &self.object.to)?;
-    verify_community(&self.common.actor, context, request_counter).await?;
+    verify_urls_match(self.actor.inner(), self.object.object.inner())?;
     self.object.verify(context, request_counter).await?;
     Ok(())
   }
 
+  #[tracing::instrument(skip_all)]
   async fn receive(
-    &self,
-    context: &LemmyContext,
+    self,
+    context: &Data<LemmyContext>,
     request_counter: &mut i32,
   ) -> Result<(), LemmyError> {
-    let actor =
-      get_or_fetch_and_upsert_community(&self.common.actor, context, request_counter).await?;
-    let to = get_or_fetch_and_upsert_person(&self.to, context, request_counter).await?;
+    let community = self
+      .actor
+      .dereference(context, local_instance(context).await, request_counter)
+      .await?;
+    let person = self
+      .object
+      .actor
+      .dereference(context, local_instance(context).await, request_counter)
+      .await?;
     // This will throw an error if no follow was requested
-    blocking(context.pool(), move |conn| {
-      CommunityFollower::follow_accepted(conn, actor.id, to.id)
-    })
-    .await??;
+    let community_id = community.id;
+    let person_id = person.id;
+    CommunityFollower::follow_accepted(context.pool(), community_id, person_id).await?;
 
-    Ok(())
-  }
+    // Send the Subscribed message over websocket
+    // Re-read the community_view to get the new SubscribedType
+    let community_view = CommunityView::read(context.pool(), community_id, Some(person_id)).await?;
 
-  fn common(&self) -> &ActivityCommonFields {
-    &self.common
+    // Get the local_user_id
+    let local_recipient_id = LocalUserView::read_person(context.pool(), person_id)
+      .await?
+      .local_user
+      .id;
+
+    let response = CommunityResponse { community_view };
+
+    context.chat_server().do_send(SendUserRoomMessage {
+      op: UserOperation::FollowCommunity,
+      response,
+      local_recipient_id,
+      websocket_id: None,
+    });
+
+    Ok(())
   }
 }