use crate::{
- activities::{generate_activity_id, send_lemmy_activity, verify_activity, verify_person},
+ activities::{generate_activity_id, send_lemmy_activity, verify_person},
+ fetcher::user_or_community::UserOrCommunity,
+ insert_received_activity,
objects::{community::ApubCommunity, person::ApubPerson},
- protocol::activities::following::{follow::FollowCommunity, undo_follow::UndoFollowCommunity},
+ protocol::activities::following::{follow::Follow, undo_follow::UndoFollow},
};
-use activitystreams_kinds::activity::UndoType;
-use lemmy_api_common::blocking;
-use lemmy_apub_lib::{
- data::Data,
- object_id::ObjectId,
- traits::{ActivityHandler, ActorType},
- verify::verify_urls_match,
+use activitypub_federation::{
+ config::Data,
+ kinds::activity::UndoType,
+ protocol::verification::verify_urls_match,
+ traits::{ActivityHandler, Actor},
};
+use lemmy_api_common::context::LemmyContext;
use lemmy_db_schema::{
- source::community::{CommunityFollower, CommunityFollowerForm},
+ source::{
+ community::{CommunityFollower, CommunityFollowerForm},
+ person::{PersonFollower, PersonFollowerForm},
+ },
traits::Followable,
};
-use lemmy_utils::LemmyError;
-use lemmy_websocket::LemmyContext;
+use lemmy_utils::error::LemmyError;
+use url::Url;
-impl UndoFollowCommunity {
+impl UndoFollow {
+ #[tracing::instrument(skip_all)]
pub async fn send(
actor: &ApubPerson,
community: &ApubCommunity,
- context: &LemmyContext,
+ context: &Data<LemmyContext>,
) -> Result<(), LemmyError> {
- let object = FollowCommunity::new(actor, community, context)?;
- let undo = UndoFollowCommunity {
- actor: ObjectId::new(actor.actor_id()),
+ let object = Follow::new(actor, community, context)?;
+ let undo = UndoFollow {
+ actor: actor.id().into(),
+ to: Some([community.id().into()]),
object,
kind: UndoType::Undo,
id: generate_activity_id(
UndoType::Undo,
&context.settings().get_protocol_and_hostname(),
)?,
- unparsed: Default::default(),
};
- let inbox = vec![community.shared_inbox_or_inbox_url()];
- send_lemmy_activity(context, &undo, &undo.id, actor, inbox, true).await
+ let inbox = vec![community.shared_inbox_or_inbox()];
+ send_lemmy_activity(context, undo, actor, inbox, true).await
}
}
-#[async_trait::async_trait(?Send)]
-impl ActivityHandler for UndoFollowCommunity {
+#[async_trait::async_trait]
+impl ActivityHandler for UndoFollow {
type DataType = LemmyContext;
- async fn verify(
- &self,
- context: &Data<LemmyContext>,
- request_counter: &mut i32,
- ) -> Result<(), LemmyError> {
- verify_activity(&self.id, self.actor.inner(), &context.settings())?;
+ type Error = LemmyError;
+
+ fn id(&self) -> &Url {
+ &self.id
+ }
+
+ fn actor(&self) -> &Url {
+ self.actor.inner()
+ }
+
+ #[tracing::instrument(skip_all)]
+ async fn verify(&self, context: &Data<LemmyContext>) -> Result<(), LemmyError> {
+ insert_received_activity(&self.id, context).await?;
verify_urls_match(self.actor.inner(), self.object.actor.inner())?;
- verify_person(&self.actor, context, request_counter).await?;
- self.object.verify(context, request_counter).await?;
+ verify_person(&self.actor, context).await?;
+ self.object.verify(context).await?;
+ if let Some(to) = &self.to {
+ verify_urls_match(to[0].inner(), self.object.object.inner())?;
+ }
Ok(())
}
- async fn receive(
- self,
- context: &Data<LemmyContext>,
- request_counter: &mut i32,
- ) -> Result<(), LemmyError> {
- let person = self.actor.dereference(context, request_counter).await?;
- let community = self
- .object
- .object
- .dereference(context, request_counter)
- .await?;
+ #[tracing::instrument(skip_all)]
+ async fn receive(self, context: &Data<LemmyContext>) -> Result<(), LemmyError> {
+ let person = self.actor.dereference(context).await?;
+ let object = self.object.object.dereference(context).await?;
- let community_follower_form = CommunityFollowerForm {
- community_id: community.id,
- person_id: person.id,
- pending: false,
- };
+ match object {
+ UserOrCommunity::User(u) => {
+ let form = PersonFollowerForm {
+ person_id: u.id,
+ follower_id: person.id,
+ pending: false,
+ };
+ PersonFollower::unfollow(&mut context.pool(), &form).await?;
+ }
+ UserOrCommunity::Community(c) => {
+ let form = CommunityFollowerForm {
+ community_id: c.id,
+ person_id: person.id,
+ pending: false,
+ };
+ CommunityFollower::unfollow(&mut context.pool(), &form).await?;
+ }
+ }
- // This will fail if they aren't a follower, but ignore the error.
- blocking(context.pool(), move |conn| {
- CommunityFollower::unfollow(conn, &community_follower_form).ok()
- })
- .await?;
Ok(())
}
}