use crate::{
- generate_moderators_url,
insert_activity,
local_instance,
objects::{community::ApubCommunity, person::ApubPerson},
CONTEXT,
};
use activitypub_federation::{
- core::{activity_queue::SendActivity, object_id::ObjectId},
+ core::{activity_queue::send_activity, object_id::ObjectId},
deser::context::WithContext,
+ traits::{ActivityHandler, Actor},
};
use activitystreams_kinds::public;
use anyhow::anyhow;
-use lemmy_api_common::utils::blocking;
-use lemmy_db_schema::source::community::Community;
+use lemmy_api_common::context::LemmyContext;
+use lemmy_db_schema::{
+ newtypes::CommunityId,
+ source::{community::Community, local_site::LocalSite},
+};
use lemmy_db_views_actor::structs::{CommunityPersonBanView, CommunityView};
use lemmy_utils::error::LemmyError;
-use lemmy_websocket::LemmyContext;
use serde::Serialize;
use std::ops::Deref;
use tracing::info;
pub mod create_or_update;
pub mod deletion;
pub mod following;
+pub mod unfederated;
pub mod voting;
/// Checks that the specified Url actually identifies a Person (by fetching it), and that the person
request_counter: &mut i32,
) -> Result<(), LemmyError> {
let person = person_id
- .dereference::<LemmyError>(context, local_instance(context), request_counter)
+ .dereference(context, local_instance(context).await, request_counter)
.await?;
if person.banned {
let err = anyhow!("Person {} is banned", person_id);
request_counter: &mut i32,
) -> Result<(), LemmyError> {
let person = person_id
- .dereference::<LemmyError>(context, local_instance(context), request_counter)
+ .dereference(context, local_instance(context).await, request_counter)
.await?;
if person.banned {
return Err(LemmyError::from_message("Person is banned from site"));
}
let person_id = person.id;
let community_id = community.id;
- let is_banned =
- move |conn: &'_ _| CommunityPersonBanView::get(conn, person_id, community_id).is_ok();
- if blocking(context.pool(), is_banned).await? {
+ let is_banned = CommunityPersonBanView::get(context.pool(), person_id, community_id)
+ .await
+ .is_ok();
+ if is_banned {
return Err(LemmyError::from_message("Person is banned from community"));
}
Ok(())
}
-/// Verify that the actor is a community mod. This check is only run if the community is local,
-/// because in case of remote communities, admins can also perform mod actions. As admin status
-/// is not federated, we cant verify their actions remotely.
+/// Verify that mod action in community was performed by a moderator.
///
/// * `mod_id` - Activitypub ID of the mod or admin who performed the action
/// * `object_id` - Activitypub ID of the actor or object that is being moderated
pub(crate) async fn verify_mod_action(
mod_id: &ObjectId<ApubPerson>,
object_id: &Url,
- community: &ApubCommunity,
+ community_id: CommunityId,
context: &LemmyContext,
request_counter: &mut i32,
) -> Result<(), LemmyError> {
- if community.local {
- let actor = mod_id
- .dereference::<LemmyError>(context, local_instance(context), request_counter)
- .await?;
-
- // Note: this will also return true for admins in addition to mods, but as we dont know about
- // remote admins, it doesnt make any difference.
- let community_id = community.id;
- let actor_id = actor.id;
-
- let is_mod_or_admin = blocking(context.pool(), move |conn| {
- CommunityView::is_mod_or_admin(conn, actor_id, community_id)
- })
+ let mod_ = mod_id
+ .dereference(context, local_instance(context).await, request_counter)
.await?;
- // mod action was done either by a community mod or a local admin, so its allowed
- if is_mod_or_admin {
- return Ok(());
- }
-
- // mod action comes from the same instance as the moderated object, so it was presumably done
- // by an instance admin and is legitimate (admin status is not federated).
- if mod_id.inner().domain() == object_id.domain() {
- return Ok(());
- }
-
- // the user is not a valid mod
- return Err(LemmyError::from_message("Not a mod"));
+ let is_mod_or_admin =
+ CommunityView::is_mod_or_admin(context.pool(), mod_.id, community_id).await?;
+ if is_mod_or_admin {
+ return Ok(());
}
- Ok(())
-}
-/// For Add/Remove community moderator activities, check that the target field actually contains
-/// /c/community/moderators. Any different values are unsupported.
-fn verify_add_remove_moderator_target(
- target: &Url,
- community: &ApubCommunity,
-) -> Result<(), LemmyError> {
- if target != &generate_moderators_url(&community.actor_id)?.into() {
- return Err(LemmyError::from_message("Unkown target url"));
+ // mod action comes from the same instance as the moderated object, so it was presumably done
+ // by an instance admin.
+ // TODO: federate instance admin status and check it here
+ if mod_id.inner().domain() == object_id.domain() {
+ return Ok(());
}
- Ok(())
+
+ Err(LemmyError::from_message("Not a mod"))
}
pub(crate) fn verify_is_public(to: &[Url], cc: &[Url]) -> Result<(), LemmyError> {
Ok(())
}
+pub(crate) fn verify_community_matches<T>(
+ a: &ObjectId<ApubCommunity>,
+ b: T,
+) -> Result<(), LemmyError>
+where
+ T: Into<ObjectId<ApubCommunity>>,
+{
+ let b: ObjectId<ApubCommunity> = b.into();
+ if a != &b {
+ return Err(LemmyError::from_message("Invalid community"));
+ }
+ Ok(())
+}
+
pub(crate) fn check_community_deleted_or_removed(community: &Community) -> Result<(), LemmyError> {
if community.deleted || community.removed {
Err(LemmyError::from_message(
}
#[tracing::instrument(skip_all)]
-async fn send_lemmy_activity<T: Serialize>(
+async fn send_lemmy_activity<Activity, ActorT>(
context: &LemmyContext,
- activity: &T,
- activity_id: &Url,
- actor: &dyn ActorType,
- inboxes: Vec<Url>,
+ activity: Activity,
+ actor: &ActorT,
+ inbox: Vec<Url>,
sensitive: bool,
-) -> Result<(), LemmyError> {
- if !context.settings().federation.enabled || inboxes.is_empty() {
+) -> Result<(), LemmyError>
+where
+ Activity: ActivityHandler + Serialize,
+ ActorT: Actor + ActorType,
+ Activity: ActivityHandler<Error = LemmyError>,
+{
+ let federation_enabled = LocalSite::read(context.pool())
+ .await
+ .map(|l| l.federation_enabled)
+ .unwrap_or(false);
+ if !federation_enabled {
return Ok(());
}
- let activity = WithContext::new(activity, CONTEXT.deref().clone());
-
- info!("Sending activity {}", activity_id.to_string());
- // Don't send anything to ourselves
- // TODO: this should be a debug assert
- let hostname = context.settings().get_hostname_without_port()?;
- let inboxes: Vec<Url> = inboxes
- .into_iter()
- .filter(|i| i.domain().expect("valid inbox url") != hostname)
- .collect();
-
- let serialised_activity = serde_json::to_string(&activity)?;
+ info!("Sending activity {}", activity.id().to_string());
+ let activity = WithContext::new(activity, CONTEXT.deref().clone());
let object_value = serde_json::to_value(&activity)?;
- insert_activity(activity_id, object_value, true, sensitive, context.pool()).await?;
-
- SendActivity {
- activity_id: activity_id.clone(),
- actor_public_key: actor.get_public_key(),
- actor_private_key: actor.private_key().expect("actor has private key"),
- inboxes,
- activity: serialised_activity,
- }
- .send(local_instance(context))
+ insert_activity(activity.id(), object_value, true, sensitive, context.pool()).await?;
+
+ send_activity(
+ activity,
+ actor.get_public_key(),
+ actor.private_key().expect("actor has private key"),
+ inbox,
+ local_instance(context).await,
+ )
.await?;
Ok(())
projects / lemmy.git / blobdiff