use crate::{
- check_is_apub_id_valid,
- fetcher::object_id::ObjectId,
- generate_moderators_url,
+ insert_activity,
objects::{community::ApubCommunity, person::ApubPerson},
+ CONTEXT,
};
-use activitystreams::public;
-use anyhow::anyhow;
-use lemmy_api_common::blocking;
-use lemmy_apub_lib::{traits::ActivityFields, verify::verify_domains_match};
-use lemmy_db_schema::source::community::Community;
-use lemmy_db_views_actor::{
- community_person_ban_view::CommunityPersonBanView,
- community_view::CommunityView,
+use activitypub_federation::{
+ activity_queue::send_activity,
+ config::Data,
+ fetch::object_id::ObjectId,
+ kinds::public,
+ protocol::context::WithContext,
+ traits::{ActivityHandler, Actor},
};
-use lemmy_utils::{settings::structs::Settings, LemmyError};
-use lemmy_websocket::LemmyContext;
-use serde::{Deserialize, Serialize};
-use strum_macros::ToString;
+use anyhow::anyhow;
+use lemmy_api_common::context::LemmyContext;
+use lemmy_db_schema::{newtypes::CommunityId, source::community::Community};
+use lemmy_db_views_actor::structs::{CommunityPersonBanView, CommunityView};
+use lemmy_utils::error::{LemmyError, LemmyErrorExt, LemmyErrorType};
+use serde::Serialize;
+use std::ops::Deref;
+use tracing::info;
use url::{ParseError, Url};
use uuid::Uuid;
-pub mod comment;
+pub mod block;
pub mod community;
+pub mod create_or_update;
pub mod deletion;
pub mod following;
-pub mod post;
-pub mod private_message;
-pub mod report;
+pub mod unfederated;
pub mod voting;
-#[derive(Clone, Debug, ToString, Deserialize, Serialize)]
-pub enum CreateOrUpdateType {
- Create,
- Update,
-}
-
/// Checks that the specified Url actually identifies a Person (by fetching it), and that the person
/// doesn't have a site ban.
+#[tracing::instrument(skip_all)]
async fn verify_person(
person_id: &ObjectId<ApubPerson>,
- context: &LemmyContext,
- request_counter: &mut i32,
+ context: &Data<LemmyContext>,
) -> Result<(), LemmyError> {
- let person = person_id.dereference(context, request_counter).await?;
+ let person = person_id.dereference(context).await?;
if person.banned {
- return Err(anyhow!("Person {} is banned", person_id).into());
+ return Err(anyhow!("Person {} is banned", person_id))
+ .with_lemmy_type(LemmyErrorType::CouldntUpdateComment);
}
Ok(())
}
/// Fetches the person and community to verify their type, then checks if person is banned from site
/// or community.
+#[tracing::instrument(skip_all)]
pub(crate) async fn verify_person_in_community(
person_id: &ObjectId<ApubPerson>,
community: &ApubCommunity,
- context: &LemmyContext,
- request_counter: &mut i32,
+ context: &Data<LemmyContext>,
) -> Result<(), LemmyError> {
- let person = person_id.dereference(context, request_counter).await?;
+ let person = person_id.dereference(context).await?;
if person.banned {
- return Err(anyhow!("Person is banned from site").into());
+ return Err(LemmyErrorType::PersonIsBannedFromSite)?;
}
let person_id = person.id;
let community_id = community.id;
- let is_banned =
- move |conn: &'_ _| CommunityPersonBanView::get(conn, person_id, community_id).is_ok();
- if blocking(context.pool(), is_banned).await? {
- return Err(anyhow!("Person is banned from community").into());
+ let is_banned = CommunityPersonBanView::get(&mut context.pool(), person_id, community_id)
+ .await
+ .is_ok();
+ if is_banned {
+ return Err(LemmyErrorType::PersonIsBannedFromCommunity)?;
}
Ok(())
}
-fn verify_activity(activity: &dyn ActivityFields, settings: &Settings) -> Result<(), LemmyError> {
- check_is_apub_id_valid(activity.actor(), false, settings)?;
- verify_domains_match(activity.id_unchecked(), activity.actor())?;
- Ok(())
-}
-
-/// Verify that the actor is a community mod. This check is only run if the community is local,
-/// because in case of remote communities, admins can also perform mod actions. As admin status
-/// is not federated, we cant verify their actions remotely.
+/// Verify that mod action in community was performed by a moderator.
+///
+/// * `mod_id` - Activitypub ID of the mod or admin who performed the action
+/// * `object_id` - Activitypub ID of the actor or object that is being moderated
+/// * `community` - The community inside which moderation is happening
+#[tracing::instrument(skip_all)]
pub(crate) async fn verify_mod_action(
- actor_id: &ObjectId<ApubPerson>,
- community_id: &ObjectId<ApubCommunity>,
- context: &LemmyContext,
- request_counter: &mut i32,
+ mod_id: &ObjectId<ApubPerson>,
+ object_id: &Url,
+ community_id: CommunityId,
+ context: &Data<LemmyContext>,
) -> Result<(), LemmyError> {
- let community = community_id.dereference_local(context).await?;
+ let mod_ = mod_id.dereference(context).await?;
- if community.local {
- let actor = actor_id.dereference(context, request_counter).await?;
+ let is_mod_or_admin =
+ CommunityView::is_mod_or_admin(&mut context.pool(), mod_.id, community_id).await?;
+ if is_mod_or_admin {
+ return Ok(());
+ }
- // Note: this will also return true for admins in addition to mods, but as we dont know about
- // remote admins, it doesnt make any difference.
- let community_id = community.id;
- let actor_id = actor.id;
- let is_mod_or_admin = blocking(context.pool(), move |conn| {
- CommunityView::is_mod_or_admin(conn, actor_id, community_id)
- })
- .await?;
- if !is_mod_or_admin {
- return Err(anyhow!("Not a mod").into());
- }
+ // mod action comes from the same instance as the moderated object, so it was presumably done
+ // by an instance admin.
+ // TODO: federate instance admin status and check it here
+ if mod_id.inner().domain() == object_id.domain() {
+ return Ok(());
}
- Ok(())
+
+ Err(LemmyErrorType::NotAModerator)?
}
-/// For Add/Remove community moderator activities, check that the target field actually contains
-/// /c/community/moderators. Any different values are unsupported.
-fn verify_add_remove_moderator_target(
- target: &Url,
- community: &ObjectId<ApubCommunity>,
-) -> Result<(), LemmyError> {
- if target != &generate_moderators_url(&community.clone().into())?.into_inner() {
- return Err(anyhow!("Unkown target url").into());
+pub(crate) fn verify_is_public(to: &[Url], cc: &[Url]) -> Result<(), LemmyError> {
+ if ![to, cc].iter().any(|set| set.contains(&public())) {
+ return Err(LemmyErrorType::ObjectIsNotPublic)?;
}
Ok(())
}
-pub(crate) fn verify_is_public(to: &[Url]) -> Result<(), LemmyError> {
- if !to.contains(&public()) {
- return Err(anyhow!("Object is not public").into());
+pub(crate) fn verify_community_matches<T>(
+ a: &ObjectId<ApubCommunity>,
+ b: T,
+) -> Result<(), LemmyError>
+where
+ T: Into<ObjectId<ApubCommunity>>,
+{
+ let b: ObjectId<ApubCommunity> = b.into();
+ if a != &b {
+ return Err(LemmyErrorType::InvalidCommunity)?;
}
Ok(())
}
pub(crate) fn check_community_deleted_or_removed(community: &Community) -> Result<(), LemmyError> {
if community.deleted || community.removed {
- Err(anyhow!("New post or comment cannot be created in deleted or removed community").into())
+ Err(LemmyErrorType::CannotCreatePostOrCommentInDeletedOrRemovedCommunity)?
} else {
Ok(())
}
);
Url::parse(&id)
}
+
+#[tracing::instrument(skip_all)]
+async fn send_lemmy_activity<Activity, ActorT>(
+ data: &Data<LemmyContext>,
+ activity: Activity,
+ actor: &ActorT,
+ inbox: Vec<Url>,
+ sensitive: bool,
+) -> Result<(), LemmyError>
+where
+ Activity: ActivityHandler + Serialize + Send + Sync + Clone,
+ ActorT: Actor,
+ Activity: ActivityHandler<Error = LemmyError>,
+{
+ info!("Sending activity {}", activity.id().to_string());
+ let activity = WithContext::new(activity, CONTEXT.deref().clone());
+
+ insert_activity(activity.id(), &activity, true, sensitive, data).await?;
+ send_activity(activity, actor, inbox, data).await?;
+
+ Ok(())
+}