use crate::{
- check_community_or_site_ban,
- check_is_apub_id_valid,
- fetcher::{community::get_or_fetch_and_upsert_community, person::get_or_fetch_and_upsert_person},
- generate_moderators_url,
+ objects::{community::ApubCommunity, person::ApubPerson},
+ CONTEXT,
+};
+use activitypub_federation::{
+ activity_queue::send_activity,
+ config::Data,
+ fetch::object_id::ObjectId,
+ kinds::public,
+ protocol::context::WithContext,
+ traits::{ActivityHandler, Actor},
};
use anyhow::anyhow;
-use lemmy_api_common::blocking;
-use lemmy_apub_lib::{verify_domains_match, ActivityCommonFields};
-use lemmy_db_queries::ApubObject;
+use lemmy_api_common::context::LemmyContext;
use lemmy_db_schema::{
- source::{community::Community, person::Person},
- DbUrl,
+ newtypes::CommunityId,
+ source::{
+ activity::{SentActivity, SentActivityForm},
+ community::Community,
+ instance::Instance,
+ },
};
-use lemmy_db_views_actor::community_view::CommunityView;
-use lemmy_utils::LemmyError;
-use lemmy_websocket::LemmyContext;
-use url::Url;
+use lemmy_db_views_actor::structs::{CommunityPersonBanView, CommunityView};
+use lemmy_utils::error::{LemmyError, LemmyErrorExt, LemmyErrorType};
+use moka::future::Cache;
+use once_cell::sync::Lazy;
+use serde::Serialize;
+use std::{ops::Deref, sync::Arc, time::Duration};
+use tracing::info;
+use url::{ParseError, Url};
+use uuid::Uuid;
-pub mod comment;
+pub mod block;
pub mod community;
+pub mod create_or_update;
pub mod deletion;
pub mod following;
-pub mod post;
-pub mod private_message;
-pub mod removal;
-pub mod send;
+pub mod unfederated;
pub mod voting;
+/// Amount of time that the list of dead instances is cached. This is only updated once a day,
+/// so there is no harm in caching it for a longer time.
+pub static DEAD_INSTANCE_LIST_CACHE_DURATION: Duration = Duration::from_secs(30 * 60);
+
/// Checks that the specified Url actually identifies a Person (by fetching it), and that the person
/// doesn't have a site ban.
+#[tracing::instrument(skip_all)]
async fn verify_person(
- person_id: &Url,
- context: &LemmyContext,
- request_counter: &mut i32,
+ person_id: &ObjectId<ApubPerson>,
+ context: &Data<LemmyContext>,
) -> Result<(), LemmyError> {
- let person = get_or_fetch_and_upsert_person(person_id, context, request_counter).await?;
+ let person = person_id.dereference(context).await?;
if person.banned {
- return Err(anyhow!("Person {} is banned", person_id).into());
+ return Err(anyhow!("Person {} is banned", person_id))
+ .with_lemmy_type(LemmyErrorType::CouldntUpdateComment);
}
Ok(())
}
/// Fetches the person and community to verify their type, then checks if person is banned from site
/// or community.
-async fn verify_person_in_community(
- person_id: &Url,
- cc: &[Url],
- context: &LemmyContext,
- request_counter: &mut i32,
-) -> Result<Community, LemmyError> {
- let person = get_or_fetch_and_upsert_person(person_id, context, request_counter).await?;
- let mut cc_iter = cc.iter();
- let community: Community = loop {
- if let Some(cid) = cc_iter.next() {
- if let Ok(c) = get_or_fetch_and_upsert_community(cid, context, request_counter).await {
- break c;
- }
- } else {
- return Err(anyhow!("No community found in cc").into());
- }
- };
- check_community_or_site_ban(&person, community.id, context.pool()).await?;
- Ok(community)
+#[tracing::instrument(skip_all)]
+pub(crate) async fn verify_person_in_community(
+ person_id: &ObjectId<ApubPerson>,
+ community: &ApubCommunity,
+ context: &Data<LemmyContext>,
+) -> Result<(), LemmyError> {
+ let person = person_id.dereference(context).await?;
+ if person.banned {
+ return Err(LemmyErrorType::PersonIsBannedFromSite)?;
+ }
+ let person_id = person.id;
+ let community_id = community.id;
+ let is_banned = CommunityPersonBanView::get(&mut context.pool(), person_id, community_id)
+ .await
+ .is_ok();
+ if is_banned {
+ return Err(LemmyErrorType::PersonIsBannedFromCommunity)?;
+ }
+
+ Ok(())
}
-/// Simply check that the url actually refers to a valid group.
-async fn verify_community(
- community_id: &Url,
- context: &LemmyContext,
- request_counter: &mut i32,
+/// Verify that mod action in community was performed by a moderator.
+///
+/// * `mod_id` - Activitypub ID of the mod or admin who performed the action
+/// * `object_id` - Activitypub ID of the actor or object that is being moderated
+/// * `community` - The community inside which moderation is happening
+#[tracing::instrument(skip_all)]
+pub(crate) async fn verify_mod_action(
+ mod_id: &ObjectId<ApubPerson>,
+ object_id: &Url,
+ community_id: CommunityId,
+ context: &Data<LemmyContext>,
) -> Result<(), LemmyError> {
- get_or_fetch_and_upsert_community(community_id, context, request_counter).await?;
- Ok(())
+ let mod_ = mod_id.dereference(context).await?;
+
+ let is_mod_or_admin =
+ CommunityView::is_mod_or_admin(&mut context.pool(), mod_.id, community_id).await?;
+ if is_mod_or_admin {
+ return Ok(());
+ }
+
+ // mod action comes from the same instance as the moderated object, so it was presumably done
+ // by an instance admin.
+ // TODO: federate instance admin status and check it here
+ if mod_id.inner().domain() == object_id.domain() {
+ return Ok(());
+ }
+
+ Err(LemmyErrorType::NotAModerator)?
}
-fn verify_activity(common: &ActivityCommonFields) -> Result<(), LemmyError> {
- check_is_apub_id_valid(&common.actor, false)?;
- verify_domains_match(common.id_unchecked(), &common.actor)?;
+pub(crate) fn verify_is_public(to: &[Url], cc: &[Url]) -> Result<(), LemmyError> {
+ if ![to, cc].iter().any(|set| set.contains(&public())) {
+ return Err(LemmyErrorType::ObjectIsNotPublic)?;
+ }
Ok(())
}
-async fn verify_mod_action(
- actor_id: &Url,
- activity_cc: Url,
- context: &LemmyContext,
-) -> Result<(), LemmyError> {
- let community = blocking(context.pool(), move |conn| {
- Community::read_from_apub_id(conn, &activity_cc.into())
- })
- .await??;
-
- if community.local {
- let actor_id: DbUrl = actor_id.clone().into();
- let actor = blocking(context.pool(), move |conn| {
- Person::read_from_apub_id(conn, &actor_id)
- })
- .await??;
-
- // Note: this will also return true for admins in addition to mods, but as we dont know about
- // remote admins, it doesnt make any difference.
- let community_id = community.id;
- let actor_id = actor.id;
- let is_mod_or_admin = blocking(context.pool(), move |conn| {
- CommunityView::is_mod_or_admin(conn, actor_id, community_id)
- })
- .await?;
- if !is_mod_or_admin {
- return Err(anyhow!("Not a mod").into());
- }
+pub(crate) fn verify_community_matches<T>(
+ a: &ObjectId<ApubCommunity>,
+ b: T,
+) -> Result<(), LemmyError>
+where
+ T: Into<ObjectId<ApubCommunity>>,
+{
+ let b: ObjectId<ApubCommunity> = b.into();
+ if a != &b {
+ return Err(LemmyErrorType::InvalidCommunity)?;
}
Ok(())
}
-/// For Add/Remove community moderator activities, check that the target field actually contains
-/// /c/community/moderators. Any different values are unsupported.
-fn verify_add_remove_moderator_target(target: &Url, community: Url) -> Result<(), LemmyError> {
- if target != &generate_moderators_url(&community.into())?.into_inner() {
- return Err(anyhow!("Unkown target url").into());
+pub(crate) fn check_community_deleted_or_removed(community: &Community) -> Result<(), LemmyError> {
+ if community.deleted || community.removed {
+ Err(LemmyErrorType::CannotCreatePostOrCommentInDeletedOrRemovedCommunity)?
+ } else {
+ Ok(())
}
+}
+
+/// Generate a unique ID for an activity, in the format:
+/// `http(s)://example.com/receive/create/202daf0a-1489-45df-8d2e-c8a3173fed36`
+fn generate_activity_id<T>(kind: T, protocol_and_hostname: &str) -> Result<Url, ParseError>
+where
+ T: ToString,
+{
+ let id = format!(
+ "{}/activities/{}/{}",
+ protocol_and_hostname,
+ kind.to_string().to_lowercase(),
+ Uuid::new_v4()
+ );
+ Url::parse(&id)
+}
+
+#[tracing::instrument(skip_all)]
+async fn send_lemmy_activity<Activity, ActorT>(
+ data: &Data<LemmyContext>,
+ activity: Activity,
+ actor: &ActorT,
+ mut inbox: Vec<Url>,
+ sensitive: bool,
+) -> Result<(), LemmyError>
+where
+ Activity: ActivityHandler + Serialize + Send + Sync + Clone,
+ ActorT: Actor,
+ Activity: ActivityHandler<Error = LemmyError>,
+{
+ static CACHE: Lazy<Cache<(), Arc<Vec<String>>>> = Lazy::new(|| {
+ Cache::builder()
+ .max_capacity(1)
+ .time_to_live(DEAD_INSTANCE_LIST_CACHE_DURATION)
+ .build()
+ });
+ let dead_instances = CACHE
+ .try_get_with((), async {
+ Ok::<_, diesel::result::Error>(Arc::new(Instance::dead_instances(&mut data.pool()).await?))
+ })
+ .await?;
+
+ inbox.retain(|i| {
+ let domain = i.domain().expect("has domain").to_string();
+ !dead_instances.contains(&domain)
+ });
+ info!("Sending activity {}", activity.id().to_string());
+ let activity = WithContext::new(activity, CONTEXT.deref().clone());
+
+ let form = SentActivityForm {
+ ap_id: activity.id().clone().into(),
+ data: serde_json::to_value(activity.clone())?,
+ sensitive,
+ };
+ SentActivity::create(&mut data.pool(), form).await?;
+ send_activity(activity, actor, inbox, data).await?;
+
Ok(())
}
projects / lemmy.git / blobdiff