+use self::following::send_follow_community;
use crate::{
- check_is_apub_id_valid,
- context::WithContext,
- generate_moderators_url,
- insert_activity,
+ activities::{
+ block::{send_ban_from_community, send_ban_from_site},
+ community::{
+ collection_add::{send_add_mod_to_community, send_feature_post},
+ lock_page::send_lock_post,
+ update::send_update_community,
+ },
+ create_or_update::private_message::send_create_or_update_pm,
+ deletion::{
+ delete_user::delete_user,
+ send_apub_delete_in_community,
+ send_apub_delete_in_community_new,
+ send_apub_delete_private_message,
+ DeletableObjects,
+ },
+ voting::send_like_activity,
+ },
objects::{community::ApubCommunity, person::ApubPerson},
+ protocol::activities::{
+ community::report::Report,
+ create_or_update::{note::CreateOrUpdateNote, page::CreateOrUpdatePage},
+ CreateOrUpdateType,
+ },
+ CONTEXT,
};
-use activitystreams::public;
-use anyhow::anyhow;
-use lemmy_api_common::blocking;
-use lemmy_apub_lib::{
+use activitypub_federation::{
activity_queue::send_activity,
- object_id::ObjectId,
- traits::ActorType,
- verify::verify_domains_match,
+ config::Data,
+ fetch::object_id::ObjectId,
+ kinds::public,
+ protocol::context::WithContext,
+ traits::{ActivityHandler, Actor},
+};
+use anyhow::anyhow;
+use lemmy_api_common::{
+ context::LemmyContext,
+ send_activity::{ActivityChannel, SendActivityData},
};
-use lemmy_db_schema::source::community::Community;
-use lemmy_db_views_actor::{
- community_person_ban_view::CommunityPersonBanView,
- community_view::CommunityView,
+use lemmy_db_schema::{
+ newtypes::CommunityId,
+ source::{
+ activity::{SentActivity, SentActivityForm},
+ community::Community,
+ instance::Instance,
+ },
};
-use lemmy_utils::{settings::structs::Settings, LemmyError};
-use lemmy_websocket::LemmyContext;
-use log::info;
+use lemmy_db_views_actor::structs::{CommunityPersonBanView, CommunityView};
+use lemmy_utils::{
+ error::{LemmyError, LemmyErrorExt, LemmyErrorType, LemmyResult},
+ spawn_try_task,
+ SYNCHRONOUS_FEDERATION,
+};
+use moka::future::Cache;
+use once_cell::sync::Lazy;
use serde::Serialize;
+use std::{ops::Deref, sync::Arc, time::Duration};
+use tracing::info;
use url::{ParseError, Url};
use uuid::Uuid;
-pub mod comment;
+pub mod block;
pub mod community;
+pub mod create_or_update;
pub mod deletion;
pub mod following;
-pub mod post;
-pub mod private_message;
+pub mod unfederated;
pub mod voting;
+/// Amount of time that the list of dead instances is cached. This is only updated once a day,
+/// so there is no harm in caching it for a longer time.
+pub static DEAD_INSTANCE_LIST_CACHE_DURATION: Duration = Duration::from_secs(30 * 60);
+
/// Checks that the specified Url actually identifies a Person (by fetching it), and that the person
/// doesn't have a site ban.
+#[tracing::instrument(skip_all)]
async fn verify_person(
person_id: &ObjectId<ApubPerson>,
- context: &LemmyContext,
- request_counter: &mut i32,
+ context: &Data<LemmyContext>,
) -> Result<(), LemmyError> {
- let person = person_id.dereference(context, request_counter).await?;
+ let person = person_id.dereference(context).await?;
if person.banned {
- return Err(anyhow!("Person {} is banned", person_id).into());
+ return Err(anyhow!("Person {} is banned", person_id))
+ .with_lemmy_type(LemmyErrorType::CouldntUpdateComment);
}
Ok(())
}
/// Fetches the person and community to verify their type, then checks if person is banned from site
/// or community.
+#[tracing::instrument(skip_all)]
pub(crate) async fn verify_person_in_community(
person_id: &ObjectId<ApubPerson>,
community: &ApubCommunity,
- context: &LemmyContext,
- request_counter: &mut i32,
+ context: &Data<LemmyContext>,
) -> Result<(), LemmyError> {
- let person = person_id.dereference(context, request_counter).await?;
+ let person = person_id.dereference(context).await?;
if person.banned {
- return Err(anyhow!("Person is banned from site").into());
+ return Err(LemmyErrorType::PersonIsBannedFromSite(
+ person.actor_id.to_string(),
+ ))?;
}
let person_id = person.id;
let community_id = community.id;
- let is_banned =
- move |conn: &'_ _| CommunityPersonBanView::get(conn, person_id, community_id).is_ok();
- if blocking(context.pool(), is_banned).await? {
- return Err(anyhow!("Person is banned from community").into());
+ let is_banned = CommunityPersonBanView::get(&mut context.pool(), person_id, community_id)
+ .await
+ .is_ok();
+ if is_banned {
+ return Err(LemmyErrorType::PersonIsBannedFromCommunity)?;
}
Ok(())
}
-fn verify_activity(id: &Url, actor: &Url, settings: &Settings) -> Result<(), LemmyError> {
- check_is_apub_id_valid(actor, false, settings)?;
- verify_domains_match(id, actor)?;
- Ok(())
-}
-
-/// Verify that the actor is a community mod. This check is only run if the community is local,
-/// because in case of remote communities, admins can also perform mod actions. As admin status
-/// is not federated, we cant verify their actions remotely.
+/// Verify that mod action in community was performed by a moderator.
+///
+/// * `mod_id` - Activitypub ID of the mod or admin who performed the action
+/// * `object_id` - Activitypub ID of the actor or object that is being moderated
+/// * `community` - The community inside which moderation is happening
+#[tracing::instrument(skip_all)]
pub(crate) async fn verify_mod_action(
-
actor_id: &ObjectId<ApubPerson>,
- community: &ApubCommunity,
- context: &LemmyContext,
- request_counter: &mut i32,
+
mod_id: &ObjectId<ApubPerson>,
+ object_id: &Url,
+ community_id: CommunityId,
+ context: &Data<LemmyContext>,
) -> Result<(), LemmyError> {
- if community.local {
- let actor = actor_id.dereference(context, request_counter).await?;
-
- // Note: this will also return true for admins in addition to mods, but as we dont know about
- // remote admins, it doesnt make any difference.
- let community_id = community.id;
- let actor_id = actor.id;
- let is_mod_or_admin = blocking(context.pool(), move |conn| {
- CommunityView::is_mod_or_admin(conn, actor_id, community_id)
- })
- .await?;
- if !is_mod_or_admin {
- return Err(anyhow!("Not a mod").into());
- }
+ let mod_ = mod_id.dereference(context).await?;
+
+ let is_mod_or_admin =
+ CommunityView::is_mod_or_admin(&mut context.pool(), mod_.id, community_id).await?;
+ if is_mod_or_admin {
+ return Ok(());
}
- Ok(())
+
+ // mod action comes from the same instance as the moderated object, so it was presumably done
+ // by an instance admin.
+ // TODO: federate instance admin status and check it here
+ if mod_id.inner().domain() == object_id.domain() {
+ return Ok(());
+ }
+
+ Err(LemmyErrorType::NotAModerator)?
}
-/// For Add/Remove community moderator activities, check that the target field actually contains
-/// /c/community/moderators. Any different values are unsupported.
-fn verify_add_remove_moderator_target(
- target: &Url,
- community: &ApubCommunity,
-) -> Result<(), LemmyError> {
- if target != &generate_moderators_url(&community.actor_id)?.into() {
- return Err(anyhow!("Unkown target url").into());
+pub(crate) fn verify_is_public(to: &[Url], cc: &[Url]) -> Result<(), LemmyError> {
+ if ![to, cc].iter().any(|set| set.contains(&public())) {
+ Err(LemmyErrorType::ObjectIsNotPublic)?;
}
Ok(())
}
-pub(crate) fn verify_is_public(to: &[Url]) -> Result<(), LemmyError> {
- if !to.contains(&public()) {
- return Err(anyhow!("Object is not public").into());
+pub(crate) fn verify_community_matches<T>(
+ a: &ObjectId<ApubCommunity>,
+ b: T,
+) -> Result<(), LemmyError>
+where
+ T: Into<ObjectId<ApubCommunity>>,
+{
+ let b: ObjectId<ApubCommunity> = b.into();
+ if a != &b {
+ Err(LemmyErrorType::InvalidCommunity)?;
}
Ok(())
}
pub(crate) fn check_community_deleted_or_removed(community: &Community) -> Result<(), LemmyError> {
if community.deleted || community.removed {
- Err(anyhow!("New post or comment cannot be created in deleted or removed community").into())
+ Err(LemmyErrorType::CannotCreatePostOrCommentInDeletedOrRemovedCommunity)?
} else {
Ok(())
}
Url::parse(&id)
}
-async fn send_lemmy_activity<T: Serialize>(
- context: &LemmyContext,
- activity: &T,
- activity_id: &Url,
- actor: &dyn ActorType,
- inboxes: Vec<Url>,
+#[tracing::instrument(skip_all)]
+async fn send_lemmy_activity<Activity, ActorT>(
+ data: &Data<LemmyContext>,
+ activity: Activity,
+ actor: &ActorT,
+ mut inbox: Vec<Url>,
sensitive: bool,
-) -> Result<(), LemmyError> {
- if !context.settings().federation.enabled || inboxes.is_empty() {
- return Ok(());
- }
- let activity = WithContext::new(activity);
+) -> Result<(), LemmyError>
+where
+ Activity: ActivityHandler + Serialize + Send + Sync + Clone,
+ ActorT: Actor,
+ Activity: ActivityHandler<Error = LemmyError>,
+{
+ static CACHE: Lazy<Cache<(), Arc<Vec<String>>>> = Lazy::new(|| {
+ Cache::builder()
+ .max_capacity(1)
+ .time_to_live(DEAD_INSTANCE_LIST_CACHE_DURATION)
+ .build()
+ });
+ let dead_instances = CACHE
+ .try_get_with((), async {
+ Ok::<_, diesel::result::Error>(Arc::new(Instance::dead_instances(&mut data.pool()).await?))
+ })
+ .await?;
- info!("Sending activity {}", activity_id.to_string());
+ inbox.retain(|i| {
+ let domain = i.domain().expect("has domain").to_string();
+ !dead_instances.contains(&domain)
+ });
+ info!("Sending activity {}", activity.id().to_string());
+ let activity = WithContext::new(activity, CONTEXT.deref().clone());
- // Don't send anything to ourselves
- // TODO: this should be a debug assert
- let hostname = context.settings().get_hostname_without_port()?;
- let inboxes: Vec<&Url> = inboxes
- .iter()
- .filter(|i| i.domain().expect("valid inbox url") != hostname)
- .collect();
+ let form = SentActivityForm {
+ ap_id: activity.id().clone().into(),
+ data: serde_json::to_value(activity.clone())?,
+ sensitive,
+ };
+ SentActivity::create(&mut data.pool(), form).await?;
+ send_activity(activity, actor, inbox, data).await?;
- let serialised_activity = serde_json::to_string(&activity)?;
+ Ok(())
+}
- insert_activity(
- activity_id,
- serialised_activity.clone(),
- true,
- sensitive,
- context.pool(),
- )
- .await?;
-
- send_activity(
- serialised_activity,
- actor,
- inboxes,
- context.client(),
- context.activity_queue(),
- )
- .await
+pub async fn handle_outgoing_activities(context: Data<LemmyContext>) -> LemmyResult<()> {
+ while let Some(data) = ActivityChannel::retrieve_activity().await {
+ match_outgoing_activities(data, &context.reset_request_count()).await?
+ }
+ Ok(())
+}
+
+pub async fn match_outgoing_activities(
+ data: SendActivityData,
+ context: &Data<LemmyContext>,
+) -> LemmyResult<()> {
+ let context = context.reset_request_count();
+ let fed_task = async {
+ use SendActivityData::*;
+ match data {
+ CreatePost(post) => {
+ let creator_id = post.creator_id;
+ CreateOrUpdatePage::send(post, creator_id, CreateOrUpdateType::Create, context).await
+ }
+ UpdatePost(post) => {
+ let creator_id = post.creator_id;
+ CreateOrUpdatePage::send(post, creator_id, CreateOrUpdateType::Update, context).await
+ }
+ DeletePost(post, person, data) => {
+ send_apub_delete_in_community_new(
+ person,
+ post.community_id,
+ DeletableObjects::Post(post.into()),
+ None,
+ data.deleted,
+ context,
+ )
+ .await
+ }
+ RemovePost(post, person, data) => {
+ send_apub_delete_in_community_new(
+ person,
+ post.community_id,
+ DeletableObjects::Post(post.into()),
+ data.reason.or_else(|| Some(String::new())),
+ data.removed,
+ context,
+ )
+ .await
+ }
+ LockPost(post, actor, locked) => send_lock_post(post, actor, locked, context).await,
+ FeaturePost(post, actor, featured) => send_feature_post(post, actor, featured, context).await,
+ CreateComment(comment) => {
+ let creator_id = comment.creator_id;
+ CreateOrUpdateNote::send(comment, creator_id, CreateOrUpdateType::Create, context).await
+ }
+ UpdateComment(comment) => {
+ let creator_id = comment.creator_id;
+ CreateOrUpdateNote::send(comment, creator_id, CreateOrUpdateType::Update, context).await
+ }
+ DeleteComment(comment, actor, community) => {
+ let is_deleted = comment.deleted;
+ let deletable = DeletableObjects::Comment(comment.into());
+ send_apub_delete_in_community(actor, community, deletable, None, is_deleted, &context).await
+ }
+ RemoveComment(comment, actor, community, reason) => {
+ let is_removed = comment.removed;
+ let deletable = DeletableObjects::Comment(comment.into());
+ send_apub_delete_in_community(actor, community, deletable, reason, is_removed, &context)
+ .await
+ }
+ LikePostOrComment(object_id, person, community, score) => {
+ send_like_activity(object_id, person, community, score, context).await
+ }
+ FollowCommunity(community, person, follow) => {
+ send_follow_community(community, person, follow, &context).await
+ }
+ UpdateCommunity(actor, community) => send_update_community(community, actor, context).await,
+ DeleteCommunity(actor, community, removed) => {
+ let deletable = DeletableObjects::Community(community.clone().into());
+ send_apub_delete_in_community(actor, community, deletable, None, removed, &context).await
+ }
+ RemoveCommunity(actor, community, reason, removed) => {
+ let deletable = DeletableObjects::Community(community.clone().into());
+ send_apub_delete_in_community(
+ actor,
+ community,
+ deletable,
+ reason.clone().or_else(|| Some(String::new())),
+ removed,
+ &context,
+ )
+ .await
+ }
+ AddModToCommunity(actor, community_id, updated_mod_id, added) => {
+ send_add_mod_to_community(actor, community_id, updated_mod_id, added, context).await
+ }
+ BanFromCommunity(mod_, community_id, target, data) => {
+ send_ban_from_community(mod_, community_id, target, data, context).await
+ }
+ BanFromSite(mod_, target, data) => send_ban_from_site(mod_, target, data, context).await,
+ CreatePrivateMessage(pm) => {
+ send_create_or_update_pm(pm, CreateOrUpdateType::Create, context).await
+ }
+ UpdatePrivateMessage(pm) => {
+ send_create_or_update_pm(pm, CreateOrUpdateType::Update, context).await
+ }
+ DeletePrivateMessage(person, pm, deleted) => {
+ send_apub_delete_private_message(&person.into(), pm, deleted, context).await
+ }
+ DeleteUser(person) => delete_user(person, context).await,
+ CreateReport(url, actor, community, reason) => {
+ Report::send(ObjectId::from(url), actor, community, reason, context).await
+ }
+ }
+ };
+ if *SYNCHRONOUS_FEDERATION {
+ fed_task.await?;
+ } else {
+ spawn_try_task(fed_task);
+ }
+ Ok(())
}
projects / lemmy.git / blobdiff