use crate::{
activities::{
- community::{announce::AnnouncableActivities, send_to_community},
+ community::{announce::GetCommunity, send_activity_in_community},
generate_activity_id,
- verify_activity,
verify_person_in_community,
voting::{vote_comment, vote_post},
},
- context::lemmy_context,
- fetcher::object_id::ObjectId,
+ activity_lists::AnnouncableActivities,
+ local_instance,
+ objects::{community::ApubCommunity, person::ApubPerson},
+ protocol::activities::voting::vote::{Vote, VoteType},
+ ActorType,
PostOrComment,
};
-use activitystreams::{base::AnyBase, primitives::OneOrMany, unparsed::Unparsed};
+use activitypub_federation::{core::object_id::ObjectId, data::Data, traits::ActivityHandler};
+use activitystreams_kinds::public;
use anyhow::anyhow;
-use lemmy_api_common::blocking;
-use lemmy_apub_lib::{
- data::Data,
- traits::{ActivityFields, ActivityHandler, ActorType},
- values::PublicUrl,
-};
-use lemmy_db_queries::Crud;
+use lemmy_api_common::utils::blocking;
use lemmy_db_schema::{
- source::{community::Community, person::Person},
- CommunityId,
+ newtypes::CommunityId,
+ source::{community::Community, post::Post, site::Site},
+ traits::Crud,
};
-use lemmy_utils::LemmyError;
+use lemmy_utils::error::LemmyError;
use lemmy_websocket::LemmyContext;
-use serde::{Deserialize, Serialize};
-use std::{convert::TryFrom, ops::Deref};
-use strum_macros::ToString;
use url::Url;
-#[derive(Clone, Debug, ToString, Deserialize, Serialize)]
-pub enum VoteType {
- Like,
- Dislike,
-}
-
-impl TryFrom<i16> for VoteType {
- type Error = LemmyError;
-
- fn try_from(value: i16) -> Result<Self, Self::Error> {
- match value {
- 1 => Ok(VoteType::Like),
- -1 => Ok(VoteType::Dislike),
- _ => Err(anyhow!("invalid vote value").into()),
- }
- }
-}
-
-impl From<&VoteType> for i16 {
- fn from(value: &VoteType) -> i16 {
- match value {
- VoteType::Like => 1,
- VoteType::Dislike => -1,
- }
- }
-}
-
-#[derive(Clone, Debug, Deserialize, Serialize, ActivityFields)]
-#[serde(rename_all = "camelCase")]
-pub struct Vote {
- actor: ObjectId<Person>,
- to: [PublicUrl; 1],
- pub(in crate::activities::voting) object: ObjectId<PostOrComment>,
- cc: [ObjectId<Community>; 1],
- #[serde(rename = "type")]
- pub(in crate::activities::voting) kind: VoteType,
- id: Url,
- #[serde(rename = "@context")]
- context: OneOrMany<AnyBase>,
- #[serde(flatten)]
- unparsed: Unparsed,
-}
-
+/// Vote has as:Public value in cc field, unlike other activities. This indicates to other software
+/// (like GNU social, or presumably Mastodon), that the like actor should not be disclosed.
impl Vote {
pub(in crate::activities::voting) fn new(
object: &PostOrComment,
- actor: &Person,
- community: &Community,
+ actor: &ApubPerson,
kind: VoteType,
context: &LemmyContext,
) -> Result<Vote, LemmyError> {
Ok(Vote {
actor: ObjectId::new(actor.actor_id()),
- to: [PublicUrl::Public],
object: ObjectId::new(object.ap_id()),
- cc: [ObjectId::new(community.actor_id())],
+ cc: vec![public()],
kind: kind.clone(),
id: generate_activity_id(kind, &context.settings().get_protocol_and_hostname())?,
- context: lemmy_context(),
unparsed: Default::default(),
})
}
+ #[tracing::instrument(skip_all)]
pub async fn send(
object: &PostOrComment,
- actor: &Person,
+ actor: &ApubPerson,
community_id: CommunityId,
kind: VoteType,
context: &LemmyContext,
let community = blocking(context.pool(), move |conn| {
Community::read(conn, community_id)
})
- .await??;
- let vote = Vote::new(object, actor, &community, kind, context)?;
- let vote_id = vote.id.clone();
+ .await??
+ .into();
+ let vote = Vote::new(object, actor, kind, context)?;
let activity = AnnouncableActivities::Vote(vote);
- send_to_community(activity, &vote_id, actor, &community, vec![], context).await
+ send_activity_in_community(activity, actor, &community, vec![], context).await
}
}
#[async_trait::async_trait(?Send)]
impl ActivityHandler for Vote {
type DataType = LemmyContext;
+ type Error = LemmyError;
+
+ fn id(&self) -> &Url {
+ &self.id
+ }
+
+ fn actor(&self) -> &Url {
+ self.actor.inner()
+ }
+
+ #[tracing::instrument(skip_all)]
async fn verify(
&self,
context: &Data<LemmyContext>,
request_counter: &mut i32,
) -> Result<(), LemmyError> {
- verify_activity(self, &context.settings())?;
- verify_person_in_community(&self.actor, &self.cc[0], context, request_counter).await?;
+ let community = self.get_community(context, request_counter).await?;
+ verify_person_in_community(&self.actor, &community, context, request_counter).await?;
+ let site = blocking(context.pool(), Site::read_local).await??;
+ if self.kind == VoteType::Dislike && !site.enable_downvotes {
+ return Err(anyhow!("Downvotes disabled").into());
+ }
Ok(())
}
+ #[tracing::instrument(skip_all)]
async fn receive(
self,
context: &Data<LemmyContext>,
request_counter: &mut i32,
) -> Result<(), LemmyError> {
- let actor = self.actor.dereference(context, request_counter).await?;
- let object = self.object.dereference(context, request_counter).await?;
+ let actor = self
+ .actor
+ .dereference(context, local_instance(context), request_counter)
+ .await?;
+ let object = self
+ .object
+ .dereference(context, local_instance(context), request_counter)
+ .await?;
match object {
- PostOrComment::Post(p) => vote_post(&self.kind, actor, p.deref(), context).await,
+ PostOrComment::Post(p) => vote_post(&self.kind, actor, &p, context).await,
PostOrComment::Comment(c) => vote_comment(&self.kind, actor, &c, context).await,
}
}
}
+
+#[async_trait::async_trait(?Send)]
+impl GetCommunity for Vote {
+ #[tracing::instrument(skip_all)]
+ async fn get_community(
+ &self,
+ context: &LemmyContext,
+ request_counter: &mut i32,
+ ) -> Result<ApubCommunity, LemmyError> {
+ let object = self
+ .object
+ .dereference(context, local_instance(context), request_counter)
+ .await?;
+ let cid = match object {
+ PostOrComment::Post(p) => p.community_id,
+ PostOrComment::Comment(c) => {
+ blocking(context.pool(), move |conn| Post::read(conn, c.post_id))
+ .await??
+ .community_id
+ }
+ };
+ let community = blocking(context.pool(), move |conn| Community::read(conn, cid)).await??;
+ Ok(community.into())
+ }
+}
projects / lemmy.git / blobdiff