use crate::{
- activities::{post::create_or_update::CreateOrUpdatePost, CreateOrUpdateType},
+ activity_lists::AnnouncableActivities,
collections::CommunityContext,
- generate_outbox_url,
- objects::{person::ApubPerson, post::ApubPost},
+ objects::post::ApubPost,
+ protocol::{
+ activities::{
+ community::announce::AnnounceActivity,
+ create_or_update::page::CreateOrUpdatePage,
+ CreateOrUpdateType,
+ },
+ collections::group_outbox::GroupOutbox,
+ },
};
-use activitystreams::collection::kind::OrderedCollectionType;
-use chrono::NaiveDateTime;
-use lemmy_api_common::blocking;
-use lemmy_apub_lib::{
+use activitypub_federation::{
data::Data,
traits::{ActivityHandler, ApubObject},
- verify::verify_domains_match,
+ utils::verify_domains_match,
};
+use activitystreams_kinds::collection::OrderedCollectionType;
+use chrono::NaiveDateTime;
+use futures::future::join_all;
+use lemmy_api_common::utils::generate_outbox_url;
use lemmy_db_schema::{
source::{person::Person, post::Post},
traits::Crud,
+ utils::FETCH_LIMIT_MAX,
};
-use lemmy_utils::LemmyError;
-use serde::{Deserialize, Serialize};
+use lemmy_utils::error::LemmyError;
use url::Url;
-#[derive(Clone, Debug, Deserialize, Serialize)]
-#[serde(rename_all = "camelCase")]
-pub struct GroupOutbox {
- r#type: OrderedCollectionType,
- id: Url,
- total_items: i32,
- ordered_items: Vec<CreateOrUpdatePost>,
-}
-
#[derive(Clone, Debug)]
pub(crate) struct ApubCommunityOutbox(Vec<ApubPost>);
#[async_trait::async_trait(?Send)]
impl ApubObject for ApubCommunityOutbox {
type DataType = CommunityContext;
- type TombstoneType = ();
type ApubType = GroupOutbox;
+ type Error = LemmyError;
+ type DbType = ();
fn last_refreshed_at(&self) -> Option<NaiveDateTime> {
None
}
+ #[tracing::instrument(skip_all)]
async fn read_from_apub_id(
_object_id: Url,
data: &Self::DataType,
// Only read from database if its a local community, otherwise fetch over http
if data.0.local {
let community_id = data.0.id;
- let post_list: Vec<ApubPost> = blocking(data.1.pool(), move |conn| {
- Post::list_for_community(conn, community_id)
- })
- .await??
- .into_iter()
- .map(Into::into)
- .collect();
+ let post_list: Vec<ApubPost> = Post::list_for_community(data.1.pool(), community_id)
+ .await?
+ .into_iter()
+ .map(Into::into)
+ .collect();
Ok(Some(ApubCommunityOutbox(post_list)))
} else {
Ok(None)
}
}
- async fn delete(self, _data: &Self::DataType) -> Result<(), LemmyError> {
- // do nothing (it gets deleted automatically with the community)
- Ok(())
- }
-
- async fn to_apub(&self, data: &Self::DataType) -> Result<Self::ApubType, LemmyError> {
+ #[tracing::instrument(skip_all)]
+ async fn into_apub(self, data: &Self::DataType) -> Result<Self::ApubType, LemmyError> {
let mut ordered_items = vec![];
- for post in &self.0 {
- let actor = post.creator_id;
- let actor: ApubPerson = blocking(data.1.pool(), move |conn| Person::read(conn, actor))
- .await??
- .into();
- let a =
- CreateOrUpdatePost::new(post, &actor, &data.0, CreateOrUpdateType::Create, &data.1).await?;
- ordered_items.push(a);
+ for post in self.0 {
+ let person = Person::read(data.1.pool(), post.creator_id).await?.into();
+ let create =
+ CreateOrUpdatePage::new(post, &person, &data.0, CreateOrUpdateType::Create, &data.1)
+ .await?;
+ let announcable = AnnouncableActivities::CreateOrUpdatePost(create);
+ let announce = AnnounceActivity::new(announcable.try_into()?, &data.0, &data.1)?;
+ ordered_items.push(announce);
}
Ok(GroupOutbox {
})
}
- fn to_tombstone(&self) -> Result<Self::TombstoneType, LemmyError> {
- // no tombstone for this, there is only a tombstone for the community
- unimplemented!()
+ #[tracing::instrument(skip_all)]
+ async fn verify(
+ group_outbox: &GroupOutbox,
+ expected_domain: &Url,
+ _context: &CommunityContext,
+ _request_counter: &mut i32,
+ ) -> Result<(), LemmyError> {
+ verify_domains_match(expected_domain, &group_outbox.id)?;
+ Ok(())
}
+ #[tracing::instrument(skip_all)]
async fn from_apub(
- apub: &Self::ApubType,
+ apub: Self::ApubType,
data: &Self::DataType,
- expected_domain: &Url,
- request_counter: &mut i32,
+ _request_counter: &mut i32,
) -> Result<Self, LemmyError> {
- verify_domains_match(expected_domain, &apub.id)?;
- let mut outbox_activities = apub.ordered_items.clone();
- if outbox_activities.len() > 20 {
- outbox_activities = outbox_activities[0..20].to_vec();
+ let mut outbox_activities = apub.ordered_items;
+ if outbox_activities.len() as i64 > FETCH_LIMIT_MAX {
+ outbox_activities = outbox_activities[0..(FETCH_LIMIT_MAX as usize)].to_vec();
}
// We intentionally ignore errors here. This is because the outbox might contain posts from old
// Lemmy versions, or from other software which we cant parse. In that case, we simply skip the
// item and only parse the ones that work.
- for activity in outbox_activities {
- activity
- .receive(&Data::new(data.1.clone()), request_counter)
- .await
- .ok();
- }
+ let data = Data::new(data.1.clone());
+ // process items in parallel, to avoid long delay from fetch_site_metadata() and other processing
+ join_all(outbox_activities.into_iter().map(|activity| {
+ async {
+ // use separate request counter for each item, otherwise there will be problems with
+ // parallel processing
+ let request_counter = &mut 0;
+ let verify = activity.verify(&data, request_counter).await;
+ if verify.is_ok() {
+ activity.receive(&data, request_counter).await.ok();
+ }
+ }
+ }))
+ .await;
// This return value is unused, so just set an empty vec
- Ok(ApubCommunityOutbox { 0: vec![] })
+ Ok(ApubCommunityOutbox(Vec::new()))
}
}
projects / lemmy.git / blobdiff