use crate::{
- activities::{post::create_or_update::CreateOrUpdatePost, CreateOrUpdateType},
- collections::CommunityContext,
- generate_outbox_url,
- objects::{person::ApubPerson, post::ApubPost},
+ activity_lists::AnnouncableActivities,
+ objects::{community::ApubCommunity, post::ApubPost},
+ protocol::{
+ activities::{
+ community::announce::AnnounceActivity,
+ create_or_update::page::CreateOrUpdatePage,
+ CreateOrUpdateType,
+ },
+ collections::group_outbox::GroupOutbox,
+ },
};
-use activitystreams::collection::kind::OrderedCollectionType;
-use chrono::NaiveDateTime;
-use lemmy_api_common::blocking;
-use lemmy_apub_lib::{
- data::Data,
- traits::{ActivityHandler, ApubObject},
- verify::verify_domains_match,
+use activitypub_federation::{
+ config::Data,
+ kinds::collection::OrderedCollectionType,
+ protocol::verification::verify_domains_match,
+ traits::{ActivityHandler, Collection},
};
+use futures::future::join_all;
+use lemmy_api_common::{context::LemmyContext, utils::generate_outbox_url};
use lemmy_db_schema::{
source::{person::Person, post::Post},
traits::Crud,
+ utils::FETCH_LIMIT_MAX,
};
-use lemmy_utils::LemmyError;
-use serde::{Deserialize, Serialize};
+use lemmy_utils::error::LemmyError;
use url::Url;
-#[derive(Clone, Debug, Deserialize, Serialize)]
-#[serde(rename_all = "camelCase")]
-pub struct GroupOutbox {
- r#type: OrderedCollectionType,
- id: Url,
- total_items: i32,
- ordered_items: Vec<CreateOrUpdatePost>,
-}
-
#[derive(Clone, Debug)]
pub(crate) struct ApubCommunityOutbox(Vec<ApubPost>);
-#[async_trait::async_trait(?Send)]
-impl ApubObject for ApubCommunityOutbox {
- type DataType = CommunityContext;
- type TombstoneType = ();
- type ApubType = GroupOutbox;
-
- fn last_refreshed_at(&self) -> Option<NaiveDateTime> {
- None
- }
+#[async_trait::async_trait]
+impl Collection for ApubCommunityOutbox {
+ type Owner = ApubCommunity;
+ type DataType = LemmyContext;
+ type Kind = GroupOutbox;
+ type Error = LemmyError;
- async fn read_from_apub_id(
- _object_id: Url,
- data: &Self::DataType,
- ) -> Result<Option<Self>, LemmyError> {
- // Only read from database if its a local community, otherwise fetch over http
- if data.0.local {
- let community_id = data.0.id;
- let post_list: Vec<ApubPost> = blocking(data.1.pool(), move |conn| {
- Post::list_for_community(conn, community_id)
- })
- .await??
+ #[tracing::instrument(skip_all)]
+ async fn read_local(
+ owner: &Self::Owner,
+ data: &Data<Self::DataType>,
+ ) -> Result<Self::Kind, LemmyError> {
+ let post_list: Vec<ApubPost> = Post::list_for_community(&mut data.pool(), owner.id)
+ .await?
.into_iter()
.map(Into::into)
.collect();
- Ok(Some(ApubCommunityOutbox(post_list)))
- } else {
- Ok(None)
- }
- }
-
- async fn delete(self, _data: &Self::DataType) -> Result<(), LemmyError> {
- // do nothing (it gets deleted automatically with the community)
- Ok(())
- }
-
- async fn to_apub(&self, data: &Self::DataType) -> Result<Self::ApubType, LemmyError> {
let mut ordered_items = vec![];
- for post in &self.0 {
- let actor = post.creator_id;
- let actor: ApubPerson = blocking(data.1.pool(), move |conn| Person::read(conn, actor))
- .await??
+ for post in post_list {
+ let person = Person::read(&mut data.pool(), post.creator_id)
+ .await?
.into();
- let a =
- CreateOrUpdatePost::new(post, &actor, &data.0, CreateOrUpdateType::Create, &data.1).await?;
- ordered_items.push(a);
+ let create =
+ CreateOrUpdatePage::new(post, &person, owner, CreateOrUpdateType::Create, data).await?;
+ let announcable = AnnouncableActivities::CreateOrUpdatePost(create);
+ let announce = AnnounceActivity::new(announcable.try_into()?, owner, data)?;
+ ordered_items.push(announce);
}
Ok(GroupOutbox {
r#type: OrderedCollectionType::OrderedCollection,
- id: generate_outbox_url(&data.0.actor_id)?.into(),
+ id: generate_outbox_url(&owner.actor_id)?.into(),
total_items: ordered_items.len() as i32,
ordered_items,
})
}
- fn to_tombstone(&self) -> Result<Self::TombstoneType, LemmyError> {
- // no tombstone for this, there is only a tombstone for the community
- unimplemented!()
+ #[tracing::instrument(skip_all)]
+ async fn verify(
+ group_outbox: &GroupOutbox,
+ expected_domain: &Url,
+ _data: &Data<Self::DataType>,
+ ) -> Result<(), LemmyError> {
+ verify_domains_match(expected_domain, &group_outbox.id)?;
+ Ok(())
}
- async fn from_apub(
- apub: &Self::ApubType,
- data: &Self::DataType,
- expected_domain: &Url,
- request_counter: &mut i32,
+ #[tracing::instrument(skip_all)]
+ async fn from_json(
+ apub: Self::Kind,
+ _owner: &Self::Owner,
+ data: &Data<Self::DataType>,
) -> Result<Self, LemmyError> {
- verify_domains_match(expected_domain, &apub.id)?;
- let mut outbox_activities = apub.ordered_items.clone();
- if outbox_activities.len() > 20 {
- outbox_activities = outbox_activities[0..20].to_vec();
+ let mut outbox_activities = apub.ordered_items;
+ if outbox_activities.len() as i64 > FETCH_LIMIT_MAX {
+ outbox_activities = outbox_activities
+ .get(0..(FETCH_LIMIT_MAX as usize))
+ .unwrap_or_default()
+ .to_vec();
}
// We intentionally ignore errors here. This is because the outbox might contain posts from old
// Lemmy versions, or from other software which we cant parse. In that case, we simply skip the
// item and only parse the ones that work.
- for activity in outbox_activities {
- activity
- .receive(&Data::new(data.1.clone()), request_counter)
- .await
- .ok();
- }
+ // process items in parallel, to avoid long delay from fetch_site_metadata() and other processing
+ join_all(outbox_activities.into_iter().map(|activity| {
+ async {
+ // use separate request counter for each item, otherwise there will be problems with
+ // parallel processing
+ let verify = activity.verify(data).await;
+ if verify.is_ok() {
+ activity.receive(data).await.ok();
+ }
+ }
+ }))
+ .await;
// This return value is unused, so just set an empty vec
- Ok(ApubCommunityOutbox { 0: vec![] })
+ Ok(ApubCommunityOutbox(Vec::new()))
}
}
projects / lemmy.git / blobdiff