use crate::{
- extensions::{context::lemmy_context, group_extensions::GroupExtension},
- fetcher::{community::fetch_community_mods, user::get_or_fetch_and_upsert_user},
+ check_is_apub_id_valid,
+ collections::{community_moderators::ApubCommunityModerators, CommunityContext},
generate_moderators_url,
- objects::{
- check_object_domain,
- create_tombstone,
- get_object_from_apub,
- get_source_markdown_value,
- set_content_and_source,
- FromApub,
- FromApubToForm,
- ToApub,
+ generate_outbox_url,
+ objects::instance::fetch_instance_actor_for_object,
+ protocol::{
+ objects::{group::Group, tombstone::Tombstone, Endpoints},
+ ImageObject,
+ Source,
},
- ActorType,
- GroupExt,
};
-use activitystreams::{
- actor::{kind::GroupType, ApActor, Endpoints, Group},
- base::BaseExt,
- object::{ApObject, Image, Tombstone},
- prelude::*,
+use activitystreams_kinds::actor::GroupType;
+use chrono::NaiveDateTime;
+use itertools::Itertools;
+use lemmy_api_common::blocking;
+use lemmy_apub_lib::{
+ object_id::ObjectId,
+ traits::{ActorType, ApubObject},
};
-use activitystreams_ext::Ext2;
-use anyhow::Context;
-use lemmy_api_structs::blocking;
-use lemmy_db_queries::{DbPool, Joinable};
-use lemmy_db_schema::{
- naive_now,
- source::community::{Community, CommunityForm, CommunityModerator, CommunityModeratorForm},
- DbUrl,
-};
-use lemmy_db_views_actor::community_moderator_view::CommunityModeratorView;
+use lemmy_db_schema::{source::community::Community, traits::ApubActor};
+use lemmy_db_views_actor::community_follower_view::CommunityFollowerView;
use lemmy_utils::{
- location_info,
- utils::{check_slurs, check_slurs_opt, convert_datetime},
+ utils::{convert_datetime, markdown_to_html},
LemmyError,
};
use lemmy_websocket::LemmyContext;
+use std::ops::Deref;
+use tracing::debug;
use url::Url;
-#[async_trait::async_trait(?Send)]
-impl ToApub for Community {
- type ApubType = GroupExt;
+#[derive(Clone, Debug)]
+pub struct ApubCommunity(Community);
- async fn to_apub(&self, _pool: &DbPool) -> Result<GroupExt, LemmyError> {
- let mut group = ApObject::new(Group::new());
- group
- .set_many_contexts(lemmy_context()?)
- .set_id(self.actor_id.to_owned().into())
- .set_name(self.title.to_owned())
- .set_published(convert_datetime(self.published));
+impl Deref for ApubCommunity {
+ type Target = Community;
+ fn deref(&self) -> &Self::Target {
+ &self.0
+ }
+}
- if let Some(u) = self.updated.to_owned() {
- group.set_updated(convert_datetime(u));
- }
- if let Some(d) = self.description.to_owned() {
- set_content_and_source(&mut group, &d)?;
- }
+impl From<Community> for ApubCommunity {
+ fn from(c: Community) -> Self {
+ ApubCommunity { 0: c }
+ }
+}
- if let Some(icon_url) = &self.icon {
- let mut image = Image::new();
- image.set_url::<Url>(icon_url.to_owned().into());
- group.set_icon(image.into_any_base()?);
- }
+#[async_trait::async_trait(?Send)]
+impl ApubObject for ApubCommunity {
+ type DataType = LemmyContext;
+ type ApubType = Group;
+ type TombstoneType = Tombstone;
- if let Some(banner_url) = &self.banner {
- let mut image = Image::new();
- image.set_url::<Url>(banner_url.to_owned().into());
- group.set_image(image.into_any_base()?);
- }
+ fn last_refreshed_at(&self) -> Option<NaiveDateTime> {
+ Some(self.last_refreshed_at)
+ }
+
+ #[tracing::instrument(skip_all)]
+ async fn read_from_apub_id(
+ object_id: Url,
+ context: &LemmyContext,
+ ) -> Result<Option<Self>, LemmyError> {
+ Ok(
+ blocking(context.pool(), move |conn| {
+ Community::read_from_apub_id(conn, object_id)
+ })
+ .await??
+ .map(Into::into),
+ )
+ }
- let mut ap_actor = ApActor::new(self.inbox_url.clone().into(), group);
- ap_actor
- .set_preferred_username(self.name.to_owned())
- .set_outbox(self.get_outbox_url()?)
- .set_followers(self.followers_url.clone().into())
- .set_endpoints(Endpoints {
- shared_inbox: Some(self.get_shared_inbox_or_inbox_url()),
- ..Default::default()
- });
+ #[tracing::instrument(skip_all)]
+ async fn delete(self, context: &LemmyContext) -> Result<(), LemmyError> {
+ blocking(context.pool(), move |conn| {
+ Community::update_deleted(conn, self.id, true)
+ })
+ .await??;
+ Ok(())
+ }
- Ok(Ext2::new(
- ap_actor,
- GroupExtension::new(self.nsfw, generate_moderators_url(&self.actor_id)?.into())?,
- self.get_public_key_ext()?,
- ))
+ #[tracing::instrument(skip_all)]
+ async fn into_apub(self, _context: &LemmyContext) -> Result<Group, LemmyError> {
+ let group = Group {
+ kind: GroupType::Group,
+ id: ObjectId::new(self.actor_id()),
+ preferred_username: self.name.clone(),
+ name: self.title.clone(),
+ summary: self.description.as_ref().map(|b| markdown_to_html(b)),
+ source: self.description.clone().map(Source::new),
+ icon: self.icon.clone().map(ImageObject::new),
+ image: self.banner.clone().map(ImageObject::new),
+ sensitive: Some(self.nsfw),
+ moderators: Some(ObjectId::<ApubCommunityModerators>::new(
+ generate_moderators_url(&self.actor_id)?,
+ )),
+ inbox: self.inbox_url.clone().into(),
+ outbox: ObjectId::new(generate_outbox_url(&self.actor_id)?),
+ followers: self.followers_url.clone().into(),
+ endpoints: self.shared_inbox_url.clone().map(|s| Endpoints {
+ shared_inbox: s.into(),
+ }),
+ public_key: self.get_public_key()?,
+ published: Some(convert_datetime(self.published)),
+ updated: self.updated.map(convert_datetime),
+ unparsed: Default::default(),
+ };
+ Ok(group)
}
fn to_tombstone(&self) -> Result<Tombstone, LemmyError> {
- create_tombstone(
- self.deleted,
- self.actor_id.to_owned().into(),
- self.updated,
- GroupType::Group,
- )
+ Ok(Tombstone::new(self.actor_id()))
}
-}
-#[async_trait::async_trait(?Send)]
-impl FromApub for Community {
- type ApubType = GroupExt;
+ #[tracing::instrument(skip_all)]
+ async fn verify(
+ group: &Group,
+ expected_domain: &Url,
+ context: &LemmyContext,
+ _request_counter: &mut i32,
+ ) -> Result<(), LemmyError> {
+ group.verify(expected_domain, context).await
+ }
/// Converts a `Group` to `Community`, inserts it into the database and updates moderators.
+ #[tracing::instrument(skip_all)]
async fn from_apub(
- group: &GroupExt,
+ group: Group,
context: &LemmyContext,
- expected_domain: Url,
request_counter: &mut i32,
- ) -> Result<Community, LemmyError> {
- let community: Community =
- get_object_from_apub(group, context, expected_domain, request_counter).await?;
-
- let new_moderators = fetch_community_mods(context, group, request_counter).await?;
- let community_id = community.id;
- let current_moderators = blocking(context.pool(), move |conn| {
- CommunityModeratorView::for_community(&conn, community_id)
- })
- .await??;
- // Remove old mods from database which arent in the moderators collection anymore
- for mod_user in ¤t_moderators {
- if !new_moderators.contains(&&mod_user.moderator.actor_id.clone().into()) {
- let community_moderator_form = CommunityModeratorForm {
- community_id: mod_user.community.id,
- user_id: mod_user.moderator.id,
- };
- blocking(context.pool(), move |conn| {
- CommunityModerator::leave(conn, &community_moderator_form)
- })
- .await??;
- }
- }
+ ) -> Result<ApubCommunity, LemmyError> {
+ let form = Group::into_form(group.clone());
+
+ // Fetching mods and outbox is not necessary for Lemmy to work, so ignore errors. Besides,
+ // we need to ignore these errors so that tests can work entirely offline.
+ let community: ApubCommunity =
+ blocking(context.pool(), move |conn| Community::upsert(conn, &form))
+ .await??
+ .into();
+ let outbox_data = CommunityContext(community.clone(), context.clone());
- // Add new mods to database which have been added to moderators collection
- for mod_uri in new_moderators {
- let mod_user = get_or_fetch_and_upsert_user(&mod_uri, context, request_counter).await?;
- let current_mod_uris: Vec<DbUrl> = current_moderators
- .clone()
- .iter()
- .map(|c| c.moderator.actor_id.clone())
- .collect();
- if !current_mod_uris.contains(&mod_user.actor_id) {
- let community_moderator_form = CommunityModeratorForm {
- community_id: community.id,
- user_id: mod_user.id,
- };
- blocking(context.pool(), move |conn| {
- CommunityModerator::join(conn, &community_moderator_form)
- })
- .await??;
- }
+ group
+ .outbox
+ .dereference(&outbox_data, context.client(), request_counter)
+ .await
+ .map_err(|e| debug!("{}", e))
+ .ok();
+
+ if let Some(moderators) = &group.moderators {
+ moderators
+ .dereference(&outbox_data, context.client(), request_counter)
+ .await
+ .map_err(|e| debug!("{}", e))
+ .ok();
}
+ fetch_instance_actor_for_object(community.actor_id(), context, request_counter).await;
+
Ok(community)
}
}
-#[async_trait::async_trait(?Send)]
-impl FromApubToForm<GroupExt> for CommunityForm {
- async fn from_apub(
- group: &GroupExt,
+impl ActorType for ApubCommunity {
+ fn actor_id(&self) -> Url {
+ self.actor_id.to_owned().into()
+ }
+ fn public_key(&self) -> String {
+ self.public_key.to_owned()
+ }
+ fn private_key(&self) -> Option<String> {
+ self.private_key.to_owned()
+ }
+
+ fn inbox_url(&self) -> Url {
+ self.inbox_url.clone().into()
+ }
+
+ fn shared_inbox_url(&self) -> Option<Url> {
+ self.shared_inbox_url.clone().map(|s| s.into())
+ }
+}
+
+impl ApubCommunity {
+ /// For a given community, returns the inboxes of all followers.
+ #[tracing::instrument(skip_all)]
+ pub(crate) async fn get_follower_inboxes(
+ &self,
context: &LemmyContext,
- expected_domain: Url,
- request_counter: &mut i32,
- ) -> Result<Self, LemmyError> {
- let moderator_uris = fetch_community_mods(context, group, request_counter).await?;
- let creator_uri = moderator_uris.first().context(location_info!())?;
-
- let creator = get_or_fetch_and_upsert_user(creator_uri, context, request_counter).await?;
- let name = group
- .inner
- .preferred_username()
- .context(location_info!())?
- .to_string();
- let title = group
- .inner
- .name()
- .context(location_info!())?
- .as_one()
- .context(location_info!())?
- .as_xsd_string()
- .context(location_info!())?
- .to_string();
-
- let description = get_source_markdown_value(group)?;
-
- check_slurs(&name)?;
- check_slurs(&title)?;
- check_slurs_opt(&description)?;
-
- let icon = match group.icon() {
- Some(any_image) => Some(
- Image::from_any_base(any_image.as_one().context(location_info!())?.clone())
- .context(location_info!())?
- .context(location_info!())?
- .url()
- .context(location_info!())?
- .as_single_xsd_any_uri()
- .map(|u| u.to_owned().into()),
- ),
- None => None,
- };
- let banner = match group.image() {
- Some(any_image) => Some(
- Image::from_any_base(any_image.as_one().context(location_info!())?.clone())
- .context(location_info!())?
- .context(location_info!())?
- .url()
- .context(location_info!())?
- .as_single_xsd_any_uri()
- .map(|u| u.to_owned().into()),
- ),
- None => None,
- };
- let shared_inbox = group
- .inner
- .endpoints()?
- .map(|e| e.shared_inbox)
- .flatten()
- .map(|s| s.to_owned().into());
-
- Ok(CommunityForm {
- name,
- title,
- description,
- creator_id: creator.id,
- removed: None,
- published: group.inner.published().map(|u| u.to_owned().naive_local()),
- updated: group.inner.updated().map(|u| u.to_owned().naive_local()),
- deleted: None,
- nsfw: group.ext_one.sensitive.unwrap_or(false),
- actor_id: Some(check_object_domain(group, expected_domain)?),
- local: false,
- private_key: None,
- public_key: Some(group.ext_two.to_owned().public_key.public_key_pem),
- last_refreshed_at: Some(naive_now()),
- icon,
- banner,
- followers_url: Some(
- group
- .inner
- .followers()?
- .context(location_info!())?
- .to_owned()
- .into(),
- ),
- inbox_url: Some(group.inner.inbox()?.to_owned().into()),
- shared_inbox_url: Some(shared_inbox),
+ ) -> Result<Vec<Url>, LemmyError> {
+ let id = self.id;
+
+ let follows = blocking(context.pool(), move |conn| {
+ CommunityFollowerView::for_community(conn, id)
})
+ .await??;
+ let inboxes: Vec<Url> = follows
+ .into_iter()
+ .filter(|f| !f.follower.local)
+ .map(|f| {
+ f.follower
+ .shared_inbox_url
+ .unwrap_or(f.follower.inbox_url)
+ .into()
+ })
+ .unique()
+ .filter(|inbox: &Url| inbox.host_str() != Some(&context.settings().hostname))
+ // Don't send to blocked instances
+ .filter(|inbox| check_is_apub_id_valid(inbox, false, &context.settings()).is_ok())
+ .collect();
+
+ Ok(inboxes)
+ }
+}
+
+#[cfg(test)]
+pub(crate) mod tests {
+ use super::*;
+ use crate::objects::{
+ instance::tests::parse_lemmy_instance,
+ tests::{file_to_json_object, init_context},
+ };
+ use lemmy_apub_lib::activity_queue::create_activity_queue;
+ use lemmy_db_schema::{source::site::Site, traits::Crud};
+ use serial_test::serial;
+
+ pub(crate) async fn parse_lemmy_community(context: &LemmyContext) -> ApubCommunity {
+ let mut json: Group = file_to_json_object("assets/lemmy/objects/group.json").unwrap();
+ // change these links so they dont fetch over the network
+ json.moderators = None;
+ json.outbox =
+ ObjectId::new(Url::parse("https://enterprise.lemmy.ml/c/tenforward/not_outbox").unwrap());
+
+ let url = Url::parse("https://enterprise.lemmy.ml/c/tenforward").unwrap();
+ let mut request_counter = 0;
+ ApubCommunity::verify(&json, &url, context, &mut request_counter)
+ .await
+ .unwrap();
+ let community = ApubCommunity::from_apub(json, context, &mut request_counter)
+ .await
+ .unwrap();
+ // this makes one requests to the (intentionally broken) outbox collection
+ assert_eq!(request_counter, 1);
+ community
+ }
+
+ #[actix_rt::test]
+ #[serial]
+ async fn test_parse_lemmy_community() {
+ let client = reqwest::Client::new().into();
+ let manager = create_activity_queue(client);
+ let context = init_context(manager.queue_handle().clone());
+ let site = parse_lemmy_instance(&context).await;
+ let community = parse_lemmy_community(&context).await;
+
+ assert_eq!(community.title, "Ten Forward");
+ assert!(!community.local);
+ assert_eq!(community.description.as_ref().unwrap().len(), 132);
+
+ Community::delete(&*context.pool().get().unwrap(), community.id).unwrap();
+ Site::delete(&*context.pool().get().unwrap(), site.id).unwrap();
}
}