Make functions work with both connection and pool (#3420)

[lemmy.git] / crates / db_schema / src / impls / comment_reply.rs

diff --git a/crates/db_schema/src/impls/comment_reply.rs b/crates/db_schema/src/impls/comment_reply.rs
index 84d6fda5146931ee0e283a686380f45d83091109..c5939334d1931106dbe58d791b6c427963d77d8f 100644 (file)
--- a/crates/db_schema/src/impls/comment_reply.rs
+++ b/crates/db_schema/src/impls/comment_reply.rs
@@ -1,21 +1,32 @@
 use crate::{
   newtypes::{CommentId, CommentReplyId, PersonId},
-  source::comment_reply::*,
+  schema::comment_reply::dsl::{comment_id, comment_reply, read, recipient_id},
+  source::comment_reply::{CommentReply, CommentReplyInsertForm, CommentReplyUpdateForm},
   traits::Crud,
+  utils::{get_conn, DbPool},
 };
-use diesel::{dsl::*, result::Error, *};
+use diesel::{dsl::insert_into, result::Error, ExpressionMethods, QueryDsl};
+use diesel_async::RunQueryDsl;
 
+#[async_trait]
 impl Crud for CommentReply {
   type InsertForm = CommentReplyInsertForm;
   type UpdateForm = CommentReplyUpdateForm;
   type IdType = CommentReplyId;
-  fn read(conn: &mut PgConnection, comment_reply_id: CommentReplyId) -> Result<Self, Error> {
-    use crate::schema::comment_reply::dsl::*;
-    comment_reply.find(comment_reply_id).first::<Self>(conn)
+  async fn read(pool: &mut DbPool<'_>, comment_reply_id: CommentReplyId) -> Result<Self, Error> {
+    let conn = &mut get_conn(pool).await?;
+    comment_reply
+      .find(comment_reply_id)
+      .first::<Self>(conn)
+      .await
   }
 
-  fn create(conn: &mut PgConnection, comment_reply_form: &Self::InsertForm) -> Result<Self, Error> {
-    use crate::schema::comment_reply::dsl::*;
+  async fn create(
+    pool: &mut DbPool<'_>,
+    comment_reply_form: &Self::InsertForm,
+  ) -> Result<Self, Error> {
+    let conn = &mut get_conn(pool).await?;
+
     // since the return here isnt utilized, we dont need to do an update
     // but get_result doesnt return the existing row here
     insert_into(comment_reply)
@@ -24,26 +35,28 @@ impl Crud for CommentReply {
       .do_update()
       .set(comment_reply_form)
       .get_result::<Self>(conn)
+      .await
   }
 
-  fn update(
-    conn: &mut PgConnection,
+  async fn update(
+    pool: &mut DbPool<'_>,
     comment_reply_id: CommentReplyId,
     comment_reply_form: &Self::UpdateForm,
   ) -> Result<Self, Error> {
-    use crate::schema::comment_reply::dsl::*;
+    let conn = &mut get_conn(pool).await?;
     diesel::update(comment_reply.find(comment_reply_id))
       .set(comment_reply_form)
       .get_result::<Self>(conn)
+      .await
   }
 }
 
 impl CommentReply {
-  pub fn mark_all_as_read(
-    conn: &mut PgConnection,
+  pub async fn mark_all_as_read(
+    pool: &mut DbPool<'_>,
     for_recipient_id: PersonId,
   ) -> Result<Vec<CommentReply>, Error> {
-    use crate::schema::comment_reply::dsl::*;
+    let conn = &mut get_conn(pool).await?;
     diesel::update(
       comment_reply
         .filter(recipient_id.eq(for_recipient_id))
@@ -51,16 +64,18 @@ impl CommentReply {
     )
     .set(read.eq(true))
     .get_results::<Self>(conn)
+    .await
   }
 
-  pub fn read_by_comment(
-    conn: &mut PgConnection,
+  pub async fn read_by_comment(
+    pool: &mut DbPool<'_>,
     for_comment_id: CommentId,
   ) -> Result<Self, Error> {
-    use crate::schema::comment_reply::dsl::*;
+    let conn = &mut get_conn(pool).await?;
     comment_reply
       .filter(comment_id.eq(for_comment_id))
       .first::<Self>(conn)
+      .await
   }
 }
 
@@ -68,24 +83,27 @@ impl CommentReply {
 mod tests {
   use crate::{
     source::{
-      comment::*,
-      comment_reply::*,
+      comment::{Comment, CommentInsertForm},
+      comment_reply::{CommentReply, CommentReplyInsertForm, CommentReplyUpdateForm},
       community::{Community, CommunityInsertForm},
       instance::Instance,
-      person::*,
-      post::*,
+      person::{Person, PersonInsertForm},
+      post::{Post, PostInsertForm},
     },
     traits::Crud,
-    utils::establish_unpooled_connection,
+    utils::build_db_pool_for_tests,
   };
   use serial_test::serial;
 
-  #[test]
+  #[tokio::test]
   #[serial]
-  fn test_crud() {
-    let conn = &mut establish_unpooled_connection();
+  async fn test_crud() {
+    let pool = &build_db_pool_for_tests().await;
+    let pool = &mut pool.into();
 
-    let inserted_instance = Instance::create(conn, "my_domain.tld").unwrap();
+    let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string())
+      .await
+      .unwrap();
 
     let new_person = PersonInsertForm::builder()
       .name("terrylake".into())
@@ -93,7 +111,7 @@ mod tests {
       .instance_id(inserted_instance.id)
       .build();
 
-    let inserted_person = Person::create(conn, &new_person).unwrap();
+    let inserted_person = Person::create(pool, &new_person).await.unwrap();
 
     let recipient_form = PersonInsertForm::builder()
       .name("terrylakes recipient".into())
@@ -101,7 +119,7 @@ mod tests {
       .instance_id(inserted_instance.id)
       .build();
 
-    let inserted_recipient = Person::create(conn, &recipient_form).unwrap();
+    let inserted_recipient = Person::create(pool, &recipient_form).await.unwrap();
 
     let new_community = CommunityInsertForm::builder()
       .name("test community lake".to_string())
@@ -110,7 +128,7 @@ mod tests {
       .instance_id(inserted_instance.id)
       .build();
 
-    let inserted_community = Community::create(conn, &new_community).unwrap();
+    let inserted_community = Community::create(pool, &new_community).await.unwrap();
 
     let new_post = PostInsertForm::builder()
       .name("A test post".into())
@@ -118,7 +136,7 @@ mod tests {
       .community_id(inserted_community.id)
       .build();
 
-    let inserted_post = Post::create(conn, &new_post).unwrap();
+    let inserted_post = Post::create(pool, &new_post).await.unwrap();
 
     let comment_form = CommentInsertForm::builder()
       .content("A test comment".into())
@@ -126,7 +144,7 @@ mod tests {
       .post_id(inserted_post.id)
       .build();
 
-    let inserted_comment = Comment::create(conn, &comment_form, None).unwrap();
+    let inserted_comment = Comment::create(pool, &comment_form, None).await.unwrap();
 
     let comment_reply_form = CommentReplyInsertForm {
       recipient_id: inserted_recipient.id,
@@ -134,7 +152,9 @@ mod tests {
       read: None,
     };
 
-    let inserted_reply = CommentReply::create(conn, &comment_reply_form).unwrap();
+    let inserted_reply = CommentReply::create(pool, &comment_reply_form)
+      .await
+      .unwrap();
 
     let expected_reply = CommentReply {
       id: inserted_reply.id,
@@ -144,18 +164,21 @@ mod tests {
       published: inserted_reply.published,
     };
 
-    let read_reply = CommentReply::read(conn, inserted_reply.id).unwrap();
+    let read_reply = CommentReply::read(pool, inserted_reply.id).await.unwrap();
 
     let comment_reply_update_form = CommentReplyUpdateForm { read: Some(false) };
-    let updated_reply =
-      CommentReply::update(conn, inserted_reply.id, &comment_reply_update_form).unwrap();
-
-    Comment::delete(conn, inserted_comment.id).unwrap();
-    Post::delete(conn, inserted_post.id).unwrap();
-    Community::delete(conn, inserted_community.id).unwrap();
-    Person::delete(conn, inserted_person.id).unwrap();
-    Person::delete(conn, inserted_recipient.id).unwrap();
-    Instance::delete(conn, inserted_instance.id).unwrap();
+    let updated_reply = CommentReply::update(pool, inserted_reply.id, &comment_reply_update_form)
+      .await
+      .unwrap();
+
+    Comment::delete(pool, inserted_comment.id).await.unwrap();
+    Post::delete(pool, inserted_post.id).await.unwrap();
+    Community::delete(pool, inserted_community.id)
+      .await
+      .unwrap();
+    Person::delete(pool, inserted_person.id).await.unwrap();
+    Person::delete(pool, inserted_recipient.id).await.unwrap();
+    Instance::delete(pool, inserted_instance.id).await.unwrap();
 
     assert_eq!(expected_reply, read_reply);
     assert_eq!(expected_reply, inserted_reply);