use crate::{
newtypes::{CommentId, PersonId, PersonMentionId},
- schema::person_mention::dsl::*,
- source::person_mention::*,
+ schema::person_mention::dsl::{comment_id, person_mention, read, recipient_id},
+ source::person_mention::{PersonMention, PersonMentionInsertForm, PersonMentionUpdateForm},
traits::Crud,
utils::{get_conn, DbPool},
};
-use diesel::{dsl::*, result::Error, *};
+use diesel::{dsl::insert_into, result::Error, ExpressionMethods, QueryDsl};
use diesel_async::RunQueryDsl;
#[async_trait]
type InsertForm = PersonMentionInsertForm;
type UpdateForm = PersonMentionUpdateForm;
type IdType = PersonMentionId;
- async fn read(pool: &DbPool, person_mention_id: PersonMentionId) -> Result<Self, Error> {
+ async fn read(pool: &mut DbPool<'_>, person_mention_id: PersonMentionId) -> Result<Self, Error> {
let conn = &mut get_conn(pool).await?;
person_mention
.find(person_mention_id)
.await
}
- async fn create(pool: &DbPool, person_mention_form: &Self::InsertForm) -> Result<Self, Error> {
+ async fn create(
+ pool: &mut DbPool<'_>,
+ person_mention_form: &Self::InsertForm,
+ ) -> Result<Self, Error> {
let conn = &mut get_conn(pool).await?;
// since the return here isnt utilized, we dont need to do an update
// but get_result doesnt return the existing row here
}
async fn update(
- pool: &DbPool,
+ pool: &mut DbPool<'_>,
person_mention_id: PersonMentionId,
person_mention_form: &Self::UpdateForm,
) -> Result<Self, Error> {
impl PersonMention {
pub async fn mark_all_as_read(
- pool: &DbPool,
+ pool: &mut DbPool<'_>,
for_recipient_id: PersonId,
) -> Result<Vec<PersonMention>, Error> {
let conn = &mut get_conn(pool).await?;
}
pub async fn read_by_comment_and_person(
- pool: &DbPool,
+ pool: &mut DbPool<'_>,
for_comment_id: CommentId,
for_recipient_id: PersonId,
) -> Result<Self, Error> {
#[cfg(test)]
mod tests {
+ #![allow(clippy::unwrap_used)]
+ #![allow(clippy::indexing_slicing)]
+
use crate::{
source::{
- comment::*,
+ comment::{Comment, CommentInsertForm},
community::{Community, CommunityInsertForm},
instance::Instance,
- person::*,
- person_mention::*,
- post::*,
+ person::{Person, PersonInsertForm},
+ person_mention::{PersonMention, PersonMentionInsertForm, PersonMentionUpdateForm},
+ post::{Post, PostInsertForm},
},
traits::Crud,
utils::build_db_pool_for_tests,
#[serial]
async fn test_crud() {
let pool = &build_db_pool_for_tests().await;
+ let pool = &mut pool.into();
- let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap();
+ let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string())
+ .await
+ .unwrap();
let new_person = PersonInsertForm::builder()
.name("terrylake".into())