use crate::{
newtypes::{CommunityId, DbUrl, PersonId},
- utils::DbPool,
+ utils::{get_conn, DbPool},
};
-use diesel::result::Error;
+use diesel::{
+ associations::HasTable,
+ dsl,
+ query_builder::{DeleteStatement, IntoUpdateTarget},
+ query_dsl::methods::{FindDsl, LimitDsl},
+ result::Error,
+ Table,
+};
+use diesel_async::{
+ methods::{ExecuteDsl, LoadQuery},
+ AsyncPgConnection,
+ RunQueryDsl,
+};
+
+/// Returned by `diesel::delete`
+pub type Delete<T> = DeleteStatement<<T as HasTable>::Table, <T as IntoUpdateTarget>::WhereClause>;
+
+/// Returned by `Self::table().find(id)`
+pub type Find<T> = dsl::Find<<T as HasTable>::Table, <T as Crud>::IdType>;
+pub type PrimaryKey<T> = <<T as HasTable>::Table as Table>::PrimaryKey;
+
+// Trying to create default implementations for `create` and `update` results in a lifetime mess and weird compile errors.
+// https://github.com/rust-lang/rust/issues/102211
#[async_trait]
-pub trait Crud {
+pub trait Crud: HasTable + Sized
+where
+ Self::Table: FindDsl<Self::IdType>,
+ Find<Self>: LimitDsl + IntoUpdateTarget + Send,
+ Delete<Find<Self>>: ExecuteDsl<AsyncPgConnection> + Send + 'static,
+
+ // Used by `RunQueryDsl::first`
+ dsl::Limit<Find<Self>>: LoadQuery<'static, AsyncPgConnection, Self> + Send + 'static,
+{
type InsertForm;
type UpdateForm;
- type IdType;
- async fn create(pool: &DbPool, form: &Self::InsertForm) -> Result<Self, Error>
- where
- Self: Sized;
- async fn read(pool: &DbPool, id: Self::IdType) -> Result<Self, Error>
- where
- Self: Sized;
+ type IdType: Send;
+
+ async fn create(pool: &mut DbPool<'_>, form: &Self::InsertForm) -> Result<Self, Error>;
+
+ async fn read(pool: &mut DbPool<'_>, id: Self::IdType) -> Result<Self, Error> {
+ let query: Find<Self> = Self::table().find(id);
+ let conn = &mut *get_conn(pool).await?;
+ query.first::<Self>(conn).await
+ }
+
/// when you want to null out a column, you have to send Some(None)), since sending None means you just don't want to update that column.
- async fn update(pool: &DbPool, id: Self::IdType, form: &Self::UpdateForm) -> Result<Self, Error>
- where
- Self: Sized;
- async fn delete(_pool: &DbPool, _id: Self::IdType) -> Result<usize, Error>
- where
- Self: Sized,
- Self::IdType: Send,
- {
- async { Err(Error::NotFound) }.await
+ async fn update(
+ pool: &mut DbPool<'_>,
+ id: Self::IdType,
+ form: &Self::UpdateForm,
+ ) -> Result<Self, Error>;
+
+ async fn delete(pool: &mut DbPool<'_>, id: Self::IdType) -> Result<usize, Error> {
+ let query: Delete<Find<Self>> = diesel::delete(Self::table().find(id));
+ let conn = &mut *get_conn(pool).await?;
+ query.execute(conn).await
}
}
#[async_trait]
pub trait Followable {
type Form;
- async fn follow(pool: &DbPool, form: &Self::Form) -> Result<Self, Error>
+ async fn follow(pool: &mut DbPool<'_>, form: &Self::Form) -> Result<Self, Error>
where
Self: Sized;
async fn follow_accepted(
- pool: &DbPool,
+ pool: &mut DbPool<'_>,
community_id: CommunityId,
person_id: PersonId,
) -> Result<Self, Error>
where
Self: Sized;
- async fn unfollow(pool: &DbPool, form: &Self::Form) -> Result<usize, Error>
+ async fn unfollow(pool: &mut DbPool<'_>, form: &Self::Form) -> Result<usize, Error>
where
Self: Sized;
- async fn has_local_followers(pool: &DbPool, community_id: CommunityId) -> Result<bool, Error>;
}
#[async_trait]
pub trait Joinable {
type Form;
- async fn join(pool: &DbPool, form: &Self::Form) -> Result<Self, Error>
+ async fn join(pool: &mut DbPool<'_>, form: &Self::Form) -> Result<Self, Error>
where
Self: Sized;
- async fn leave(pool: &DbPool, form: &Self::Form) -> Result<usize, Error>
+ async fn leave(pool: &mut DbPool<'_>, form: &Self::Form) -> Result<usize, Error>
where
Self: Sized;
}
pub trait Likeable {
type Form;
type IdType;
- async fn like(pool: &DbPool, form: &Self::Form) -> Result<Self, Error>
+ async fn like(pool: &mut DbPool<'_>, form: &Self::Form) -> Result<Self, Error>
where
Self: Sized;
async fn remove(
- pool: &DbPool,
+ pool: &mut DbPool<'_>,
person_id: PersonId,
item_id: Self::IdType,
) -> Result<usize, Error>
#[async_trait]
pub trait Bannable {
type Form;
- async fn ban(pool: &DbPool, form: &Self::Form) -> Result<Self, Error>
+ async fn ban(pool: &mut DbPool<'_>, form: &Self::Form) -> Result<Self, Error>
where
Self: Sized;
- async fn unban(pool: &DbPool, form: &Self::Form) -> Result<usize, Error>
+ async fn unban(pool: &mut DbPool<'_>, form: &Self::Form) -> Result<usize, Error>
where
Self: Sized;
}
#[async_trait]
pub trait Saveable {
type Form;
- async fn save(pool: &DbPool, form: &Self::Form) -> Result<Self, Error>
+ async fn save(pool: &mut DbPool<'_>, form: &Self::Form) -> Result<Self, Error>
where
Self: Sized;
- async fn unsave(pool: &DbPool, form: &Self::Form) -> Result<usize, Error>
+ async fn unsave(pool: &mut DbPool<'_>, form: &Self::Form) -> Result<usize, Error>
where
Self: Sized;
}
#[async_trait]
pub trait Blockable {
type Form;
- async fn block(pool: &DbPool, form: &Self::Form) -> Result<Self, Error>
+ async fn block(pool: &mut DbPool<'_>, form: &Self::Form) -> Result<Self, Error>
where
Self: Sized;
- async fn unblock(pool: &DbPool, form: &Self::Form) -> Result<usize, Error>
+ async fn unblock(pool: &mut DbPool<'_>, form: &Self::Form) -> Result<usize, Error>
where
Self: Sized;
}
#[async_trait]
pub trait Readable {
type Form;
- async fn mark_as_read(pool: &DbPool, form: &Self::Form) -> Result<Self, Error>
+ async fn mark_as_read(pool: &mut DbPool<'_>, form: &Self::Form) -> Result<Self, Error>
where
Self: Sized;
- async fn mark_as_unread(pool: &DbPool, form: &Self::Form) -> Result<usize, Error>
+ async fn mark_as_unread(pool: &mut DbPool<'_>, form: &Self::Form) -> Result<usize, Error>
where
Self: Sized;
}
pub trait Reportable {
type Form;
type IdType;
- async fn report(pool: &DbPool, form: &Self::Form) -> Result<Self, Error>
+ type ObjectIdType;
+ async fn report(pool: &mut DbPool<'_>, form: &Self::Form) -> Result<Self, Error>
where
Self: Sized;
async fn resolve(
- pool: &DbPool,
+ pool: &mut DbPool<'_>,
report_id: Self::IdType,
resolver_id: PersonId,
) -> Result<usize, Error>
+ where
+ Self: Sized;
+ async fn resolve_all_for_object(
+ pool: &mut DbPool<'_>,
+ comment_id_: Self::ObjectIdType,
+ by_resolver_id: PersonId,
+ ) -> Result<usize, Error>
where
Self: Sized;
async fn unresolve(
- pool: &DbPool,
+ pool: &mut DbPool<'_>,
report_id: Self::IdType,
resolver_id: PersonId,
) -> Result<usize, Error>
Self: Sized;
}
-// TODO these should be removed, there should be another way to do this
-pub trait DeleteableOrRemoveable {
- fn blank_out_deleted_or_removed_info(self) -> Self;
-}
-
-pub trait ToSafe {
- type SafeColumns;
- fn safe_columns_tuple() -> Self::SafeColumns;
-}
-
-pub trait ToSafeSettings {
- type SafeSettingsColumns;
- fn safe_settings_columns_tuple() -> Self::SafeSettingsColumns;
-}
-
-pub trait ViewToVec {
- type DbTuple;
- fn from_tuple_to_vec(tuple: Vec<Self::DbTuple>) -> Vec<Self>
+pub trait JoinView {
+ type JoinTuple;
+ fn from_tuple(tuple: Self::JoinTuple) -> Self
where
Self: Sized;
}
#[async_trait]
pub trait ApubActor {
- // TODO: this should be in a trait ApubObject (and implemented for Post, Comment, PrivateMessage as well)
- async fn read_from_apub_id(pool: &DbPool, object_id: &DbUrl) -> Result<Option<Self>, Error>
+ async fn read_from_apub_id(
+ pool: &mut DbPool<'_>,
+ object_id: &DbUrl,
+ ) -> Result<Option<Self>, Error>
where
Self: Sized;
/// - actor_name is the name of the community or user to read.
/// - include_deleted, if true, will return communities or users that were deleted/removed
async fn read_from_name(
- pool: &DbPool,
+ pool: &mut DbPool<'_>,
actor_name: &str,
include_deleted: bool,
) -> Result<Self, Error>
where
Self: Sized;
async fn read_from_name_and_domain(
- pool: &DbPool,
+ pool: &mut DbPool<'_>,
actor_name: &str,
protocol_domain: &str,
) -> Result<Self, Error>