diesel::Connection,
diesel_migrations::MigrationHarness,
newtypes::DbUrl,
+ traits::JoinView,
CommentSortType,
+ PersonSortType,
SortType,
};
use activitypub_federation::{fetch::object_id::ObjectId, traits::Object};
backend::Backend,
deserialize::FromSql,
pg::Pg,
- result::{Error as DieselError, Error::QueryBuilderError},
+ result::{ConnectionError, ConnectionResult, Error as DieselError, Error::QueryBuilderError},
serialize::{Output, ToSql},
sql_types::Text,
PgConnection,
},
};
use diesel_migrations::EmbeddedMigrations;
-use lemmy_utils::{error::LemmyError, settings::structs::Settings};
+use futures_util::{future::BoxFuture, Future, FutureExt};
+use lemmy_utils::{
+ error::{LemmyError, LemmyErrorExt, LemmyErrorType},
+ settings::structs::Settings,
+};
use once_cell::sync::Lazy;
use regex::Regex;
-use std::{env, env::VarError, time::Duration};
-use tracing::info;
+use rustls::{
+ client::{ServerCertVerified, ServerCertVerifier},
+ ServerName,
+};
+use std::{
+ env,
+ env::VarError,
+ ops::{Deref, DerefMut},
+ sync::Arc,
+ time::{Duration, SystemTime},
+};
+use tracing::{error, info};
use url::Url;
const FETCH_LIMIT_DEFAULT: i64 = 10;
pub const FETCH_LIMIT_MAX: i64 = 50;
const POOL_TIMEOUT: Option<Duration> = Some(Duration::from_secs(5));
-pub type DbPool = Pool<AsyncPgConnection>;
+pub type ActualDbPool = Pool<AsyncPgConnection>;
+
+/// References a pool or connection. Functions must take `&mut DbPool<'_>` to allow implicit reborrowing.
+///
+/// https://github.com/rust-lang/rfcs/issues/1403
+pub enum DbPool<'a> {
+ Pool(&'a ActualDbPool),
+ Conn(&'a mut AsyncPgConnection),
+}
+
+pub enum DbConn<'a> {
+ Pool(PooledConnection<AsyncPgConnection>),
+ Conn(&'a mut AsyncPgConnection),
+}
+
+pub async fn get_conn<'a, 'b: 'a>(pool: &'a mut DbPool<'b>) -> Result<DbConn<'a>, DieselError> {
+ Ok(match pool {
+ DbPool::Pool(pool) => DbConn::Pool(pool.get().await.map_err(|e| QueryBuilderError(e.into()))?),
+ DbPool::Conn(conn) => DbConn::Conn(conn),
+ })
+}
+
+impl<'a> Deref for DbConn<'a> {
+ type Target = AsyncPgConnection;
+
+ fn deref(&self) -> &Self::Target {
+ match self {
+ DbConn::Pool(conn) => conn.deref(),
+ DbConn::Conn(conn) => conn.deref(),
+ }
+ }
+}
+
+impl<'a> DerefMut for DbConn<'a> {
+ fn deref_mut(&mut self) -> &mut Self::Target {
+ match self {
+ DbConn::Pool(conn) => conn.deref_mut(),
+ DbConn::Conn(conn) => conn.deref_mut(),
+ }
+ }
+}
+
+// Allows functions that take `DbPool<'_>` to be called in a transaction by passing `&mut conn.into()`
+impl<'a> From<&'a mut AsyncPgConnection> for DbPool<'a> {
+ fn from(value: &'a mut AsyncPgConnection) -> Self {
+ DbPool::Conn(value)
+ }
+}
+
+impl<'a, 'b: 'a> From<&'a mut DbConn<'b>> for DbPool<'a> {
+ fn from(value: &'a mut DbConn<'b>) -> Self {
+ DbPool::Conn(value.deref_mut())
+ }
+}
+
+impl<'a> From<&'a ActualDbPool> for DbPool<'a> {
+ fn from(value: &'a ActualDbPool) -> Self {
+ DbPool::Pool(value)
+ }
+}
-pub async fn get_conn(pool: &DbPool) -> Result<PooledConnection<AsyncPgConnection>, DieselError> {
- pool.get().await.map_err(|e| QueryBuilderError(e.into()))
+/// Runs multiple async functions that take `&mut DbPool<'_>` as input and return `Result`. Only works when the `futures` crate is listed in `Cargo.toml`.
+///
+/// `$pool` is the value given to each function.
+///
+/// A `Result` is returned (not in a `Future`, so don't use `.await`). The `Ok` variant contains a tuple with the values returned by the given functions.
+///
+/// The functions run concurrently if `$pool` has the `DbPool::Pool` variant.
+#[macro_export]
+macro_rules! try_join_with_pool {
+ ($pool:ident => ($($func:expr),+)) => {{
+ // Check type
+ let _: &mut $crate::utils::DbPool<'_> = $pool;
+
+ match $pool {
+ // Run concurrently with `try_join`
+ $crate::utils::DbPool::Pool(__pool) => ::futures::try_join!(
+ $(async {
+ let mut __dbpool = $crate::utils::DbPool::Pool(__pool);
+ ($func)(&mut __dbpool).await
+ }),+
+ ),
+ // Run sequentially
+ $crate::utils::DbPool::Conn(__conn) => async {
+ Ok(($({
+ let mut __dbpool = $crate::utils::DbPool::Conn(__conn);
+ // `?` prevents the error type from being inferred in an `async` block, so `match` is used instead
+ match ($func)(&mut __dbpool).await {
+ ::core::result::Result::Ok(__v) => __v,
+ ::core::result::Result::Err(__v) => return ::core::result::Result::Err(__v),
+ }
+ }),+))
+ }.await,
+ }
+ }};
}
pub fn get_database_url_from_env() -> Result<String, VarError> {
EMAIL_REGEX.is_match(test)
}
-pub fn diesel_option_overwrite(opt: &Option<String>) -> Option<Option<String>> {
+pub fn diesel_option_overwrite(opt: Option<String>) -> Option<Option<String>> {
match opt {
// An empty string is an erase
Some(unwrapped) => {
if !unwrapped.eq("") {
- Some(Some(unwrapped.clone()))
+ Some(Some(unwrapped))
} else {
Some(None)
}
pub fn diesel_option_overwrite_to_url(
opt: &Option<String>,
) -> Result<Option<Option<DbUrl>>, LemmyError> {
- match opt.as_ref().map(std::string::String::as_str) {
+ match opt.as_ref().map(String::as_str) {
// An empty string is an erase
Some("") => Ok(Some(None)),
- Some(str_url) => match Url::parse(str_url) {
- Ok(url) => Ok(Some(Some(url.into()))),
- Err(e) => Err(LemmyError::from_error_message(e, "invalid_url")),
- },
+ Some(str_url) => Url::parse(str_url)
+ .map(|u| Some(Some(u.into())))
+ .with_lemmy_type(LemmyErrorType::InvalidUrl),
None => Ok(None),
}
}
pub fn diesel_option_overwrite_to_url_create(
opt: &Option<String>,
) -> Result<Option<DbUrl>, LemmyError> {
- match opt.as_ref().map(std::string::String::as_str) {
+ match opt.as_ref().map(String::as_str) {
// An empty string is nothing
Some("") => Ok(None),
- Some(str_url) => match Url::parse(str_url) {
- Ok(url) => Ok(Some(url.into())),
- Err(e) => Err(LemmyError::from_error_message(e, "invalid_url")),
- },
+ Some(str_url) => Url::parse(str_url)
+ .map(|u| Some(u.into()))
+ .with_lemmy_type(LemmyErrorType::InvalidUrl),
None => Ok(None),
}
}
-async fn build_db_pool_settings_opt(settings: Option<&Settings>) -> Result<DbPool, LemmyError> {
+async fn build_db_pool_settings_opt(
+ settings: Option<&Settings>,
+) -> Result<ActualDbPool, LemmyError> {
let db_url = get_database_url(settings);
let pool_size = settings.map(|s| s.database.pool_size).unwrap_or(5);
- let manager = AsyncDieselConnectionManager::<AsyncPgConnection>::new(&db_url);
+ // We only support TLS with sslmode=require currently
+ let tls_enabled = db_url.contains("sslmode=require");
+ let manager = if tls_enabled {
+ // diesel-async does not support any TLS connections out of the box, so we need to manually
+ // provide a setup function which handles creating the connection
+ AsyncDieselConnectionManager::<AsyncPgConnection>::new_with_setup(&db_url, establish_connection)
+ } else {
+ AsyncDieselConnectionManager::<AsyncPgConnection>::new(&db_url)
+ };
let pool = Pool::builder(manager)
.max_size(pool_size)
.wait_timeout(POOL_TIMEOUT)
Ok(pool)
}
+fn establish_connection(config: &str) -> BoxFuture<ConnectionResult<AsyncPgConnection>> {
+ let fut = async {
+ let rustls_config = rustls::ClientConfig::builder()
+ .with_safe_defaults()
+ .with_custom_certificate_verifier(Arc::new(NoCertVerifier {}))
+ .with_no_client_auth();
+
+ let tls = tokio_postgres_rustls::MakeRustlsConnect::new(rustls_config);
+ let (client, conn) = tokio_postgres::connect(config, tls)
+ .await
+ .map_err(|e| ConnectionError::BadConnection(e.to_string()))?;
+ tokio::spawn(async move {
+ if let Err(e) = conn.await {
+ error!("Database connection failed: {e}");
+ }
+ });
+ AsyncPgConnection::try_from(client).await
+ };
+ fut.boxed()
+}
+
+struct NoCertVerifier {}
+
+impl ServerCertVerifier for NoCertVerifier {
+ fn verify_server_cert(
+ &self,
+ _end_entity: &rustls::Certificate,
+ _intermediates: &[rustls::Certificate],
+ _server_name: &ServerName,
+ _scts: &mut dyn Iterator<Item = &[u8]>,
+ _ocsp_response: &[u8],
+ _now: SystemTime,
+ ) -> Result<ServerCertVerified, rustls::Error> {
+ // Will verify all (even invalid) certs without any checks (sslmode=require)
+ Ok(ServerCertVerified::assertion())
+ }
+}
+
pub const MIGRATIONS: EmbeddedMigrations = embed_migrations!();
pub fn run_migrations(db_url: &str) {
info!("Database migrations complete.");
}
-pub async fn build_db_pool(settings: &Settings) -> Result<DbPool, LemmyError> {
+pub async fn build_db_pool(settings: &Settings) -> Result<ActualDbPool, LemmyError> {
build_db_pool_settings_opt(Some(settings)).await
}
-pub async fn build_db_pool_for_tests() -> DbPool {
+pub async fn build_db_pool_for_tests() -> ActualDbPool {
build_db_pool_settings_opt(None)
.await
.expect("db pool missing")
SortType::Active | SortType::Hot => CommentSortType::Hot,
SortType::New | SortType::NewComments | SortType::MostComments => CommentSortType::New,
SortType::Old => CommentSortType::Old,
+ SortType::Controversial => CommentSortType::Controversial,
SortType::TopHour
| SortType::TopSixHour
| SortType::TopTwelveHour
| SortType::TopAll
| SortType::TopWeek
| SortType::TopYear
- | SortType::TopMonth => CommentSortType::Top,
+ | SortType::TopMonth
+ | SortType::TopThreeMonths
+ | SortType::TopSixMonths
+ | SortType::TopNineMonths => CommentSortType::Top,
+ }
+}
+
+pub fn post_to_person_sort_type(sort: SortType) -> PersonSortType {
+ match sort {
+ SortType::Active | SortType::Hot | SortType::Controversial => PersonSortType::CommentScore,
+ SortType::New | SortType::NewComments => PersonSortType::New,
+ SortType::MostComments => PersonSortType::MostComments,
+ SortType::Old => PersonSortType::Old,
+ _ => PersonSortType::CommentScore,
}
}
fn hot_rank(score: BigInt, time: Timestamp) -> Integer;
}
+ sql_function! {
+ fn controversy_rank(upvotes: BigInt, downvotes: BigInt, score: BigInt) -> Double;
+ }
+
sql_function!(fn lower(x: Text) -> Text);
}
pub const DELETED_REPLACEMENT_TEXT: &str = "*Permanently Deleted*";
-pub const DELETED_REPLACEMENT_URL: &str = "https://join-lemmy.org/";
impl ToSql<Text, Pg> for DbUrl {
fn to_sql(&self, out: &mut Output<Pg>) -> diesel::serialize::Result {
}
}
+pub type ResultFuture<'a, T> = BoxFuture<'a, Result<T, DieselError>>;
+
+pub trait ReadFn<'a, T: JoinView, Args>:
+ Fn(DbConn<'a>, Args) -> ResultFuture<'a, <T as JoinView>::JoinTuple>
+{
+}
+
+impl<
+ 'a,
+ T: JoinView,
+ Args,
+ F: Fn(DbConn<'a>, Args) -> ResultFuture<'a, <T as JoinView>::JoinTuple>,
+ > ReadFn<'a, T, Args> for F
+{
+}
+
+pub trait ListFn<'a, T: JoinView, Args>:
+ Fn(DbConn<'a>, Args) -> ResultFuture<'a, Vec<<T as JoinView>::JoinTuple>>
+{
+}
+
+impl<
+ 'a,
+ T: JoinView,
+ Args,
+ F: Fn(DbConn<'a>, Args) -> ResultFuture<'a, Vec<<T as JoinView>::JoinTuple>>,
+ > ListFn<'a, T, Args> for F
+{
+}
+
+/// Allows read and list functions to capture a shared closure that has an inferred return type, which is useful for join logic
+pub struct Queries<RF, LF> {
+ pub read_fn: RF,
+ pub list_fn: LF,
+}
+
+// `()` is used to prevent type inference error
+impl Queries<(), ()> {
+ pub fn new<'a, RFut, LFut, RT, LT, RA, LA, RF2, LF2>(
+ read_fn: RF2,
+ list_fn: LF2,
+ ) -> Queries<impl ReadFn<'a, RT, RA>, impl ListFn<'a, LT, LA>>
+ where
+ RFut: Future<Output = Result<<RT as JoinView>::JoinTuple, DieselError>> + Sized + Send + 'a,
+ LFut:
+ Future<Output = Result<Vec<<LT as JoinView>::JoinTuple>, DieselError>> + Sized + Send + 'a,
+ RT: JoinView,
+ LT: JoinView,
+ RF2: Fn(DbConn<'a>, RA) -> RFut,
+ LF2: Fn(DbConn<'a>, LA) -> LFut,
+ {
+ Queries {
+ read_fn: move |conn, args| read_fn(conn, args).boxed(),
+ list_fn: move |conn, args| list_fn(conn, args).boxed(),
+ }
+ }
+}
+
+impl<RF, LF> Queries<RF, LF> {
+ pub async fn read<'a, T, Args>(
+ self,
+ pool: &'a mut DbPool<'_>,
+ args: Args,
+ ) -> Result<T, DieselError>
+ where
+ T: JoinView,
+ RF: ReadFn<'a, T, Args>,
+ {
+ let conn = get_conn(pool).await?;
+ let res = (self.read_fn)(conn, args).await?;
+ Ok(T::from_tuple(res))
+ }
+
+ pub async fn list<'a, T, Args>(
+ self,
+ pool: &'a mut DbPool<'_>,
+ args: Args,
+ ) -> Result<Vec<T>, DieselError>
+ where
+ T: JoinView,
+ LF: ListFn<'a, T, Args>,
+ {
+ let conn = get_conn(pool).await?;
+ let res = (self.list_fn)(conn, args).await?;
+ Ok(res.into_iter().map(T::from_tuple).collect())
+ }
+}
+
#[cfg(test)]
mod tests {
+ #![allow(clippy::unwrap_used)]
+ #![allow(clippy::indexing_slicing)]
+
use super::{fuzzy_search, *};
use crate::utils::is_email_regex;
#[test]
fn test_diesel_option_overwrite() {
- assert_eq!(diesel_option_overwrite(&None), None);
- assert_eq!(diesel_option_overwrite(&Some(String::new())), Some(None));
+ assert_eq!(diesel_option_overwrite(None), None);
+ assert_eq!(diesel_option_overwrite(Some(String::new())), Some(None));
assert_eq!(
- diesel_option_overwrite(&Some("test".to_string())),
+ diesel_option_overwrite(Some("test".to_string())),
Some(Some("test".to_string()))
);
}
diesel_option_overwrite_to_url(&Some(String::new())),
Ok(Some(None))
));
- assert!(matches!(
- diesel_option_overwrite_to_url(&Some("invalid_url".to_string())),
- Err(_)
- ));
+ assert!(diesel_option_overwrite_to_url(&Some("invalid_url".to_string())).is_err());
let example_url = "https://example.com";
assert!(matches!(
diesel_option_overwrite_to_url(&Some(example_url.to_string())),
projects / lemmy.git / blobdiff