]> Untitled Git - lemmy.git/blobdiff - crates/db_views/src/registration_application_view.rs
Cache & Optimize Woodpecker CI (#3450)
[lemmy.git] / crates / db_views / src / registration_application_view.rs
index 31f4ad1324c1bccd35547983e926af81ed75dcba..106e41e433fb316151302508a48ee562e975abb4 100644 (file)
@@ -11,24 +11,22 @@ use diesel_async::RunQueryDsl;
 use lemmy_db_schema::{
   schema::{local_user, person, registration_application},
   source::{
-    local_user::{LocalUser, LocalUserSettings},
-    person::{Person, PersonSafe},
+    local_user::LocalUser,
+    person::Person,
     registration_application::RegistrationApplication,
   },
-  traits::{ToSafe, ToSafeSettings, ViewToVec},
+  traits::JoinView,
   utils::{get_conn, limit_and_offset, DbPool},
 };
-use typed_builder::TypedBuilder;
 
-type RegistrationApplicationViewTuple = (
-  RegistrationApplication,
-  LocalUserSettings,
-  PersonSafe,
-  Option<PersonSafe>,
-);
+type RegistrationApplicationViewTuple =
+  (RegistrationApplication, LocalUser, Person, Option<Person>);
 
 impl RegistrationApplicationView {
-  pub async fn read(pool: &DbPool, registration_application_id: i32) -> Result<Self, Error> {
+  pub async fn read(
+    pool: &mut DbPool<'_>,
+    registration_application_id: i32,
+  ) -> Result<Self, Error> {
     let conn = &mut get_conn(pool).await?;
     let person_alias_1 = diesel::alias!(person as person1);
 
@@ -46,11 +44,9 @@ impl RegistrationApplicationView {
         .order_by(registration_application::published.desc())
         .select((
           registration_application::all_columns,
-          LocalUser::safe_settings_columns_tuple(),
-          Person::safe_columns_tuple(),
-          person_alias_1
-            .fields(Person::safe_columns_tuple())
-            .nullable(),
+          local_user::all_columns,
+          person::all_columns,
+          person_alias_1.fields(person::all_columns).nullable(),
         ))
         .first::<RegistrationApplicationViewTuple>(conn)
         .await?;
@@ -64,7 +60,10 @@ impl RegistrationApplicationView {
   }
 
   /// Returns the current unread registration_application count
-  pub async fn get_unread_count(pool: &DbPool, verified_email_only: bool) -> Result<i64, Error> {
+  pub async fn get_unread_count(
+    pool: &mut DbPool<'_>,
+    verified_email_only: bool,
+  ) -> Result<i64, Error> {
     let conn = &mut get_conn(pool).await?;
     let person_alias_1 = diesel::alias!(person as person1);
 
@@ -89,20 +88,20 @@ impl RegistrationApplicationView {
   }
 }
 
-#[derive(TypedBuilder)]
-#[builder(field_defaults(default))]
-pub struct RegistrationApplicationQuery<'a> {
-  #[builder(!default)]
-  pool: &'a DbPool,
-  unread_only: Option<bool>,
-  verified_email_only: Option<bool>,
-  page: Option<i64>,
-  limit: Option<i64>,
+#[derive(Default)]
+pub struct RegistrationApplicationQuery {
+  pub unread_only: Option<bool>,
+  pub verified_email_only: Option<bool>,
+  pub page: Option<i64>,
+  pub limit: Option<i64>,
 }
 
-impl<'a> RegistrationApplicationQuery<'a> {
-  pub async fn list(self) -> Result<Vec<RegistrationApplicationView>, Error> {
-    let conn = &mut get_conn(self.pool).await?;
+impl RegistrationApplicationQuery {
+  pub async fn list(
+    self,
+    pool: &mut DbPool<'_>,
+  ) -> Result<Vec<RegistrationApplicationView>, Error> {
+    let conn = &mut get_conn(pool).await?;
     let person_alias_1 = diesel::alias!(person as person1);
 
     let mut query = registration_application::table
@@ -115,11 +114,9 @@ impl<'a> RegistrationApplicationQuery<'a> {
       .order_by(registration_application::published.desc())
       .select((
         registration_application::all_columns,
-        LocalUser::safe_settings_columns_tuple(),
-        Person::safe_columns_tuple(),
-        person_alias_1
-          .fields(Person::safe_columns_tuple())
-          .nullable(),
+        local_user::all_columns,
+        person::all_columns,
+        person_alias_1.fields(person::all_columns).nullable(),
       ))
       .into_boxed();
 
@@ -140,27 +137,32 @@ impl<'a> RegistrationApplicationQuery<'a> {
 
     let res = query.load::<RegistrationApplicationViewTuple>(conn).await?;
 
-    Ok(RegistrationApplicationView::from_tuple_to_vec(res))
+    Ok(
+      res
+        .into_iter()
+        .map(RegistrationApplicationView::from_tuple)
+        .collect(),
+    )
   }
 }
 
-impl ViewToVec for RegistrationApplicationView {
-  type DbTuple = RegistrationApplicationViewTuple;
-  fn from_tuple_to_vec(items: Vec<Self::DbTuple>) -> Vec<Self> {
-    items
-      .into_iter()
-      .map(|a| Self {
-        registration_application: a.0,
-        creator_local_user: a.1,
-        creator: a.2,
-        admin: a.3,
-      })
-      .collect::<Vec<Self>>()
+impl JoinView for RegistrationApplicationView {
+  type JoinTuple = RegistrationApplicationViewTuple;
+  fn from_tuple(a: Self::JoinTuple) -> Self {
+    Self {
+      registration_application: a.0,
+      creator_local_user: a.1,
+      creator: a.2,
+      admin: a.3,
+    }
   }
 }
 
 #[cfg(test)]
 mod tests {
+  #![allow(clippy::unwrap_used)]
+  #![allow(clippy::indexing_slicing)]
+
   use crate::registration_application_view::{
     RegistrationApplicationQuery,
     RegistrationApplicationView,
@@ -168,8 +170,8 @@ mod tests {
   use lemmy_db_schema::{
     source::{
       instance::Instance,
-      local_user::{LocalUser, LocalUserInsertForm, LocalUserSettings, LocalUserUpdateForm},
-      person::*,
+      local_user::{LocalUser, LocalUserInsertForm, LocalUserUpdateForm},
+      person::{Person, PersonInsertForm},
       registration_application::{
         RegistrationApplication,
         RegistrationApplicationInsertForm,
@@ -185,8 +187,11 @@ mod tests {
   #[serial]
   async fn test_crud() {
     let pool = &build_db_pool_for_tests().await;
+    let pool = &mut pool.into();
 
-    let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap();
+    let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string())
+      .await
+      .unwrap();
 
     let timmy_person_form = PersonInsertForm::builder()
       .name("timmy_rav".into())
@@ -269,8 +274,8 @@ mod tests {
       .unwrap();
 
     let mut expected_sara_app_view = RegistrationApplicationView {
-      registration_application: sara_app.to_owned(),
-      creator_local_user: LocalUserSettings {
+      registration_application: sara_app.clone(),
+      creator_local_user: LocalUser {
         id: inserted_sara_local_user.id,
         person_id: inserted_sara_local_user.person_id,
         email: inserted_sara_local_user.email,
@@ -288,14 +293,19 @@ mod tests {
         show_new_post_notifs: inserted_sara_local_user.show_new_post_notifs,
         email_verified: inserted_sara_local_user.email_verified,
         accepted_application: inserted_sara_local_user.accepted_application,
+        totp_2fa_secret: inserted_sara_local_user.totp_2fa_secret,
+        totp_2fa_url: inserted_sara_local_user.totp_2fa_url,
+        password_encrypted: inserted_sara_local_user.password_encrypted,
+        open_links_in_new_tab: inserted_sara_local_user.open_links_in_new_tab,
+        infinite_scroll_enabled: inserted_sara_local_user.infinite_scroll_enabled,
       },
-      creator: PersonSafe {
+      creator: Person {
         id: inserted_sara_person.id,
-        name: inserted_sara_person.name.to_owned(),
+        name: inserted_sara_person.name.clone(),
         display_name: None,
         published: inserted_sara_person.published,
         avatar: None,
-        actor_id: inserted_sara_person.actor_id.to_owned(),
+        actor_id: inserted_sara_person.actor_id.clone(),
         local: true,
         banned: false,
         ban_expires: None,
@@ -305,10 +315,13 @@ mod tests {
         bio: None,
         banner: None,
         updated: None,
-        inbox_url: inserted_sara_person.inbox_url.to_owned(),
+        inbox_url: inserted_sara_person.inbox_url.clone(),
         shared_inbox_url: None,
         matrix_user_id: None,
         instance_id: inserted_instance.id,
+        private_key: inserted_sara_person.private_key,
+        public_key: inserted_sara_person.public_key,
+        last_refreshed_at: inserted_sara_person.last_refreshed_at,
       },
       admin: None,
     };
@@ -316,20 +329,17 @@ mod tests {
     assert_eq!(read_sara_app_view, expected_sara_app_view);
 
     // Do a batch read of the applications
-    let apps = RegistrationApplicationQuery::builder()
-      .pool(pool)
-      .unread_only(Some(true))
-      .build()
-      .list()
-      .await
-      .unwrap();
+    let apps = RegistrationApplicationQuery {
+      unread_only: (Some(true)),
+      ..Default::default()
+    }
+    .list(pool)
+    .await
+    .unwrap();
 
     assert_eq!(
       apps,
-      [
-        read_jess_app_view.to_owned(),
-        expected_sara_app_view.to_owned()
-      ]
+      [read_jess_app_view.clone(), expected_sara_app_view.clone()]
     );
 
     // Make sure the counts are correct
@@ -367,13 +377,13 @@ mod tests {
       .accepted_application = true;
     expected_sara_app_view.registration_application.admin_id = Some(inserted_timmy_person.id);
 
-    expected_sara_app_view.admin = Some(PersonSafe {
+    expected_sara_app_view.admin = Some(Person {
       id: inserted_timmy_person.id,
-      name: inserted_timmy_person.name.to_owned(),
+      name: inserted_timmy_person.name.clone(),
       display_name: None,
       published: inserted_timmy_person.published,
       avatar: None,
-      actor_id: inserted_timmy_person.actor_id.to_owned(),
+      actor_id: inserted_timmy_person.actor_id.clone(),
       local: true,
       banned: false,
       ban_expires: None,
@@ -383,22 +393,25 @@ mod tests {
       bio: None,
       banner: None,
       updated: None,
-      inbox_url: inserted_timmy_person.inbox_url.to_owned(),
+      inbox_url: inserted_timmy_person.inbox_url.clone(),
       shared_inbox_url: None,
       matrix_user_id: None,
       instance_id: inserted_instance.id,
+      private_key: inserted_timmy_person.private_key,
+      public_key: inserted_timmy_person.public_key,
+      last_refreshed_at: inserted_timmy_person.last_refreshed_at,
     });
     assert_eq!(read_sara_app_view_after_approve, expected_sara_app_view);
 
     // Do a batch read of apps again
     // It should show only jessicas which is unresolved
-    let apps_after_resolve = RegistrationApplicationQuery::builder()
-      .pool(pool)
-      .unread_only(Some(true))
-      .build()
-      .list()
-      .await
-      .unwrap();
+    let apps_after_resolve = RegistrationApplicationQuery {
+      unread_only: (Some(true)),
+      ..Default::default()
+    }
+    .list(pool)
+    .await
+    .unwrap();
     assert_eq!(apps_after_resolve, vec![read_jess_app_view]);
 
     // Make sure the counts are correct
@@ -408,10 +421,8 @@ mod tests {
     assert_eq!(unread_count_after_approve, 1);
 
     // Make sure the not undenied_only has all the apps
-    let all_apps = RegistrationApplicationQuery::builder()
-      .pool(pool)
-      .build()
-      .list()
+    let all_apps = RegistrationApplicationQuery::default()
+      .list(pool)
       .await
       .unwrap();
     assert_eq!(all_apps.len(), 2);