Make functions work with both connection and pool (#3420)

[lemmy.git] / crates / routes / src / webfinger.rs

diff --git a/crates/routes/src/webfinger.rs b/crates/routes/src/webfinger.rs
index 5c5387d58451a438116e5101bd6ec0f9c6dfff76..72adc95029bbe387af146cdb61e61c993245d743 100644 (file)
--- a/crates/routes/src/webfinger.rs
+++ b/crates/routes/src/webfinger.rs
@@ -1,16 +1,17 @@
-use actix_web::{error::ErrorBadRequest, web::Query, *};
-use anyhow::anyhow;
-use lemmy_api_structs::{blocking, WebFingerLink, WebFingerResponse};
-use lemmy_db_queries::source::{community::Community_, user::User};
-use lemmy_db_schema::source::{community::Community, user::User_};
-use lemmy_utils::{
-  settings::Settings,
-  LemmyError,
-  WEBFINGER_COMMUNITY_REGEX,
-  WEBFINGER_USER_REGEX,
+use activitypub_federation::{
+  config::Data,
+  fetch::webfinger::{extract_webfinger_name, Webfinger, WebfingerLink},
 };
-use lemmy_websocket::LemmyContext;
+use actix_web::{web, web::Query, HttpResponse};
+use lemmy_api_common::context::LemmyContext;
+use lemmy_db_schema::{
+  source::{community::Community, person::Person},
+  traits::ApubActor,
+};
+use lemmy_utils::error::LemmyError;
 use serde::Deserialize;
+use std::collections::HashMap;
+use url::Url;
 
 #[derive(Deserialize)]
 struct Params {
@@ -18,12 +19,10 @@ struct Params {
 }
 
 pub fn config(cfg: &mut web::ServiceConfig) {
-  if Settings::get().federation.enabled {
-    cfg.route(
-      ".well-known/webfinger",
-      web::get().to(get_webfinger_response),
-    );
-  }
+  cfg.route(
+    ".well-known/webfinger",
+    web::get().to(get_webfinger_response),
+  );
 }
 
 /// Responds to webfinger requests of the following format. There isn't any real documentation for
@@ -34,62 +33,63 @@ pub fn config(cfg: &mut web::ServiceConfig) {
 /// https://radical.town/.well-known/webfinger?resource=acct:felix@radical.town
 async fn get_webfinger_response(
   info: Query<Params>,
-  context: web::Data<LemmyContext>,
-) -> Result<HttpResponse, Error> {
-  let community_regex_parsed = WEBFINGER_COMMUNITY_REGEX
-    .captures(&info.resource)
-    .map(|c| c.get(1))
-    .flatten();
+  context: Data<LemmyContext>,
+) -> Result<HttpResponse, LemmyError> {
+  let name = extract_webfinger_name(&info.resource, &context)?;
 
-  let user_regex_parsed = WEBFINGER_USER_REGEX
-    .captures(&info.resource)
-    .map(|c| c.get(1))
-    .flatten();
+  let name_ = name.clone();
+  let user_id: Option<Url> = Person::read_from_name(&mut context.pool(), &name_, false)
+    .await
+    .ok()
+    .map(|c| c.actor_id.into());
+  let community_id: Option<Url> = Community::read_from_name(&mut context.pool(), &name, false)
+    .await
+    .ok()
+    .map(|c| c.actor_id.into());
 
-  let url = if let Some(community_name) = community_regex_parsed {
-    let community_name = community_name.as_str().to_owned();
-    // Make sure the requested community exists.
-    blocking(context.pool(), move |conn| {
-      Community::read_from_name(conn, &community_name)
-    })
-    .await?
-    .map_err(|_| ErrorBadRequest(LemmyError::from(anyhow!("not_found"))))?
-    .actor_id
-  } else if let Some(user_name) = user_regex_parsed {
-    let user_name = user_name.as_str().to_owned();
-    // Make sure the requested user exists.
-    blocking(context.pool(), move |conn| {
-      User_::read_from_name(conn, &user_name)
-    })
-    .await?
-    .map_err(|_| ErrorBadRequest(LemmyError::from(anyhow!("not_found"))))?
-    .actor_id
-  } else {
-    return Err(ErrorBadRequest(LemmyError::from(anyhow!("not_found"))));
+  // Mastodon seems to prioritize the last webfinger item in case of duplicates. Put
+  // community last so that it gets prioritized. For Lemmy the order doesnt matter.
+  let links = vec![
+    webfinger_link_for_actor(user_id, "Person"),
+    webfinger_link_for_actor(community_id, "Group"),
+  ]
+  .into_iter()
+  .flatten()
+  .collect();
+
+  let json = Webfinger {
+    subject: info.resource.clone(),
+    links,
+    ..Default::default()
   };
 
-  let json = WebFingerResponse {
-    subject: info.resource.to_owned(),
-    aliases: vec![url.to_owned().into()],
-    links: vec![
-      WebFingerLink {
+  Ok(HttpResponse::Ok().json(json))
+}
+
+fn webfinger_link_for_actor(url: Option<Url>, kind: &str) -> Vec<WebfingerLink> {
+  if let Some(url) = url {
+    let mut properties = HashMap::new();
+    properties.insert(
+      "https://www.w3.org/ns/activitystreams#type"
+        .parse()
+        .expect("parse url"),
+      kind.to_string(),
+    );
+    vec![
+      WebfingerLink {
         rel: Some("http://webfinger.net/rel/profile-page".to_string()),
-        type_: Some("text/html".to_string()),
-        href: Some(url.to_owned().into()),
-        template: None,
+        kind: Some("text/html".to_string()),
+        href: Some(url.clone()),
+        ..Default::default()
       },
-      WebFingerLink {
+      WebfingerLink {
         rel: Some("self".to_string()),
-        type_: Some("application/activity+json".to_string()),
-        href: Some(url.into()),
-        template: None,
-      }, // TODO: this also needs to return the subscribe link once that's implemented
-         //{
-         //  "rel": "http://ostatus.org/schema/1.0/subscribe",
-         //  "template": "https://my_instance.com/authorize_interaction?uri={uri}"
-         //}
-    ],
-  };
-
-  Ok(HttpResponse::Ok().json(json))
+        kind: Some("application/activity+json".to_string()),
+        href: Some(url),
+        properties,
+      },
+    ]
+  } else {
+    vec![]
+  }
 }