Dont swallow API errors (fixes #1834) (#1837)

[lemmy.git] / crates / websocket / src / chat_server.rs

diff --git a/crates/websocket/src/chat_server.rs b/crates/websocket/src/chat_server.rs
index 7ab65aad23e20b4444040a7ca4e9148ea473ee3c..db09ac95ee7eb64c5e791e7e2a4b8bbce19a2e6b 100644 (file)
--- a/crates/websocket/src/chat_server.rs
+++ b/crates/websocket/src/chat_server.rs
@@ -472,9 +472,9 @@ impl ChatServer {
     async move {
       let json: Value = serde_json::from_str(&msg.msg)?;
       let data = &json["data"].to_string();
-      let op = &json["op"].as_str().ok_or(ApiError {
-        message: "Unknown op type".to_string(),
-      })?;
+      let op = &json["op"]
+        .as_str()
+        .ok_or_else(|| ApiError::err_plain("missing op"))?;
 
       if let Ok(user_operation_crud) = UserOperationCrud::from_str(op) {
         let fut = (message_handler_crud)(context, msg.id, user_operation_crud.clone(), data);