X-Git-Url: http://these/git/?a=blobdiff_plain;f=crates%2Fapi%2Fsrc%2Fcomment_report%2Fcreate.rs;h=190e47a1e5d2a1247eb3b4e6a3e46a2566a74414;hb=3471f3533cb724b2cf6953d563aadfcc9f66c1d2;hp=5a93fa02e6943c81b2e7f7fb80ccdfe108995789;hpb=235cc8b22897bfb3e71ba3dbd725d36863fea8ba;p=lemmy.git diff --git a/crates/api/src/comment_report/create.rs b/crates/api/src/comment_report/create.rs index 5a93fa02..190e47a1 100644 --- a/crates/api/src/comment_report/create.rs +++ b/crates/api/src/comment_report/create.rs @@ -1,11 +1,15 @@ use crate::{check_report_reason, Perform}; -use activitypub_federation::core::object_id::ObjectId; use actix_web::web::Data; use lemmy_api_common::{ comment::{CommentReportResponse, CreateCommentReport}, - utils::{blocking, check_community_ban, get_local_user_view_from_jwt}, + context::LemmyContext, + utils::{ + check_community_ban, + local_user_view_from_jwt, + sanitize_html, + send_new_report_email_to_admins, + }, }; -use lemmy_apub::protocol::activities::community::report::Report; use lemmy_db_schema::{ source::{ comment_report::{CommentReport, CommentReportForm}, @@ -14,75 +18,58 @@ use lemmy_db_schema::{ traits::Reportable, }; use lemmy_db_views::structs::{CommentReportView, CommentView}; -use lemmy_utils::{error::LemmyError, ConnectionId}; -use lemmy_websocket::{messages::SendModRoomMessage, LemmyContext, UserOperation}; +use lemmy_utils::error::{LemmyError, LemmyErrorExt, LemmyErrorType}; /// Creates a comment report and notifies the moderators of the community #[async_trait::async_trait(?Send)] impl Perform for CreateCommentReport { type Response = CommentReportResponse; - #[tracing::instrument(skip(context, websocket_id))] + #[tracing::instrument(skip(context))] async fn perform( &self, context: &Data, - websocket_id: Option, ) -> Result { let data: &CreateCommentReport = self; - let local_user_view = - get_local_user_view_from_jwt(&data.auth, context.pool(), context.secret()).await?; - let local_site = blocking(context.pool(), LocalSite::read).await??; + let local_user_view = local_user_view_from_jwt(&data.auth, context).await?; + let local_site = LocalSite::read(&mut context.pool()).await?; - let reason = self.reason.trim(); - check_report_reason(reason, &local_site)?; + let reason = sanitize_html(self.reason.trim()); + check_report_reason(&reason, &local_site)?; let person_id = local_user_view.person.id; let comment_id = data.comment_id; - let comment_view = blocking(context.pool(), move |conn| { - CommentView::read(conn, comment_id, None) - }) - .await??; + let comment_view = CommentView::read(&mut context.pool(), comment_id, None).await?; - check_community_ban(person_id, comment_view.community.id, context.pool()).await?; + check_community_ban(person_id, comment_view.community.id, &mut context.pool()).await?; let report_form = CommentReportForm { creator_id: person_id, comment_id, original_comment_text: comment_view.comment.content, - reason: reason.to_owned(), + reason, }; - let report = blocking(context.pool(), move |conn| { - CommentReport::report(conn, &report_form) - }) - .await? - .map_err(|e| LemmyError::from_error_message(e, "couldnt_create_report"))?; - - let comment_report_view = blocking(context.pool(), move |conn| { - CommentReportView::read(conn, report.id, person_id) - }) - .await??; - - let res = CommentReportResponse { - comment_report_view, - }; + let report = CommentReport::report(&mut context.pool(), &report_form) + .await + .with_lemmy_type(LemmyErrorType::CouldntCreateReport)?; - context.chat_server().do_send(SendModRoomMessage { - op: UserOperation::CreateCommentReport, - response: res.clone(), - community_id: comment_view.community.id, - websocket_id, - }); + let comment_report_view = + CommentReportView::read(&mut context.pool(), report.id, person_id).await?; - Report::send( - ObjectId::new(comment_view.comment.ap_id), - &local_user_view.person.into(), - ObjectId::new(comment_view.community.actor_id), - reason.to_string(), - context, - ) - .await?; + // Email the admins + if local_site.reports_email_admins { + send_new_report_email_to_admins( + &comment_report_view.creator.name, + &comment_report_view.comment_creator.name, + &mut context.pool(), + context.settings(), + ) + .await?; + } - Ok(res) + Ok(CommentReportResponse { + comment_report_view, + }) } }