X-Git-Url: http://these/git/?a=blobdiff_plain;f=crates%2Fapi_crud%2Fsrc%2Fuser%2Fcreate.rs;h=f2af6940e05867d6c92f846876401fc58c5c06b5;hb=3471f3533cb724b2cf6953d563aadfcc9f66c1d2;hp=00ef7db64fe12431beac3006285f119f228e0712;hpb=cb44b1471705de503e609fbd835fca2a77cce2db;p=lemmy.git

diff --git a/crates/api_crud/src/user/create.rs b/crates/api_crud/src/user/create.rs
index 00ef7db6..f2af6940 100644
--- a/crates/api_crud/src/user/create.rs
+++ b/crates/api_crud/src/user/create.rs
@@ -1,259 +1,165 @@
 use crate::PerformCrud;
+use activitypub_federation::http_signatures::generate_actor_keypair;
 use actix_web::web::Data;
 use lemmy_api_common::{
-  blocking,
-  honeypot_check,
-  password_length_check,
-  person::*,
-  send_verification_email,
-};
-use lemmy_apub::{
-  generate_followers_url,
-  generate_inbox_url,
-  generate_local_apub_endpoint,
-  generate_shared_inbox_url,
-  EndpointType,
+  context::LemmyContext,
+  person::{LoginResponse, Register},
+  utils::{
+    generate_inbox_url,
+    generate_local_apub_endpoint,
+    generate_shared_inbox_url,
+    honeypot_check,
+    local_site_to_slur_regex,
+    password_length_check,
+    sanitize_html,
+    send_new_applicant_email_to_admins,
+    send_verification_email,
+    EndpointType,
+  },
 };
 use lemmy_db_schema::{
-  aggregates::person_aggregates::PersonAggregates,
-  newtypes::CommunityId,
+  aggregates::structs::PersonAggregates,
   source::{
-    community::{
-      Community,
-      CommunityFollower,
-      CommunityFollowerForm,
-      CommunityForm,
-      CommunityModerator,
-      CommunityModeratorForm,
-    },
-    local_user::{LocalUser, LocalUserForm},
-    person::{Person, PersonForm},
-    registration_application::{RegistrationApplication, RegistrationApplicationForm},
-    site::Site,
+    captcha_answer::{CaptchaAnswer, CheckCaptchaAnswer},
+    local_user::{LocalUser, LocalUserInsertForm},
+    person::{Person, PersonInsertForm},
+    registration_application::{RegistrationApplication, RegistrationApplicationInsertForm},
   },
-  traits::{Crud, Followable, Joinable},
+  traits::Crud,
+  RegistrationMode,
 };
-use lemmy_db_views::local_user_view::LocalUserView;
-use lemmy_db_views_actor::person_view::PersonViewSafe;
+use lemmy_db_views::structs::{LocalUserView, SiteView};
 use lemmy_utils::{
-  apub::generate_actor_keypair,
   claims::Claims,
-  utils::{check_slurs, is_valid_actor_name},
-  ConnectionId,
-  LemmyError,
+  error::{LemmyError, LemmyErrorExt, LemmyErrorType},
+  utils::{
+    slurs::{check_slurs, check_slurs_opt},
+    validation::is_valid_actor_name,
+  },
 };
-use lemmy_websocket::{messages::CheckCaptcha, LemmyContext};
 
 #[async_trait::async_trait(?Send)]
 impl PerformCrud for Register {
   type Response = LoginResponse;
 
-  #[tracing::instrument(skip(self, context, _websocket_id))]
-  async fn perform(
-    &self,
-    context: &Data<LemmyContext>,
-    _websocket_id: Option<ConnectionId>,
-  ) -> Result<LoginResponse, LemmyError> {
+  #[tracing::instrument(skip(self, context))]
+  async fn perform(&self, context: &Data<LemmyContext>) -> Result<LoginResponse, LemmyError> {
     let data: &Register = self;
 
-    // no email verification, or applications if the site is not setup yet
-    let (mut email_verification, mut require_application) = (false, false);
+    let site_view = SiteView::read_local(&mut context.pool()).await?;
+    let local_site = site_view.local_site;
+    let require_registration_application =
+      local_site.registration_mode == RegistrationMode::RequireApplication;
 
-    // Make sure site has open registration
-    if let Ok(site) = blocking(context.pool(), Site::read_local_site).await? {
-      if !site.open_registration {
-        return Err(LemmyError::from_message("registration_closed"));
-      }
-      email_verification = site.require_email_verification;
-      require_application = site.require_application;
+    if local_site.registration_mode == RegistrationMode::Closed {
+      return Err(LemmyErrorType::RegistrationClosed)?;
     }
 
     password_length_check(&data.password)?;
     honeypot_check(&data.honeypot)?;
 
-    if email_verification && data.email.is_none() {
-      return Err(LemmyError::from_message("email_required"));
+    if local_site.require_email_verification && data.email.is_none() {
+      return Err(LemmyErrorType::EmailRequired)?;
     }
 
-    if require_application && data.answer.is_none() {
-      return Err(LemmyError::from_message(
-        "registration_application_answer_required",
-      ));
+    if local_site.site_setup && require_registration_application && data.answer.is_none() {
+      return Err(LemmyErrorType::RegistrationApplicationAnswerRequired)?;
     }
 
     // Make sure passwords match
     if data.password != data.password_verify {
-      return Err(LemmyError::from_message("passwords_dont_match"));
+      return Err(LemmyErrorType::PasswordsDoNotMatch)?;
     }
 
-    // Check if there are admins. False if admins exist
-    let no_admins = blocking(context.pool(), move |conn| {
-      PersonViewSafe::admins(conn).map(|a| a.is_empty())
-    })
-    .await??;
-
-    // If its not the admin, check the captcha
-    if !no_admins && context.settings().captcha.enabled {
-      let check = context
-        .chat_server()
-        .send(CheckCaptcha {
-          uuid: data
-            .captcha_uuid
-            .to_owned()
-            .unwrap_or_else(|| "".to_string()),
-          answer: data
-            .captcha_answer
-            .to_owned()
-            .unwrap_or_else(|| "".to_string()),
-        })
+    if local_site.site_setup && local_site.captcha_enabled {
+      if let Some(captcha_uuid) = &data.captcha_uuid {
+        let uuid = uuid::Uuid::parse_str(captcha_uuid)?;
+        let check = CaptchaAnswer::check_captcha(
+          &mut context.pool(),
+          CheckCaptchaAnswer {
+            uuid,
+            answer: data.captcha_answer.clone().unwrap_or_default(),
+          },
+        )
         .await?;
-      if !check {
-        return Err(LemmyError::from_message("captcha_incorrect"));
+        if !check {
+          return Err(LemmyErrorType::CaptchaIncorrect)?;
+        }
+      } else {
+        return Err(LemmyErrorType::CaptchaIncorrect)?;
       }
     }
 
-    check_slurs(&data.username, &context.settings().slur_regex())?;
+    let slur_regex = local_site_to_slur_regex(&local_site);
+    check_slurs(&data.username, &slur_regex)?;
+    check_slurs_opt(&data.answer, &slur_regex)?;
+    let username = sanitize_html(&data.username);
 
     let actor_keypair = generate_actor_keypair()?;
-    if !is_valid_actor_name(&data.username, context.settings().actor_name_max_length) {
-      return Err(LemmyError::from_message("invalid_username"));
-    }
+    is_valid_actor_name(&data.username, local_site.actor_name_max_length as usize)?;
     let actor_id = generate_local_apub_endpoint(
       EndpointType::Person,
       &data.username,
       &context.settings().get_protocol_and_hostname(),
     )?;
 
+    if let Some(email) = &data.email {
+      if LocalUser::is_email_taken(&mut context.pool(), email).await? {
+        return Err(LemmyErrorType::EmailAlreadyExists)?;
+      }
+    }
+
     // We have to create both a person, and local_user
 
     // Register the new person
-    let person_form = PersonForm {
-      name: data.username.to_owned(),
-      actor_id: Some(actor_id.clone()),
-      private_key: Some(Some(actor_keypair.private_key)),
-      public_key: actor_keypair.public_key,
-      inbox_url: Some(generate_inbox_url(&actor_id)?),
-      shared_inbox_url: Some(Some(generate_shared_inbox_url(&actor_id)?)),
-      admin: Some(no_admins),
-      ..PersonForm::default()
-    };
+    let person_form = PersonInsertForm::builder()
+      .name(username)
+      .actor_id(Some(actor_id.clone()))
+      .private_key(Some(actor_keypair.private_key))
+      .public_key(actor_keypair.public_key)
+      .inbox_url(Some(generate_inbox_url(&actor_id)?))
+      .shared_inbox_url(Some(generate_shared_inbox_url(&actor_id)?))
+      // If its the initial site setup, they are an admin
+      .admin(Some(!local_site.site_setup))
+      .instance_id(site_view.site.instance_id)
+      .build();
 
     // insert the person
-    let inserted_person = blocking(context.pool(), move |conn| {
-      Person::create(conn, &person_form)
-    })
-    .await?
-    .map_err(|e| LemmyError::from_error_message(e, "user_already_exists"))?;
+    let inserted_person = Person::create(&mut context.pool(), &person_form)
+      .await
+      .with_lemmy_type(LemmyErrorType::UserAlreadyExists)?;
 
-    // Create the local user
-    let local_user_form = LocalUserForm {
-      person_id: Some(inserted_person.id),
-      email: Some(data.email.as_deref().map(|s| s.to_owned())),
-      password_encrypted: Some(data.password.to_string()),
-      show_nsfw: Some(data.show_nsfw),
-      email_verified: Some(false),
-      ..LocalUserForm::default()
-    };
+    // Automatically set their application as accepted, if they created this with open registration.
+    // Also fixes a bug which allows users to log in when registrations are changed to closed.
+    let accepted_application = Some(!require_registration_application);
 
-    let inserted_local_user = match blocking(context.pool(), move |conn| {
-      LocalUser::register(conn, &local_user_form)
-    })
-    .await?
-    {
-      Ok(lu) => lu,
-      Err(e) => {
-        let err_type = if e.to_string()
-          == "duplicate key value violates unique constraint \"local_user_email_key\""
-        {
-          "email_already_exists"
-        } else {
-          "user_already_exists"
-        };
-
-        // If the local user creation errored, then delete that person
-        blocking(context.pool(), move |conn| {
-          Person::delete(conn, inserted_person.id)
-        })
-        .await??;
-
-        return Err(LemmyError::from_error_message(e, err_type));
-      }
-    };
-
-    if require_application {
+    // Create the local user
+    let local_user_form = LocalUserInsertForm::builder()
+      .person_id(inserted_person.id)
+      .email(data.email.as_deref().map(str::to_lowercase))
+      .password_encrypted(data.password.to_string())
+      .show_nsfw(Some(data.show_nsfw))
+      .accepted_application(accepted_application)
+      .default_listing_type(Some(local_site.default_post_listing_type))
+      .build();
+
+    let inserted_local_user = LocalUser::create(&mut context.pool(), &local_user_form).await?;
+
+    if local_site.site_setup && require_registration_application {
       // Create the registration application
-      let form = RegistrationApplicationForm {
-        local_user_id: Some(inserted_local_user.id),
+      let form = RegistrationApplicationInsertForm {
+        local_user_id: inserted_local_user.id,
         // We already made sure answer was not null above
-        answer: data.answer.to_owned(),
-        ..RegistrationApplicationForm::default()
+        answer: data.answer.clone().expect("must have an answer"),
       };
 
-      blocking(context.pool(), move |conn| {
-        RegistrationApplication::create(conn, &form)
-      })
-      .await??;
+      RegistrationApplication::create(&mut context.pool(), &form).await?;
     }
 
-    let main_community_keypair = generate_actor_keypair()?;
-
-    // Create the main community if it doesn't exist
-    let protocol_and_hostname = context.settings().get_protocol_and_hostname();
-    let main_community = match blocking(context.pool(), move |conn| {
-      Community::read(conn, CommunityId(2))
-    })
-    .await?
-    {
-      Ok(c) => c,
-      Err(_e) => {
-        let default_community_name = "main";
-        let actor_id = generate_local_apub_endpoint(
-          EndpointType::Community,
-          default_community_name,
-          &protocol_and_hostname,
-        )?;
-        let community_form = CommunityForm {
-          name: default_community_name.to_string(),
-          title: "The Default Community".to_string(),
-          description: Some("The Default Community".to_string()),
-          actor_id: Some(actor_id.to_owned()),
-          private_key: Some(Some(main_community_keypair.private_key)),
-          public_key: main_community_keypair.public_key,
-          followers_url: Some(generate_followers_url(&actor_id)?),
-          inbox_url: Some(generate_inbox_url(&actor_id)?),
-          shared_inbox_url: Some(Some(generate_shared_inbox_url(&actor_id)?)),
-          ..CommunityForm::default()
-        };
-        blocking(context.pool(), move |conn| {
-          Community::create(conn, &community_form)
-        })
-        .await??
-      }
-    };
-
-    // Sign them up for main community no matter what
-    let community_follower_form = CommunityFollowerForm {
-      community_id: main_community.id,
-      person_id: inserted_person.id,
-      pending: false,
-    };
-
-    let follow = move |conn: &'_ _| CommunityFollower::follow(conn, &community_follower_form);
-    blocking(context.pool(), follow)
-      .await?
-      .map_err(|e| LemmyError::from_error_message(e, "community_follower_already_exists"))?;
-
-    // If its an admin, add them as a mod and follower to main
-    if no_admins {
-      let community_moderator_form = CommunityModeratorForm {
-        community_id: main_community.id,
-        person_id: inserted_person.id,
-      };
-
-      let join = move |conn: &'_ _| CommunityModerator::join(conn, &community_moderator_form);
-      blocking(context.pool(), join)
-        .await?
-        .map_err(|e| LemmyError::from_error_message(e, "community_moderator_already_exists"))?;
+    // Email the admins
+    if local_site.application_email_admins {
+      send_new_applicant_email_to_admins(&data.username, &mut context.pool(), context.settings())
+        .await?;
     }
 
     let mut login_response = LoginResponse {
@@ -262,8 +168,10 @@ impl PerformCrud for Register {
       verify_email_sent: false,
     };
 
-    // Log the user in directly if email verification and application aren't required
-    if !require_application && !email_verification {
+    // Log the user in directly if the site is not setup, or email verification and application aren't required
+    if !local_site.site_setup
+      || (!require_registration_application && !local_site.require_email_verification)
+    {
       login_response.jwt = Some(
         Claims::jwt(
           inserted_local_user.id.0,
@@ -273,7 +181,7 @@ impl PerformCrud for Register {
         .into(),
       );
     } else {
-      if email_verification {
+      if local_site.require_email_verification {
         let local_user_view = LocalUserView {
           local_user: inserted_local_user,
           person: inserted_person,
@@ -285,17 +193,18 @@ impl PerformCrud for Register {
           .email
           .clone()
           .expect("email was provided");
+
         send_verification_email(
           &local_user_view,
           &email,
-          context.pool(),
-          &context.settings(),
+          &mut context.pool(),
+          context.settings(),
         )
         .await?;
         login_response.verify_email_sent = true;
       }
 
-      if require_application {
+      if require_registration_application {
         login_response.registration_created = true;
       }
     }