]> Untitled Git - lemmy.git/commitdiff
Don't allow image uploads for non-logged-in users.
authorDessalines <tyhou13@gmx.com>
Fri, 18 Oct 2019 03:19:20 +0000 (20:19 -0700)
committerDessalines <tyhou13@gmx.com>
Fri, 18 Oct 2019 03:19:20 +0000 (20:19 -0700)
- Fixes #297

ui/src/components/comment-form.tsx
ui/src/components/post-form.tsx

index 7c6460a2778729a1844613e35b0985737ad6b07b..2095e9e5f5a7e69f974f60ae653c48a1c990448c 100644 (file)
@@ -139,8 +139,8 @@ export class CommentForm extends Component<CommentFormProps, CommentFormState> {
               {this.props.node && <button type="button" class="btn btn-sm btn-secondary mr-2" onClick={linkEvent(this, this.handleReplyCancel)}><T i18nKey="cancel">#</T></button>}
               <a href={markdownHelpUrl} target="_blank" class="d-inline-block float-right text-muted small font-weight-bold"><T i18nKey="formatting_help">#</T></a>
               <form class="d-inline-block mr-2 float-right text-muted small font-weight-bold">
-                <label htmlFor={`file-upload-${this.id}`} class="pointer"><T i18nKey="upload_image">#</T></label>
-                <input id={`file-upload-${this.id}`} type="file" accept="image/*,video/*" name="file" class="d-none" onChange={linkEvent(this, this.handleImageUpload)} />
+                <label htmlFor={`file-upload-${this.id}`} className={`${UserService.Instance.user && 'pointer'}`}><T i18nKey="upload_image">#</T></label>
+                <input id={`file-upload-${this.id}`} type="file" accept="image/*,video/*" name="file" class="d-none" disabled={!UserService.Instance.user} onChange={linkEvent(this, this.handleImageUpload)} />
               </form>
               {this.state.imageLoading && 
                 <svg class="icon icon-spinner spin"><use xlinkHref="#icon-spinner"></use></svg>
index b59d07d6f062170dab147b2c8d80f5fd0c650385..09b9606eadeb67c82e834049cc5f5328bd16c858 100644 (file)
@@ -112,8 +112,8 @@ export class PostForm extends Component<PostFormProps, PostFormState> {
                 <div class="mt-1 text-muted small font-weight-bold pointer" onClick={linkEvent(this, this.copySuggestedTitle)}><T i18nKey="copy_suggested_title" interpolation={{title: this.state.suggestedTitle}}>#</T></div>
               }
               <form>
-                <label htmlFor="file-upload" class="pointer d-inline-block mr-2 float-right text-muted small font-weight-bold"><T i18nKey="upload_image">#</T></label>
-                <input id="file-upload" type="file" accept="image/*,video/*" name="file" class="d-none" onChange={linkEvent(this, this.handleImageUpload)} />
+                <label htmlFor="file-upload" className={`${UserService.Instance.user && 'pointer'} d-inline-block mr-2 float-right text-muted small font-weight-bold`}><T i18nKey="upload_image">#</T></label>
+                <input id="file-upload" type="file" accept="image/*,video/*" name="file" class="d-none" disabled={!UserService.Instance.user} onChange={linkEvent(this, this.handleImageUpload)} />
               </form>
               {this.state.imageLoading && 
                 <svg class="icon icon-spinner spin"><use xlinkHref="#icon-spinner"></use></svg>