From 8edf69559e88c77249cf341646842cc04f6e8c66 Mon Sep 17 00:00:00 2001 From: HKayn <hakan.koek99@gmail.com> Date: Thu, 3 Aug 2023 18:27:06 +0200 Subject: [PATCH] Fix document title of admin settings being overwritten by tagline and emoji forms (#2003) * Fix document title of admin settings being overwritten * Remove obsolete imports --- src/shared/components/home/emojis-form.tsx | 9 --------- src/shared/components/home/tagline-form.tsx | 8 -------- 2 files changed, 17 deletions(-) diff --git a/src/shared/components/home/emojis-form.tsx b/src/shared/components/home/emojis-form.tsx index b24445d..d6fc2ea 100644 --- a/src/shared/components/home/emojis-form.tsx +++ b/src/shared/components/home/emojis-form.tsx @@ -11,7 +11,6 @@ import { customEmojisLookup } from "../../markdown"; import { HttpService, I18NextService } from "../../services"; import { pictrsDeleteToast, toast } from "../../toast"; import { EmojiMart } from "../common/emoji-mart"; -import { HtmlTags } from "../common/html-tags"; import { Icon, Spinner } from "../common/icon"; import { Paginator } from "../common/paginator"; @@ -66,17 +65,9 @@ export class EmojiForm extends Component<EmojiFormProps, EmojiFormState> { this.handlePageChange = this.handlePageChange.bind(this); this.handleEmojiClick = this.handleEmojiClick.bind(this); } - get documentTitle(): string { - return I18NextService.i18n.t("custom_emojis"); - } - render() { return ( <div className="home-emojis-form col-12"> - <HtmlTags - title={this.documentTitle} - path={this.context.router.route.match.url} - /> <h1 className="h4 mb-4">{I18NextService.i18n.t("custom_emojis")}</h1> {customEmojisLookup.size > 0 && ( <div> diff --git a/src/shared/components/home/tagline-form.tsx b/src/shared/components/home/tagline-form.tsx index 78e506b..2d9d93b 100644 --- a/src/shared/components/home/tagline-form.tsx +++ b/src/shared/components/home/tagline-form.tsx @@ -3,7 +3,6 @@ import { capitalizeFirstLetter } from "@utils/helpers"; import { Component, InfernoMouseEvent, linkEvent } from "inferno"; import { EditSite, Tagline } from "lemmy-js-client"; import { I18NextService } from "../../services"; -import { HtmlTags } from "../common/html-tags"; import { Icon, Spinner } from "../common/icon"; import { MarkdownTextArea } from "../common/markdown-textarea"; @@ -26,17 +25,10 @@ export class TaglineForm extends Component<TaglineFormProps, TaglineFormState> { constructor(props: any, context: any) { super(props, context); } - get documentTitle(): string { - return I18NextService.i18n.t("taglines"); - } render() { return ( <div className="tagline-form col-12"> - <HtmlTags - title={this.documentTitle} - path={this.context.router.route.match.url} - /> <h1 className="h4 mb-4">{I18NextService.i18n.t("taglines")}</h1> <div className="table-responsive col-12"> <table id="taglines_table" className="table table-sm table-hover"> -- 2.44.1