From: Nutomic <me@nutomic.com>
Date: Mon, 5 Jun 2023 11:56:53 +0000 (+0200)
Subject: Filter empty username strings from Mastodon (fixes #2886) (#2887)
X-Git-Url: http://these/git/readmes/%7B%7D/static/%7B%60https:/%7Burl%7D?a=commitdiff_plain;h=7248c4a6f46f0573b9060625fca3e7c5526b8c3e;p=lemmy.git

Filter empty username strings from Mastodon (fixes #2886) (#2887)

* Filter empty username strings from Mastodon (fixes #2886)

* add issue link
---

diff --git a/crates/apub/src/objects/person.rs b/crates/apub/src/objects/person.rs
index e5431d14..d3422b06 100644
--- a/crates/apub/src/objects/person.rs
+++ b/crates/apub/src/objects/person.rs
@@ -144,9 +144,13 @@ impl Object for ApubPerson {
   ) -> Result<ApubPerson, LemmyError> {
     let instance_id = fetch_instance_actor_for_object(&person.id, context).await?;
 
+    // Some Mastodon users have `name: ""` (empty string), need to convert that to `None`
+    // https://github.com/mastodon/mastodon/issues/25233
+    let display_name = person.name.filter(|n| !n.is_empty());
+
     let person_form = PersonInsertForm {
       name: person.preferred_username,
-      display_name: person.name,
+      display_name,
       banned: None,
       ban_expires: None,
       deleted: Some(false),