Sorry everyone, I opened a new branch off the 2003 release while I was researching some of the bugs in the legacy code. That wasn’t supposed to get merged in…
This just further confirms that the world simulation actually did break from the y2k bug. We fixed the bug in here, but no one fixed the simulation. The cascade failure has just been spreading out of control since then. Now we have recursion errors! The sim tried to restart but it’s all corrupt lol.
I think the root problem lies in some of the really gnarly, pre-1.0 code that we are afraid to touch because it might break something, that’s why it keeps cropping up even though we keep slapping patches pell-mell on top of it. It just happened to pop out pretty bad in 03.
This is why I’ve been arguing against rebase merges. If we aren’t super careful with older branches, we end up with messes like this.
Maybe just squash and merge in the future?
I don’t know, this whole situation could have been avoided if people would just check with the team before merging stuff. I think people see revisions from old releases so they just merge them because they “worked before” so they should work now. It doesn’t work for the current userbase, frankly it didn’t work all that well for most users back when it was released the first time. Just merging any old crap straight into main without reading it so they can brag about how many PRs they close.
As usual, policy and procedures without properly defined controls burn us.
Honestly, why did we even go through that whole re-org after the WW2 outage if we’re not actually going to adhere to our own policies?
Sorry everyone, I opened a new branch off the
2003release while I was researching some of the bugs in the legacy code. That wasn’t supposed to get merged in…This just further confirms that the world simulation actually did break from the y2k bug. We fixed the bug in here, but no one fixed the simulation. The cascade failure has just been spreading out of control since then. Now we have recursion errors! The sim tried to restart but it’s all corrupt lol.
I think the root problem lies in some of the really gnarly, pre-1.0 code that we are afraid to touch because it might break something, that’s why it keeps cropping up even though we keep slapping patches pell-mell on top of it. It just happened to pop out pretty bad in 03.
This is why I’ve been arguing against rebase merges. If we aren’t super careful with older branches, we end up with messes like this. Maybe just squash and merge in the future?
I don’t know, this whole situation could have been avoided if people would just check with the team before merging stuff. I think people see revisions from old releases so they just merge them because they “worked before” so they should work now. It doesn’t work for the current userbase, frankly it didn’t work all that well for most users back when it was released the first time. Just merging any old crap straight into main without reading it so they can brag about how many PRs they close.
As usual, policy and procedures without properly defined controls burn us. Honestly, why did we even go through that whole re-org after the WW2 outage if we’re not actually going to adhere to our own policies?
Ugh, just tell me you didn’t pull
maininto your working branch again, instead of rebasing. We talked about this.